From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68F0BC25B4F for ; Sun, 12 May 2024 16:28:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7A9E6B00CD; Sun, 12 May 2024 12:28:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDC8D6B0183; Sun, 12 May 2024 12:28:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B818A6B018E; Sun, 12 May 2024 12:28:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 92BC16B00CD for ; Sun, 12 May 2024 12:28:04 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0DF65A09DB for ; Sun, 12 May 2024 16:28:04 +0000 (UTC) X-FDA: 82110275688.14.FB9ACA5 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by imf04.hostedemail.com (Postfix) with ESMTP id 4F56E40007 for ; Sun, 12 May 2024 16:28:02 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.195 as permitted sender) smtp.mailfrom=alex@ghiti.fr; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715531282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=owZnl9ML02VshyxfIm+YcaiDnEmXZzuAPVyC1eYhB4Q=; b=hHyiWecJvKnY8eoyNyr4Wq8a528RDIcOXnh3ES5XbAWprh8vzndpDh0WfldVJqNLv27TNU gBMc1Y7Q858kIOBhmr+7ZPkmCJodien4s4zbKS45Z2Sa6gS/4oQvVRYAPZTUKOc5XWmRK1 ZWyioZLIih41dXqAAtHcBWBFf5MNYlw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715531282; a=rsa-sha256; cv=none; b=nkfkV9/6VD4vGkPZyKGDzGsujf66We7qKR2YSw/FjOuGS32yX4eVOhPtvQWO4s6ODF1OSS d5a7m5X2TdO1Q1s4VYoG7GvX/IbpUkK3J5BKiL4RfXLSTpJhpwBukWcBchdtqjVRCsbtJ2 4qm0Eq4G0L7uzeMTEf1jeoHvjXTdxz4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of alex@ghiti.fr designates 217.70.183.195 as permitted sender) smtp.mailfrom=alex@ghiti.fr; dmarc=none Received: by mail.gandi.net (Postfix) with ESMTPSA id 3B45E60004; Sun, 12 May 2024 16:26:52 +0000 (UTC) Message-ID: <0ea4aff6-980f-4fc6-9ab7-9ca4c9d15d1e@ghiti.fr> Date: Sun, 12 May 2024 18:26:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/29] riscv mm: manufacture shadow stack pte Content-Language: en-US To: Deepak Gupta , paul.walmsley@sifive.com, rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, bjorn@rivosinc.com, alexghiti@rivosinc.com, samuel.holland@sifive.com, conor@kernel.org Cc: linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, corbet@lwn.net, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com, shuah@kernel.org, brauner@kernel.org, andy.chiu@sifive.com, jerry.shih@sifive.com, hankuan.chen@sifive.com, greentime.hu@sifive.com, evan@rivosinc.com, xiao.w.wang@intel.com, charlie@rivosinc.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, dbarboza@ventanamicro.com, sameo@rivosinc.com, shikemeng@huaweicloud.com, willy@infradead.org, vincent.chen@sifive.com, guoren@kernel.org, samitolvanen@google.com, songshuaishuai@tinylab.org, gerg@kernel.org, heiko@sntech.de, bhe@redhat.com, jeeheng.sia@starfivetech.com, cyy@cyyself.name, maskray@google.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bgray@linux.ibm.com, mpe@ellerman.id.au, baruch@tkos.co.il, alx@kernel.org, david@redhat.com, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, shr@devkernel.io, deller@gmx.de, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com References: <20240403234054.2020347-1-debug@rivosinc.com> <20240403234054.2020347-12-debug@rivosinc.com> From: Alexandre Ghiti In-Reply-To: <20240403234054.2020347-12-debug@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-GND-Sasl: alex@ghiti.fr X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4F56E40007 X-Rspam-User: X-Stat-Signature: d1mkn4h4t1ei7b7p3s7tscfyn4mumpk7 X-HE-Tag: 1715531282-347026 X-HE-Meta: U2FsdGVkX1+fWjTreDTbgy/yhDSKUEAy4s2LWXGzEVrwkv3jzAevJXWdACS7Yo7sE/2qV/0vYQsXC4gYZk+LMKhL/hwa3AQ8YA2Yhcilz6Mhw638PCo5KpoUWvtPLkRUszKeerphZVAFC4tOR/JIo5CQft5vLZP9ZGr+BqHklf8FJCcGTj9QmZKk+0Hbt6qXjKjez0NgV36muUFvWh96du0WbkDQiJeaqD6b5jt0tNoTvlnq06dMGabCARFiymdhxD7XNQOui+mBcL65ib6RMq6eFD3/OTOWkUBzDoL+QT8iGGACy0A26PNeT0zu6Ki3s0f29IM61zhtf0cRzACgkPMiA9F+v0e7HBJdS3Xrs47o+kgBkYaQe3HpCBwbxJnCD/OCPBxFTGQ9OmOlh7viexP2MV19obWJ+8avn9iQFePAAXxSqoqNkm5KFCyBVfgG1+3A8MYFxgv/F/ZmPmE+JzXfJoqHQlrVHEFASVtYQYWtUmkkecouAAie8vkYJgMrRG5loSVlx6vTT/AXIYHizyjZ5nvnpQLjZpZfd4QK7NhImPq5N4yeg6JVpruKm7jCQzmO9175bOOnnZFuuqxjLbyOzRci4de7jHhN4mdTG/oMnMyka2pETKLipqdByS0fuCPTXQuyrpk1l+hwcbjE84ikrAD+oqVD3H1ePE3ao1Xoh9EVTO4kHTEfeWTLPu3px3mp/O80fh84F8X0yivyRp9nR0gTABaacEr1YrHMhQVPu0+XcpolGtpfXplFZlkfDhDubbCQ5ApltRXVRFm4fTQfehA1smWsBbtg2YNG16TZy+Jyi805BuRl2z1jH80sChlJoyWTe8ntID2uFZDwgCKUfYUwUTvYzFvZUT6mTNvIIbDaoLSPqlXmFTmgc6asPB8QeR/NjcL3KbstZDUBt5+kWnK2vkR81WbJEIxUatSLujNesg2ta7hgo2bvFBhdw0ksNT6Az2TiOQ+jvOs 6of4TbrR MFTJsMLl4c5RinFOAS9A1kVj8DaXTSCCgoDvepcZ5sq+LRU12eqsN2KC35od225BMkwFRV+t9mi8S4FktSY9+fzC/6InDWBZ4ANjS1WOHt3eUBJxeaOdAnL31sLNYTQZzElVK7xbsrefJ5i5t/LpIw1vUhbrh7FY4Y32nufpw7VwxtSWWk/tiVaNGe7ICfl2fqRSYR7CXdoaxLj+KSndArZDJ0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04/04/2024 01:34, Deepak Gupta wrote: > This patch implements creating shadow stack pte (on riscv). Creating > shadow stack PTE on riscv means that clearing RWX and then setting W=1. > > Signed-off-by: Deepak Gupta > --- > arch/riscv/include/asm/pgtable.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h > index 4d5983bc6766..6362407f1e83 100644 > --- a/arch/riscv/include/asm/pgtable.h > +++ b/arch/riscv/include/asm/pgtable.h > @@ -408,6 +408,12 @@ static inline pte_t pte_mkwrite_novma(pte_t pte) > return __pte(pte_val(pte) | _PAGE_WRITE); > } > > +static inline pte_t pte_mkwrite_shstk(pte_t pte) > +{ > + /* shadow stack on risc-v is XWR = 010. Clear everything and only set _PAGE_WRITE */ Nit: Not sure the comment is necessary > + return __pte((pte_val(pte) & ~(_PAGE_LEAF)) | _PAGE_WRITE); > +} > + > /* static inline pte_t pte_mkexec(pte_t pte) */ > > static inline pte_t pte_mkdirty(pte_t pte) > @@ -693,6 +699,12 @@ static inline pmd_t pmd_mkwrite_novma(pmd_t pmd) > return pte_pmd(pte_mkwrite_novma(pmd_pte(pmd))); > } > > +static inline pmd_t pmd_mkwrite_shstk(pmd_t pte) > +{ > + /* shadow stack on risc-v is XWR = 010. Clear everything and only set _PAGE_WRITE */ > + return __pmd((pmd_val(pte) & ~(_PAGE_LEAF)) | _PAGE_WRITE); > +} > + > static inline pmd_t pmd_wrprotect(pmd_t pmd) > { > return pte_pmd(pte_wrprotect(pmd_pte(pmd))); Otherwise: Reviewed-by: Alexandre Ghiti Thanks, Alex