From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 990EAC3DA4A for ; Mon, 5 Aug 2024 14:43:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22D026B0089; Mon, 5 Aug 2024 10:43:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DD316B008A; Mon, 5 Aug 2024 10:43:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07D7F6B008C; Mon, 5 Aug 2024 10:43:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DB09D6B0089 for ; Mon, 5 Aug 2024 10:43:14 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9119B803A3 for ; Mon, 5 Aug 2024 14:43:14 +0000 (UTC) X-FDA: 82418459508.17.2D3221D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 5CA4F40006 for ; Mon, 5 Aug 2024 14:43:12 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OMycD0rO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722868946; a=rsa-sha256; cv=none; b=IxdwaSoAjtyUWpn2BDrU0+p9CIrF6Bmb4aoONzdQm/LjzBaO3VWV8XXWv466pKI2mTnegV DzNdO4kpkO72INqLcAIawC4CKNnGpzbo1HmKUDG7QBu0zjBuzkWxrFU55Id9pdV3lo68lO PdXJ+JCCd/ORHCJkUlLB+Bh7ph0m+cs= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OMycD0rO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722868946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6GuDOW3hJCpdyMUYToFB5B+sVH2wG3fmOeztI4TFPP4=; b=JJMeyRQihkHGFOlQFxeG04eq5IccbezPSF9AGLXJLusRG5HYZ6jyj9IzWfYOk2wA4lCSWR +MYnX5eXdLMhYJlzULuFI6vGgAIvLU2Apn1SGHNv7COBhv1ONpHeoM44F/pozjMSaDo3M5 Jl7AadqpiU6hoFgkmRTk3HKFe8n7yMo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722868991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6GuDOW3hJCpdyMUYToFB5B+sVH2wG3fmOeztI4TFPP4=; b=OMycD0rOiSJqy0R++wuPrqfmIMcmlGC7oPPo7rjI0g3vspDLYkVZuslVBIhoNA/+v39LnP JDbKvTKZ7DT4PniyZshAVI8bFS8jr1mXUFZdgZC1le9pEv13XUFKMJsdC3c5lpLBsOUrqP h+gns3oHLuZ16JQs9dJAaqs03auh/eI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-524-gLcr6edzM9G6mUQtgHrCtQ-1; Mon, 05 Aug 2024 10:43:08 -0400 X-MC-Unique: gLcr6edzM9G6mUQtgHrCtQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3684ea1537fso5402464f8f.1 for ; Mon, 05 Aug 2024 07:43:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722868987; x=1723473787; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6GuDOW3hJCpdyMUYToFB5B+sVH2wG3fmOeztI4TFPP4=; b=AjPM/aLS+3asKLH0/4Aa2lIpSsch/lxF8e8LFsgr6afqFk/8c8mr9CWzfb9oraAJY8 e5jq4qB374iHnV1FAYHJFaoPOG3V0TQ7mYVIHM8keForQKXgctuItT8c86jlL5iZP2wK 4szh+azP65WchG812epWTsojeIf0vylA/4NTarXm1qrISAKuPqQ7wopwfGjgfSjWGtyB BNN9AHm/61IIai5iWEqaQWtIDSs1akZtnkDnScUTThYD/m8a5n5JsmNz+J83A16Ejd1d m5QG6aLyMA1Mteo8KJVK35GhYsAFf9/hHqt/rK7qnI4LC0iabWgX/ok3m6XEY8fNFjE+ bH6A== X-Gm-Message-State: AOJu0YxQOc8EyP81DWUIVyV48zLKC9vb3jyO6C9+ZTKcmEmD7rWifz0Q WT0cKikSYW30/HEhM7hOihl1htDakZYYHYw2LaCLGCHqpOWvX/2AY5B+wcx5wtlCiMSMMcJFz1q YzPqBJeIHs2SMY+6Al7x7olJjARIG0xvkDo6fd2aiRGqLqJET X-Received: by 2002:a5d:51c1:0:b0:367:89fd:1e06 with SMTP id ffacd0b85a97d-36bbc1312c6mr7963722f8f.36.1722868986832; Mon, 05 Aug 2024 07:43:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFMkMedF4HmP2hN92FNl8AFdQusVzu9OVTEbZeVZDbyeEnLyeXA+g2eAI7Lt35kGbSyyQEfBw== X-Received: by 2002:a5d:51c1:0:b0:367:89fd:1e06 with SMTP id ffacd0b85a97d-36bbc1312c6mr7963705f8f.36.1722868986415; Mon, 05 Aug 2024 07:43:06 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36bbcf0c309sm9981160f8f.20.2024.08.05.07.43.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Aug 2024 07:43:06 -0700 (PDT) Message-ID: <0e8e0503-5796-4b61-bb5b-249e285f5d21@redhat.com> Date: Mon, 5 Aug 2024 16:43:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 1/7] mm: pgtable: make pte_offset_map_nolock() return pmdval To: Qi Zheng , hughd@google.com, willy@infradead.org, mgorman@suse.de, muchun.song@linux.dev, vbabka@kernel.org, akpm@linux-foundation.org, zokeefe@google.com, rientjes@google.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5CA4F40006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: m4s5osbygnengghb6muwxgsqdzymn996 X-HE-Tag: 1722868992-163239 X-HE-Meta: U2FsdGVkX1+1ZFajYwtP2PeYcuDqfmNxzBsJsu++920WeyYJDvGe68XRwCGhQfZStaReIZY1b6IOrE//pAbNv1yyMIBr7yNLOhAi7umU/gnhZQUidqfSDbn7Cf9AfVuYDf0/uu3HkJVN6ZbzhVtExj+s4u7ghWIdZq1aQ5J1zKkhzx99JuaOi/3rurX1OvN2xjDI2arj7Ib9JNvXhwOxYy/um9RB4myz7/dAzRTU3/yqSdcIl34bJ6CXBkJFJXkWH1gMSIuzAsoYoi/3CGVtEh8V2t+cWYEkjUFgfb8ST+Vd2AxDKNprLWat49UY0z4l4o0TcqJk4DL+6uiJsvGy94PWxAhTNx9KycMj55g43500Zh4lZFTLuwHc+UvzDa9Pn1E8Jg5KOK6u4yvfcXC0U0ymT6MV02J9e5BdOMX+hiiWvf1BOpv8fJ+i8LHExL8lmFEdNrB8EmvrXJv/H0KDz7ofaN/kXgLy8FTETARZOvLWr/egsEqtCLBsuMiXgmoWiXAReowdNa6B8M4DhbgFpdcjtOJF3pHdNQaYoEsUYNHEft9v8bS8bVwDmlIl+A0jYpp8PD7t7Nnqs8NMg2C24SqChjfcJ/lrEnThOs+oajFnoapBqTUJZtKu0mP4W8sF2lOZ+FJ+1GhNcLJYCpnJrWRaDZSP5EOQhmDoG9cSO56mlyGCtoTDoCN7hxq4I1V6DZGLpcH5i4jBaVfRrLiGZtzzz9QX6GWuYBdSmT28aaBWKUxYzniapyJFE5FwvnZRxUMFv6a8Uz8ee4QmPh4KF50hdZ5H4G1xOeOpD6fKv9ouiz+tp93shYp7iR/82BBCknYQCTuCZXX2lBD0N1xLmX6mIE6dnpHhGGTCEsF002H5btW8bfKOCzHxDfka03pHWIgj1BdoObmygGWsTZ/lfreO1hUxYpfvXBoA4WeB0tXincnx9HFsRA4APqOwaydU9wNgKTeU6ikzMXUdKo0 l9nduJmb 94co30iPyBD+5QnnsgG4Q+S8gbk2Dlqk7FycQqq1ojYQqZ8JjYhgN1GUdPzL4c6IIfcJcGvahrVjeM7zcz03W9DOXCiMwpaq39SysmSlVb+LdBOH/1eCcxfo2XVpaMb8ZXr4OXSIgZpPXIiVRvuTEla9NkZHEnRRoeFWnX8cuiV5X7fSEzzNMPd4tKHcukRJy6ZrZif0EzzRAlSixC6CqVstIJ7ob3A4MxjRjdCV1huI/aFOPogiSwsYDwkysuWH4nKSjKq/7a5qvB70Cs54uHnrFAjJVEMfezOe+yan5DbnI7qj8obRzFMoWuGjN924hQv4r0DeHTsG6L5N7omli4dNfscw0xMJ12daaBfe0Q8HgAnYWoDSgIckBfrwAh3SdwOqA+OVa8Qz5dgEpSisi5ec3wekKgruwC5/tCZZ8bzPWXqGS0/7+SBhpmpmFyZjOM/SVjSb9V8P0LJkJQ8cOasAGkDKK6Eznp2bE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000608, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.08.24 14:55, Qi Zheng wrote: > Make pte_offset_map_nolock() return pmdval so that we can recheck the > *pmd once the lock is taken. This is a preparation for freeing empty > PTE pages, no functional changes are expected. Skimming the patches, only patch #4 updates one of the callsites (collapse_pte_mapped_thp). Wouldn't we have to recheck if the PMD val changed in more cases after taking the PTL? If not, would it make sense to have a separate function that returns the pmdval and we won't have to update each and every callsite? -- Cheers, David / dhildenb