From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E734CD343A for ; Tue, 3 Sep 2024 14:13:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D82C38D0175; Tue, 3 Sep 2024 10:13:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D33848D0151; Tue, 3 Sep 2024 10:13:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD3AA8D0175; Tue, 3 Sep 2024 10:13:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9D31F8D0151 for ; Tue, 3 Sep 2024 10:13:27 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4944816046A for ; Tue, 3 Sep 2024 14:13:27 +0000 (UTC) X-FDA: 82523619654.02.296D65A Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf07.hostedemail.com (Postfix) with ESMTP id 59EBD40006 for ; Tue, 3 Sep 2024 14:13:24 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hgtlbWxp; dmarc=none; spf=pass (imf07.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725372734; a=rsa-sha256; cv=none; b=ayWxw+N71G/tu8r4Scv8fItl6yXbscGzcLuqk//8uoB9OcO/oJPSvnEg/JyszDthomWtqw U3IWygnUHtfawjQrJb55GTK5jci6RK3yJ9ouEsapK+PSfzJOJTimWsn3EMIHv1aOtggHsf CweqvSF7rMInukHgaibH7e5RfOuE21s= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hgtlbWxp; dmarc=none; spf=pass (imf07.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725372734; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SrPZGJn6KWoXZtLiezcU+c0qMmF52QD9yccf17rPGTI=; b=nlZe6JiuT2nlquiVQNFzsl8EVRL7HAPj89/ymaZHzzH4PEhwY6IF2AVUjLXg12w8xc9svj KKnVm44y7kP+bd2wJc2t/XfJ34BwoQ0pUXER/yWfAY5V2KlPmnSdDi0ilH34BPhmM7QdTX A7dNOkaZ8c6t69dpTckj4cIv79OufFQ= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-71456acebe8so4118979b3a.3 for ; Tue, 03 Sep 2024 07:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725372803; x=1725977603; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=SrPZGJn6KWoXZtLiezcU+c0qMmF52QD9yccf17rPGTI=; b=hgtlbWxp6f8NT833kdJZecxUOmyZeniUWhG84+RThLHBkznV7kKKGkK6mwu209hS9x pJVa+GUvtnRhcTPsRjZfNnyHxdqa7nZKl/Dl1/SppvTpv5jnJJ+6V03BEB94MlgQXU1E e9mmb2LlK8E9kIADjAEqTNJJklacBOprsCRWlE79jxJ3feSLwtkWb+m7UgFTmzr4vYcb 7dqKYshtbwPCPgmA/Ow8wvOVTtW7OAG1RwX0KDJ9fDne7QWZFwvh/9Bn/51o4ZSlHz+I wEsO1IL95w3UmYCXXt6RHWE6GK1Bh+3bRQdZvsJ1H/2Fm2ETevMeBRJ/Qs1FdydjSYw6 9tZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725372803; x=1725977603; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SrPZGJn6KWoXZtLiezcU+c0qMmF52QD9yccf17rPGTI=; b=Ys1ohU3EOaY5/10eqmkScbF/Gu1dufKRqigOuYjB1fVBNk/jSIv6oMTYnZKe0cfCl+ 2pZLv8KlMNSBPYRCMOBUW3FYtdcOqcA/raZEAi7cxz82Iu0l4BqM+W0Z1HiIsNWXjn/5 AjFYsfXKdDXcuDqdpci5S7u46yaBC5LrMWVA7Or8SVE1c62ivWO5X/3orkZ+kvGZuO4l gKIGeQaI8rxVpJA9lnRvuAvTmr/C4LPgrxQpU2/va9oSNLTUz86CiI/iDcCGcCQS9YUj alTUUFLVb4gd/zfHk3F8ekNhCD7PV2Z4Vt+dKeNaFaPHsYV6Q76+1bMES2jliN6m2jTv aA6g== X-Forwarded-Encrypted: i=1; AJvYcCXHBfMwOx/zS5AldP5Wlab0ox3cvzHxASheBjgFhXSFH4qmlecoX8iC0aYBK+XdaealaQjMh+7heQ==@kvack.org X-Gm-Message-State: AOJu0Yw59acHEpy0hs7djFme9bORCk9T62ExrJzLu2RM7//NNqMx0eiJ d0DNLPoIdGrvcVftgMrnwsvMGVjRzjTZrtYoi4VHVDVxJXAdcWes X-Google-Smtp-Source: AGHT+IEjRbIOY72pGCBavbHe7BJELVDZYV3WLdduDbQaH6rRYLYRoQUnq6dTD/kZle9J6gIeR3MBdg== X-Received: by 2002:a17:902:e74b:b0:201:f409:ce73 with SMTP id d9443c01a7336-2050c4cf204mr198209875ad.65.1725372802888; Tue, 03 Sep 2024 07:13:22 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-205f6d30bb6sm20361615ad.211.2024.09.03.07.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 07:13:21 -0700 (PDT) Date: Tue, 3 Sep 2024 07:13:20 -0700 From: Guenter Roeck To: Helge Deller Cc: Linus Torvalds , Richard Henderson , Vlastimil Babka , linux-kernel@vger.kernel.org, Linux-MM , linux-parisc@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH 6.10 000/809] 6.10.3-rc3 review Message-ID: <0e8cf563-345d-4fd4-b0ff-d80e0c7ac29c@roeck-us.net> References: <90e02d99-37a2-437e-ad42-44b80c4e94f6@suse.cz> <87frrh44mf.ffs@tglx> <76c643ee-17d6-463b-8ee1-4e30b0133671@roeck-us.net> <87plqjz6aa.ffs@tglx> <87a5hnyox6.ffs@tglx> <8734nezz0g.ffs@tglx> <250f3ae6-3a81-40c7-a747-4713e8888510@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <250f3ae6-3a81-40c7-a747-4713e8888510@gmx.de> X-Rspamd-Queue-Id: 59EBD40006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ddbwy5f7yf6taxo7smss1jfenydcwb68 X-HE-Tag: 1725372804-269447 X-HE-Meta: U2FsdGVkX18j7XRbGxzPMFoFLU6IzQ/L9YVy3QK8zTnIhhWFiA4UWSQK/7k+Q1WkZJVtRGD49RizEHcvmU6lSYHnQX5nz7WfYuFH1BOPVJaNE8zN2+EYBd8nzI6Sa3BLTOFboiJVla2i3AcC3ZgZz3FhdT08wiK/BOKRuaZ4gCpnIIABnvQAJ190PZp+F+Sst6coUWeEv7drcoMVj8y38E+/F6BJnq6z6pABqoRIgLu2h2iaaCwehk16XXXGUwbPmtjkLxO39InveWTsZXXX/1ceseQSCImuVbnFujkYxdUsq5CMoZaEru7qhEfksc3qBBcJ7XlBEY0cHvn2B8Ta344emzHIF4OGy0mmvR+4O+lwxX/i5IR71+dP0sLeMZ/QCKHAQBZ5xfnhBiNv6h6BAljGur+G77Gf59XDMdxClDAtCIsobcYN4/mH72rQ2K2V8Igmb+0twhrzIroZPcxowHM558/tzIo4kBBlNcYjNOhoZyasaqyibC9IerK9I4iy1MjlCoSowRnwqW3I9HBOqg8QjsGfIXcQpT3bjUlcd9bu05FLkYzmZWRltnjA6ZtZL6qVgx3whPRgk9S7pDGeO8w9QGkkppf6ljUJaL3pJ+Byj78iZYVU1f7CcQmNXToST8wLZPN3kiOHCsKiJ3yYktgyzsyTKb1CTdnwIEo8gbHHvwcCSf9MCqwMrDhK5ktnCRdJSentORMXwDtouLpCbtKDiqKQpmRmEITN35kZ3c/JQd6BP8usVUWUyjJ+kb3p3/3ajWkaPUSeY18zPUongJXg4U8CM4DObRM2KOSmiUp3IJ9+ZxW/WCxP+KAyqXhzaqg6vZ3pgi2Zsq5pKCppYyQvZ0xCBkwcTWkXL4acRic5yc3YWVuKSrcC/rGibUFkqQs3oJxEE8LTuiDpCjHy9Uxv5Wq+NzGWo3btzuQga+C5Qcbvclt1k88KeVirjJNdOziDcEmJ//wVVJXG5zC EtIXdFWT +yB6VSSJ99AXLHjgikiW44g8HN65Hxb40JkkMd5E2pZ1SJTXtt9UgCp1UMqWnQhYBst7PYqRecejMCIrASBdGXUzYiOqt133Q68H1X14PMr83Au0iZ2jBwOod3W6GDJhF/A7CWHA9VUpVcm3wkPIbHdqGO22s0elcZ9XbdfajMaUDmt/64eeB9kSSkOB30Xghkkhc8ypRDxLebvx+F5r4YsyAdHJ95vRnRCP64HxQ/V1S1f2IvZO3Sht7LHQq8I0IIIwUc7Sr0UzinaXXXdNeYYotW46Akv58yK8pp7r1i4Jfkvua223Ch8M/ru+rFDtWFHVZpG/qU63L48qdhDjiNe503yTOwr5iQCguOVx6L/jIsZAAGM13OL8FAv4Yjg2H+zk1IOUoDOQqAqexP/J6bH41grjM6wv2fNpl8Kih6mTRNYrPYPK9IKyZKJF4pqppR+oWeLZXI+FPr9wlVqAn0bcvq5dbGy5gzXBTvm3+f17gaU0iglzQsKP9+zcx58NLAffapHZQ5UXR2EzAb0GEGJqKcw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 03, 2024 at 09:54:19AM +0200, Helge Deller wrote: > On 8/8/24 20:19, Linus Torvalds wrote: > > On Thu, 8 Aug 2024 at 10:48, Thomas Gleixner wrote: > > > > > > Here is the disassembly from my latest crashing debug kernel which > > > shifts it up a couple of pages. Add 0x10 or sub 0x20 to make it work. > > > > Looks like I was off by an instruction, it's the 28th divide-step (not > > 29) that does the page crosser: > > > > > 4121dffc: 0b 21 04 41 ds r1,r25,r1 > > > 4121e000: 0b bd 07 1d add,c ret1,ret1,ret1 > > > > but my parisc knowledge is not good enough to even guess at what could go wrong. > > > > And I have no actual reason to believe this has *anything* to do with > > an itlb miss, except for that whole "exact placement seems to matter, > > and it crosses a page boundary" detail. > > Well, you were on the right track :-) > > Guenters kernel from > http://server.roeck-us.net/qemu/parisc64-6.10.3/ > boots nicely on my physical C3700 machine, but crashes with Qemu. > > So, it's not some bug in the kernel ITLB miss handler or other > Linux kernel code. > > Instead it's a Qemu bug, which gets triggered by the page > boundary crossing of: > 41218ffc: 0b 21 04 41 ds r1,r25,r1 > 41219000: 0b bd 07 1d add,c ret1,ret1,ret1 > > During the ITLB miss, the carry bits and the PSW-V-bit > (from the divide step) are saved in the IPSW register and restored > upon irq return. > > During packaging the bits there is a qemu coding bug, where we missed > to handle the PSW-V-bit as 32-bit value even on a 64-bit CPU. > The (copy&pasted) patch below fixes the crash for me. > Yes, that works for me as well. Thanks a lot for the fix! Guenter > Helge > > diff --git a/target/hppa/helper.c b/target/hppa/helper.c > index b79ddd8184..d4b1a3cd5a 100644 > --- a/target/hppa/helper.c > +++ b/target/hppa/helper.c > @@ -53,7 +53,7 @@ target_ulong cpu_hppa_get_psw(CPUHPPAState *env) > } > > psw |= env->psw_n * PSW_N; > - psw |= (env->psw_v < 0) * PSW_V; > + psw |= ((env->psw_v >> 31) & 1) * PSW_V; > psw |= env->psw | env->psw_xb; > > return psw; >