From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D90CCFA13 for ; Thu, 26 Sep 2024 11:38:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9319D6B008A; Thu, 26 Sep 2024 07:38:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E11F6B008C; Thu, 26 Sep 2024 07:38:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75B496B0092; Thu, 26 Sep 2024 07:38:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 57FED6B008A for ; Thu, 26 Sep 2024 07:38:42 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0DCA11C7280 for ; Thu, 26 Sep 2024 11:38:42 +0000 (UTC) X-FDA: 82606692084.19.92C10BE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id A2C6F16001B for ; Thu, 26 Sep 2024 11:38:39 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Elc1IwfB; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727350599; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pTjCahG2AyWm4ZcFyWyzFLJtSNVwihw07EnaJAUIhZk=; b=EBLHzZke3nZgJkB6TiLgChxY5M67Ys8FtrME+dnQBseQfk9NJjtrxiO4l34KUAI5yUJNWK IdCnUiSD2mOIBnDj2+taGcsiA1qvVYctf0361+L5n9j0xOmi1I3LPTFyEp2a2rW2olr18A +dKBS7/wiJ6ay5sbo2dP75XP02OH8/k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727350599; a=rsa-sha256; cv=none; b=FzQxmT+s/TibUXGJ10eUAkQWx+vuRHT3Mumq0KtVo11cv2yuzukdnTdtOLsr0kKySum87l 6Vk0BBFeahV605HxR1UxXuKqli5Mif5f2/rf08a0D3ucLvmSeGNUxQRsWU78cocVr9eVPY t6aY0Z7C57/Bj9527h+RkyOIMdguS74= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Elc1IwfB; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727350718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pTjCahG2AyWm4ZcFyWyzFLJtSNVwihw07EnaJAUIhZk=; b=Elc1IwfBLQ1b9ZiKHQ7HHjXdIW58byV51RLIdfyzemjps0jZeD10pi+Yd3Z02B3+ZqsZ3G AmFzQgsP2X6K2P42ivsDLqsjnk5s2hPhZaHHmhJEVH8ywaXrJKOY5f00PzaTIEa3hCHwPq 5guPx3Nx5OZXRbYQHjEfEftVar/PFGk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-s67KmmWXMCyQhoG2MWEQjg-1; Thu, 26 Sep 2024 07:38:37 -0400 X-MC-Unique: s67KmmWXMCyQhoG2MWEQjg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42cbcf60722so6186445e9.1 for ; Thu, 26 Sep 2024 04:38:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727350716; x=1727955516; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pTjCahG2AyWm4ZcFyWyzFLJtSNVwihw07EnaJAUIhZk=; b=pCeEitrRzMV+9fJIgc9e+VA/P0JMj2WXgvYourqHpe4q4dDkvBkxzXRzcDaoyIl9/o pDt7velvISdhzpxeXfe803A47BcSaF7f+g0SqLiTEUIo7VVXuXheRyuXHtmxPF10wxnZ ZarBU5aKAJn7mFkAESZOkvO2sj6WqycnvBJARtCo0pMA0XFRl6C7JYNdoyXE6AbY8C5o Zrb8WCTqh7oAReqJWe532HkAjtsO5FEkh+ms8/V60pVsxFc7JZy9RoDk7FpVvCrxz9xy 3LBcddhZ88K/mPZnue0gSQYPYAnoD8cjGNcSQmE6XvTu5SLrgHSPK6rZFCYlPmI/aiq9 Av4w== X-Forwarded-Encrypted: i=1; AJvYcCW0xaZ3wQptxkN7dcDCRPp/LWM+W8OAEOTQ4jBZjJZx95eVChnTjpwJ01RYAZ7nQuxu9bbG+3cGcQ==@kvack.org X-Gm-Message-State: AOJu0YyENqjKeBxHIopEy3Fx74jHJav8P45x8hZ31p3k29nQV8eRwhpB QhlsCHZ4SRbMf6Ls5F7Jp17Efuo5DYE1UHRO80HYnfaOIYEaf2K4w8jsIeOyuNN05UD8nUNmnOB MD6udWK4gdaV8top4WNT1jt6E7cTPXuIv8utR/SQGMVmTPSx0 X-Received: by 2002:a05:600c:1c82:b0:42e:93af:61c5 with SMTP id 5b1f17b1804b1-42e9610de39mr46959975e9.14.1727350716520; Thu, 26 Sep 2024 04:38:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGx4Fh9q5EF8rlWaSwvCVtHUGDAyzV3eyPXxM4ooR4qW/NVfLGxfKRAe29C3CFlaSZSO9L1/g== X-Received: by 2002:a05:600c:1c82:b0:42e:93af:61c5 with SMTP id 5b1f17b1804b1-42e9610de39mr46959725e9.14.1727350716109; Thu, 26 Sep 2024 04:38:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c744:ac00:ef5c:b66d:1075:254a? (p200300cbc744ac00ef5cb66d1075254a.dip0.t-ipconnect.de. [2003:cb:c744:ac00:ef5c:b66d:1075:254a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e902560cfsm77226145e9.0.2024.09.26.04.38.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Sep 2024 04:38:35 -0700 (PDT) Message-ID: <0e8a9f2f-5c22-46a9-929a-f986c3f5e476@redhat.com> Date: Thu, 26 Sep 2024 13:38:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 1/9] mm/gup: repin_folio_unhugely To: Steven Sistare , linux-mm@kvack.org Cc: Jason Gunthorpe , Kevin Tian , Nicolin Chen , iommu@lists.linux.dev, Andrew Morton , Matthew Wilcox References: <1726319158-283074-1-git-send-email-steven.sistare@oracle.com> <1726319158-283074-2-git-send-email-steven.sistare@oracle.com> <6aea6530-9f9c-4a9c-9c9c-2c29e8ae9e9d@redhat.com> <98004c8e-f941-480e-b1be-8f6fd925871a@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A2C6F16001B X-Stat-Signature: 5c1h1891xmt9ubqpsg43338m9i79cisu X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727350719-850804 X-HE-Meta: U2FsdGVkX1+sthGWBZMaQoBfTVwMQSulA2Cp0up1+qwA8EnjwCoVKXUpPcZ7NiwiQfZ9suSAWdYms6RJAuaiNB9/dfwhq3xTmhS1zoXmKv3UrMscC7h9caKtjpepqoVOCasTIAZGaGUZu9ZeOSwfzqXqL59T2Y1qEAdg7FaZs+5o+xNSVY1zq6hYqZ3L+Oaq4qx9Re3y4kwAT0HtwEpl+XOJ99SXoS5QImJdpB8CWaYIlQUHgjO2E56sKEYXunXesyLkRs+m0cCO/rompXnGPfudbZ5UdoIZmZh2sVhApVYSvywU4Lv+oGdMGf4yaaCVAEDUmtJcYr0GLypiJphuhy0VxcfkU6bIKH568PHXSk0p1DfQL8T1rwMiQLGs7f6NSuRc8IBRXEcXtB+/hwhTJgPJrjQns2RuLk+fePDeTbspavb5xvzEM73TLDeKtm6CpmiN5hyY1Tc4tX+QLPw2v3RosCN2mZlxZ8dwPMLakwN70XdenuDYg3/5NosUEU1rpTQ7iNhC9xH73LPqq1cByQhACAdHby5ezGEiheJk179rAXdwC4cBKNqyxJw9X/LED6OzJrDu2ldC3GY1rSuWqTknPtCUbnqw7wmXOjLW4vU0ByeBh184P+ej/u3WFQ6obVAwbgnj2dumKYdxU2gblaZmuy4d3QjMTmvKVXt7H08pr/wrJyA03b/tWk14zDon1ObCsulteXTRQm5O3m8PFPOwQ2lDS1sGNWElzYnBzRvp771aBPoyFd1I77sL77AlyhFTo3Kvxbs7HCY3npc3xcGLw8LyHKBH/bC3JLgQzBhiIo5jM1lg9javtnN7xmXc32DtiO31rsQXy6Hdr70hAwRFYk/KDCmHxrENbyIIikWZKojpQ9lXU1TroWg346YlFFMzANrscFkrx2YooTFrnE4+msBS8luQwh+14DCP9YEB+r46lUC+FvX3nEZr0lWVEXhmRfyvStm9q3OeCeE /hJ8mALV JnbDt8LeEwotdLk8Oz2oWDW8RiF1ojcLDYw2bDOknrHppogR4+RDbnoC002/q1IF/krnp0P+aMchF62qvwOal4T551rooTNKFRLUduHlFj4NY4M7/0Kn8+VYRgBxiyIortP/tSuthsuMoqARIwrm+1fZWF+rql7rY7KFERj1N6K2lLHpuIubl3e8xFRm3WUxSNX78DvzzHPbaatAtFKBgnypvq1TZyjRyIZJijb+bxlXzyGr22wmLPmZaXqmK10k9N+zuU8RNhA9/Waqx9dyKr1uU7sCmQ3qYY284m++MFIb1aLSNwnDueerahXX4FjPR3QoZYT6YYDb0s9DweC0H/bimpe6ULOLCOvpkOTeiQWjz9AeCATwrQdLdNYMZuJG3UuwfpNoJ5DGZvFnoHclYpkqLGp67MiDP+F4mjF3h3/UXHQcEtxWVb+3YVUSIYoPL5Zz6kOilD6gFwocJE8qqlu6XOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>> reference fiddling is skipped. >> >> Please point me in mm/gup.c at that handling. >> >> IIRC is_zero_folio() does *not* include the huge zero page. >> >> Yes, we should likely be special-casing the huge zeropage in mm/gup.c, but it's not that easy because PINs can outlive MMs ... so *not* grabbing a reference could currently be harmful. >> >> But that has do be changed consistently, not with doing things here different compared to other gup.c functions. > Sorry for the late reply, conferences ... > folios_put() -> folios_put_refs() -> is_huge_zero_folio() unpin_user_folio() -> gup_put_folio() will do 1) atomic_sub(refs, &folio->_pincount); 2) folio_put_refs(folio, refs); What you cite above is for releasing huge folios that are mapped into user space. > > I will run some tests with huge zero folios to verify the ref and pin > counts behave correctly. Whatever is pinned is supposed to be released via the unpin interface. We have to be consistent there, so this patch would be wrong (likely you never get the huge zero folio). > >>>>>> +        return; >>>>>> +    atomic_add(npin - 1, &folio->_refcount); >>>>>> +    atomic_add(npin - 1, &folio->_pincount); >>>>>> +} >>>>>> +EXPORT_SYMBOL_GPL(repin_folio_unhugely); >>>> >>>> Can we ... find a better name? For example, it's "large" folio not "huge"... >>>> >>>> And repin is really misleading. We are simply adding more pins to an already pinned one ... >>> >>> Jason suggests a better name in the other thread. >> >> I would prefer something that simply adds more pins to an already pinned folio. Much easier to get. > > How about folio_add_pins()? Something like that, but more importantly, via which interface did we obtain the pins? That will make a difference and should be documented. -- Cheers, David / dhildenb