From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD8C7C48BC4 for ; Wed, 14 Feb 2024 08:53:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 195FF8D0012; Wed, 14 Feb 2024 03:53:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 144738D0001; Wed, 14 Feb 2024 03:53:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00C4B8D0012; Wed, 14 Feb 2024 03:53:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E2F898D0001 for ; Wed, 14 Feb 2024 03:53:48 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A2FD71202FA for ; Wed, 14 Feb 2024 08:53:48 +0000 (UTC) X-FDA: 81789796536.12.B7062EA Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf11.hostedemail.com (Postfix) with ESMTP id C37314000F for ; Wed, 14 Feb 2024 08:53:46 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707900827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yFpTOd2QHdKO6xQvgcX092+A8Er2NAMvf6A/VkOTOko=; b=CggCyi2/7zkV652C2ESHoF/oTDiTVdCq+M8BUGc9DqQljuH5b6SopPm9LOvDQpXIWQIY/u 0iYa/3xy9WQ/3JtdlvDqdkHBm4AnUv1aQ48sBX8CSSFIElDiigyU4oWX4eSapLHbKpEOu8 9x+B1jLSFaE7fBDTXnool7SdrpFkWEo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707900827; a=rsa-sha256; cv=none; b=YOyoKS60JFTZpGxTK0L4aNAV8uDHVqmWxQ+xqnL/BE9KTk4sN1vVnNfPhDFTbJw/AGIFWW gLDki/yTlxtUVUzY4ehVKAiaCw5gcTBjfGgK1WL8EjieHCKjI2fRTRQM8xKBVwjESEX2jR fsJL4xGke4aO4cjKFlikCZNt/JAdDs0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ADD3D1FB; Wed, 14 Feb 2024 00:54:26 -0800 (PST) Received: from [10.57.64.120] (unknown [10.57.64.120]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 99E953F766; Wed, 14 Feb 2024 00:53:44 -0800 (PST) Message-ID: <0e7606c6-9844-4b05-958f-458f9b5b6d34@arm.com> Date: Wed, 14 Feb 2024 08:53:43 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Don't needlessly use sudo to obtain root in run_vmtests.sh To: Mark Brown Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240209-kselftest-mm-check-deps-v1-1-19b09b151522@kernel.org> <17c0b7a1-6ec2-4504-8287-f0fa111b9748@arm.com> <9ff817f4-e999-4a95-b00d-6984a7ea6181@arm.com> <75fa3e12-8b0d-407b-b11f-333be70d157e@sirena.org.uk> Content-Language: en-GB From: Ryan Roberts In-Reply-To: <75fa3e12-8b0d-407b-b11f-333be70d157e@sirena.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 547xnxij5tsourfhgi4h37p6dtgn9prr X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C37314000F X-Rspam-User: X-HE-Tag: 1707900826-67732 X-HE-Meta: U2FsdGVkX18DTkzE1uEi0ZOn/Ko6uQjwnCFtJd1v+hkaJo6NhsS7lzgh9ImJtGuQtvJM4IgHDsmQPs5teBHxcpSXpUWEWEu7gi2ewYebaK2gTDBOObAtHByLi0UUu/sM7ROCxvJG+QAibJ1V9+wE3lEoVt6EkauiXl+LADZuuTecDgXnJyHJ72fiAE66Dh288lDDkbpuMiuX7R+DdnVc/XUhIjrYySTz1pcSH9qCcIavr/FfPq3zGfMqgA03X1xRneGPMUftnalOHaJahdNkkq2eUaG5NIH8LH2qqn0RTHBKQXWnWjGh3k8EHa6jx+1ULrm/O7lF2fx2B1AzXgFKYrpJXUubR+W16HWzkgH3apJp2wcSzxbz10AvxFH+KWrr/nyebZNRJGJHkPagSo5LqiiJQg+QCj+gt7pM+K8PqVEWRviBFzV1DtusIiUaFao3sNqYVzCuWKw1lZkJHxzDkBtNNXIuY9clAiNgv8EO9vjWaEu9al638xYkOB0tRQPGgxlT+dKUAXJCHNdc0KVylrB7anL8nkE0Odz+gcMos2VIZtzn8FtnUiOx+LI8WjO2Tqjr9Qy2RuKchPwRpHlJYlIah/6XPExCZVOLIwtmHDtMYpwidAFDDPxTecRQXRWPgHDoaYB0EPxYp7dpFUZCI5aU8w9IuaWCtTSKDV+ITXNkKoe+Bg5C/IvsfdQs9iIppYZwFowMjtzeKpoAwG+uTrY86PS1saM1ZBLVVV5zPtpDmpJacQmZWC7mHh8okVZe5KKjyizsiNKbW2bN1x53dBiweCkasK15R3BVcocq/ZM2MsqJs/O0IjMo9TcgtA4Um2hLE2G23H73WMnhs8Ff9LGRP9ONMDFbjrbp9WWAAKoengfJ8FfRXzLQassIq8wPbeYfzpcpils= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/02/2024 19:13, Mark Brown wrote: > On Mon, Feb 12, 2024 at 08:32:58AM +0000, Ryan Roberts wrote: >> On 10/02/2024 12:35, Mark Brown wrote: > >>> Ah, I was assuming that some of the suite ran usefully as non-root given >>> that the only point of that sudo was to acquire root. If the whole >>> thing needs to be root then we should instead have a check for root at >>> the top of run_vmtests.sh and just skip the whole thing if we aren't >>> root, but then I'm unclear why it's invoking sudo in the first place. > >> I can't speak for how others use the suite, but there are a bunch of setup >> operations in the script itself that require root (e.g. reserving huge pages). >> Some of the tests will work without root, I'm sure, but I'm not sure its hugely >> valuable. Personally, I'd vote for just doing a test for root at the top, as you >> suggest. > > The hugetlb tests appear to be checking for root while running... I'm > not super fussed either way myself, I don't really use these tests > myself except in a general "keeping an eye on CI" kind of way so I'd not > object if people wanted to just go for just requiring root for the whole > thing. My vote is to keep it simple and require root for the whole thing.