From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC41C77B7A for ; Tue, 13 Jun 2023 10:35:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8452B8E0006; Tue, 13 Jun 2023 06:35:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81B4E8E0003; Tue, 13 Jun 2023 06:35:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70A1D8E0006; Tue, 13 Jun 2023 06:35:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5D6928E0003 for ; Tue, 13 Jun 2023 06:35:59 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 25E3C14038F for ; Tue, 13 Jun 2023 10:35:59 +0000 (UTC) X-FDA: 80897369238.06.2CE6529 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 2D5AC20007 for ; Tue, 13 Jun 2023 10:35:56 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=eCbyTU2B; spf=pass (imf03.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686652557; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5ULsGDgsh3A33xML9rlk0LIxNs0CVSoLM/g79SGfu+E=; b=a3xniZo1xPTs78CUoo/567HfbgCaCxEgbg1EkaBgIOf707qHuydywj4dfalDlkXPUd5ZgY HX2879MuTwehYH65zgnz3cH7tpKY0fDR6N1Uetv8aQWVbAMOWWbKHQ49wGbpK+iW1vR/Ia FdLUEt/AcG4t5rHO5MA073txQ8K5024= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686652557; a=rsa-sha256; cv=none; b=LVP3pBJB5xiYaFLPmp82IFiNHNTE1XG6o4sxKHVW6PjcjOIDP0qbxBcTzXhj7a1OcfZ3nH rhGl4DWkQ5e6m3nPqvWspkm6RTqzuDmjRaRE+gMRFotPPVey6zs2881cOkYjqyI1kKhkFw yQy4DUrLEpsy7GYvQSd+/78BRogrEVo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=eCbyTU2B; spf=pass (imf03.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com Received: from [192.168.10.54] (unknown [119.155.33.163]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1F391660000E; Tue, 13 Jun 2023 11:35:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1686652555; bh=HbdSMphLp1/aGNarPBMTAmoMfCdZYDwXjyzqGZPOGtA=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=eCbyTU2BUbopMEp0/l014XJDWH7zLmxfwh6N+IuQqSPT8pAD5HNik18UCjw7Dsc7G /vqmj4fttKTO0BVCwJiqnn48/01nNX5aJ0czU9q13HY6d5YgAECt/27yeFOtmBpd5+ 1cpwi9XnJK3ImYUXPXD7oHwevazumaZiK+213l1QbvXH3obGgIQcOM8NZ+b6+7nVDX nRzqIZebJjG/SqbTFdtsx9sGMAlu6nQlFv73gbfOQKnr0k8dXPJ3QIrX4IWQdOrzEQ /Y962W7NI2pvyTejjNeSukWiaANvS0kljQtCv2nU/ewwoBDQK0Q3Wtevvf6mii2biX uqIW8Jt3z6Rcg== Message-ID: <0e6b318a-bbf8-3701-00af-1802c6347897@collabora.com> Date: Tue, 13 Jun 2023 15:35:44 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Cc: Muhammad Usama Anjum , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, Greg KH , kernel test robot , Peter Xu , David Hildenbrand , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WC?= =?UTF-8?Q?aw?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Mike Rapoport , Nadav Amit Subject: Re: [PATCH v12 2/5] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs Content-Language: en-US To: Vineet Gupta , linux-snps-arc@lists.infradead.org, Andrew Morton , Hugh Dickins , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Peter Xu , David Hildenbrand References: <20230406074005.1784728-3-usama.anjum@collabora.com> <202304061914.N1Hmx12N-lkp@intel.com> <9d8b5b8e-47c9-16dd-050a-45d917d73c07@collabora.com> From: Muhammad Usama Anjum In-Reply-To: <9d8b5b8e-47c9-16dd-050a-45d917d73c07@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2D5AC20007 X-Rspam-User: X-Stat-Signature: 4wf76jnh754u1utfmnzb869bf5kkwjqc X-Rspamd-Server: rspam03 X-HE-Tag: 1686652556-10170 X-HE-Meta: U2FsdGVkX19tj/lScZmL+c/97mUE+R03aSzc3guGYEFqIMjNDdWIz2Dk6avXMazZslobgaT9PD8ej2a9KRPKMlCbomgF+FXBVbVn9xAVBNxTQ5OknzSpJRUkeDsny1Adf0zpz44/shihqoxKXOyvEAzmSq9Wb5gndQRi+HUj6GgnFu3BDyS2DxAwDTDvQ+RWq9OxRAPZ6XvPZTLU9uiWgobx+san3FOrbnClM02LI4x5loyD0d+Tgsdy/IbZWoiOkqh1lE9CmHzEwTaFfqbgHXYtS2ycTRwo/s0NHvalMZIEnyi8zcWOtDIETWmuwEnxuh+/E6XxQUYARzmggwtnnEbYhZqT3+yWzVFwW5o3AT48cD8tsIPjryz4U9EnNGbZOHUfAboc8iXGzO/jtX206YAfaPEmD9RE7H5Tb7zszl8/k110s+UcgiFjpuOE1v6RkN//T/e0C6KL9hFDQfzF+chBuMNM/02gRlHFvCissireVYGBxSv0XEtqbt3r/NwzU1NbPSf7KF1IRXaNgdPikItIzrtXITwdxRLOB4AbV4hbgG6ZXu7eD3244EOnIp4Ewf6sdXuz/CT6psMP77N+gFJq2UVRCqDq+v2vU2RtptXUVltKIvapEiuljp9kSYPiMj++d68HE49IB6JVNu2KHXesReZnaZn9UiLD8rFMe1yybZZAWu4r8DCH4xTN98o/uy63Th2Ym0OmOHuWOdDmddrXXTG1ccFgsydYCR1wAkDgVMKO5AVe83oQgd++WvI862rbavfJv8C/ObGhUjOjHT/PIqeQJU2/s4K6PV4bQweUkGWDVbOHYBs/yr/kPW7PNSGdPIwDe6eqspT6b654BP1McwQzYiGkd/oJxO7rdBmr73R7WuHPBBvpJPq7moRvHHXVVL3sd7nYwq32F+OdRWesXva2cktUtEhrZxcSkkT1Jt5ehURsHXR0G3YBHSY4ur4OnhAtUMLUAAbx0h3 oemxDW2H 0xzF1sNp+1NUiOtyPVt91dVIOIeSr4SgYl5U6KPC6QkqnceyjyamLdrxzl81ZDM2iDTOiHtReXiXbpVR/csgfnLUocq9boE+KYzoD4qvdGBfNq9bWeD9Cit+UYG2Cnbb6sC2TQs7WWlCK+vSR0vNI64Al01w9Efqdx5UYfOVoXckO6QatLF7ChKXdehN4IM27xO4bUkbrQIEMYcc9BmgFWXCpqDVWgmv9QCx/xiRoo4b2ZNdjmWGdVBJEjCGqUW2EKkFATsuUE7F+XU4F52ZCkA5DtWBhYTABb2t8/os24JLzCYXNwIvdnBpLk69lrvA0ymwbk1Quvhtr9Kpsr1q1DnTiZnjxRA49P21/N0apIWjxtWommslKk0VamzPyutfuwVsrpqYVG7hYcoKLH06yQU75Pb3dNh7J/5Ptt27V2F3Lb2eVfiC3f/Uzm8/wz5J5iWBkmTj3pwUtnA0zC6/8Dmiv6Q5JwOPfpiED9m3Luwaq/j0DTF4Dz2wyajlFcgBXuWW23LOTYSXSy1AeG5P3DeJX+JEGU7V7tifJY3EZOnpa/jxrCXhiDURMX7A3ono4Gskt0Fj13WVdoVFiWTIS6Gr0lQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Vineet, It seems arc architecture supports CONFIG_TRANSPARENT_HUGEPAGE, but it doesn't define HPAGE_SIZE. It only defines PAGE_SIZE in include/uapi/asm/page.h? AFAIK HPAGE_SIZE must be defined when CONFIG_TRANSPARENT_HUGEPAGE is enabled. What can be the solution here for arc? Should I just compile out this code for arc architecture specifically? Thanks, Usama On 6/7/23 10:45 AM, Muhammad Usama Anjum wrote: > On 4/6/23 5:56 PM, Muhammad Usama Anjum wrote: >> On 4/6/23 4:40 PM, kernel test robot wrote: >>> Hi Muhammad, >>> >>> kernel test robot noticed the following build errors: >>> >>> [auto build test ERROR on akpm-mm/mm-everything] >>> [also build test ERROR on next-20230406] >>> [cannot apply to linus/master v6.3-rc5] >>> [If your patch is applied to the wrong git tree, kindly drop us a note. >>> And when submitting patch, we suggest to use '--base' as documented in >>> https://git-scm.com/docs/git-format-patch#_base_tree_information] >>> >>> url: https://github.com/intel-lab-lkp/linux/commits/Muhammad-Usama-Anjum/userfaultfd-UFFD_FEATURE_WP_ASYNC/20230406-154314 >>> base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything >>> patch link: https://lore.kernel.org/r/20230406074005.1784728-3-usama.anjum%40collabora.com >>> patch subject: [PATCH v12 2/5] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs >>> config: arc-randconfig-r023-20230405 (https://download.01.org/0day-ci/archive/20230406/202304061914.N1Hmx12N-lkp@intel.com/config) >>> compiler: arceb-elf-gcc (GCC) 12.1.0 >>> reproduce (this is a W=1 build): >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> # https://github.com/intel-lab-lkp/linux/commit/f13abb36f64c77913509da8ca157512d2fb9f031 >>> git remote add linux-review https://github.com/intel-lab-lkp/linux >>> git fetch --no-tags linux-review Muhammad-Usama-Anjum/userfaultfd-UFFD_FEATURE_WP_ASYNC/20230406-154314 >>> git checkout f13abb36f64c77913509da8ca157512d2fb9f031 >>> # save the config file >>> mkdir build_dir && cp config build_dir/.config >>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig >>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash fs/proc/ >>> >>> If you fix the issue, kindly add following tag where applicable >>> | Reported-by: kernel test robot >>> | Link: https://lore.kernel.org/oe-kbuild-all/202304061914.N1Hmx12N-lkp@intel.com/ >>> >>> All error/warnings (new ones prefixed by >>): >>> >>> fs/proc/task_mmu.c: In function 'pagemap_scan_pmd_entry': >>>>> fs/proc/task_mmu.c:1921:37: error: 'HPAGE_SIZE' undeclared (first use in this function); did you mean 'PAGE_SIZE'? >>> 1921 | ((end - start < HPAGE_SIZE) || >>> | ^~~~~~~~~~ >>> | PAGE_SIZE >> It seems arc architecture supports CONFIG_TRANSPARENT_HUGEPAGE, but it >> doesn't define HPAGE_SIZE. It only defines PAGE_SIZE in >> include/uapi/asm/page.h? AFAIK HPAGE_SIZE must be defined when >> CONFIG_TRANSPARENT_HUGEPAGE is enabled. What can be the solution here for arc? > I'm still looking for solution. Vineet do you have some thoughts? > >> >> The remaining build failures are because the wrong tree. I base my patches >> on latest next, while the bot has based patches on mm-everything. I guess >> today's next would have latest mm stuff, a rebase would make things correct >> or I'll shift to mm-everything. >> >> > -- BR, Muhammad Usama Anjum