From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.or,
linux-mm@kvack.org
Cc: rppt@kernel.org
Subject: Re: [PATCH] mm: numa,memblock: include <asm/numa.h> for 'numa_nodes_parsed'
Date: Wed, 14 Jan 2026 10:55:36 +0530 [thread overview]
Message-ID: <0e57c78a-d3e5-44bf-9930-8842e4f791b5@arm.com> (raw)
In-Reply-To: <20260108101539.229192-1-ben.dooks@codethink.co.uk>
On 08/01/26 3:45 PM, Ben Dooks wrote:
> The 'numa_nodes_parsed' is defined in <asm/numa.h> but this file
> is not included in mm/numa_memblks.c (build x86_64) so add this
> to the incldues to fix the following sparse warning:
>
> mm/numa_memblks.c:13:12: warning: symbol 'numa_nodes_parsed' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> mm/numa_memblks.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c
> index 5b009a9cd8b4..8f5735fda0a2 100644
> --- a/mm/numa_memblks.c
> +++ b/mm/numa_memblks.c
> @@ -7,6 +7,8 @@
> #include <linux/numa.h>
> #include <linux/numa_memblks.h>
>
> +#include <asm/numa.h>
> +
> int numa_distance_cnt;
> static u8 *numa_distance;
>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
prev parent reply other threads:[~2026-01-14 5:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 10:15 Ben Dooks
2026-01-08 18:52 ` Andrew Morton
2026-01-11 9:05 ` Mike Rapoport
2026-01-12 15:12 ` Ben Dooks
2026-01-14 5:25 ` Anshuman Khandual [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e57c78a-d3e5-44bf-9930-8842e4f791b5@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-kernel@vger.kernel.or \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox