From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f70.google.com (mail-pl0-f70.google.com [209.85.160.70]) by kanga.kvack.org (Postfix) with ESMTP id A72056B0003 for ; Tue, 13 Feb 2018 19:48:51 -0500 (EST) Received: by mail-pl0-f70.google.com with SMTP id w24so10070282plq.11 for ; Tue, 13 Feb 2018 16:48:51 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id g34-v6si2321676pld.513.2018.02.13.16.48.50 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Feb 2018 16:48:50 -0800 (PST) Subject: Re: [PATCH] headers: untangle kmemleak.h from mm.h References: <20180212072727.saupl35jvwex6hbe@gmail.com> From: Randy Dunlap Message-ID: <0e4fbe75-7757-6129-b937-1e849ad8946a@infradead.org> Date: Tue, 13 Feb 2018 16:48:44 -0800 MIME-Version: 1.0 In-Reply-To: <20180212072727.saupl35jvwex6hbe@gmail.com> Content-Type: multipart/mixed; boundary="------------F0B99163494C332BC7F40931" Content-Language: en-US Sender: owner-linux-mm@kvack.org List-ID: To: Ingo Molnar Cc: LKML , Linux MM , Andrew Morton , Fengguang Wu , iommu@lists.linux-foundation.org, linuxppc-dev@lists.ozlabs.org, linux-s390 , sparclinux@vger.kernel.org, X86 ML , "netdev@vger.kernel.org" , linux-wireless , virtualization@lists.linux-foundation.org, John Johansen , Greg Kroah-Hartman This is a multi-part message in MIME format. --------------F0B99163494C332BC7F40931 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02/11/2018 11:27 PM, Ingo Molnar wrote: > > * Randy Dunlap wrote: > >> From: Randy Dunlap >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove kmemleak.h >> from slab.h and add to any users of kmemleak_* >> that don't already #include it. >> Also remove from source files that do not use it. >> >> This is tested on i386 allmodconfig and x86_64 allmodconfig. It >> would be good to run it through the 0day bot for other $ARCHes. >> I have neither the horsepower nor the storage space for the other >> $ARCHes. >> >> [slab.h is the second most used header file after module.h; kernel.h >> is right there with slab.h. There could be some minor error in the >> counting due to some #includes having comments after them and I >> didn't combine all of those.] >> >> This is Lingchi patch #1 (death by a thousand cuts, applied to kernel >> header files). >> >> Signed-off-by: Randy Dunlap > > Nice find: > > Reviewed-by: Ingo Molnar > > I agree that it needs to go through 0-day to find any hidden dependencies we might > have grown due to this. Andrew, This patch has mostly survived both 0day and ozlabs multi-arch testing with 2 build errors being reported by both of them. I have posted patches for those separately. (and are attached here) other-patch-1: lkml.kernel.org/r/5664ced1-a0cd-7e4e-71b6-9c3a97d68927@infradead.org "lib/test_firmware: add header file to prevent build errors" other-patch-2: lkml.kernel.org/r/b3b7eebb-0e9f-f175-94a8-379c5ddcaa86@infradead.org "integrity/security: fix digsig.c build error" Will you see that these are merged or do you want me to repost them? thanks, -- ~Randy --------------F0B99163494C332BC7F40931 Content-Type: text/x-patch; name="integrity_security_digsig_add_header.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="integrity_security_digsig_add_header.patch" From: Randy Dunlap security/integrity/digsig.c has build errors on some $ARCH due to a missing header file, so add it. security/integrity/digsig.c:146:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] Reported-by: Michael Ellerman Signed-off-by: Randy Dunlap Cc: Mimi Zohar Cc: linux-integrity@vger.kernel.org Link: http://kisskb.ellerman.id.au/kisskb/head/13396/ --- security/integrity/digsig.c | 1 + 1 file changed, 1 insertion(+) --- lnx-416-rc1.orig/security/integrity/digsig.c +++ lnx-416-rc1/security/integrity/digsig.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include --------------F0B99163494C332BC7F40931 Content-Type: text/x-patch; name="lib_test_firmware_add_header_file.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="lib_test_firmware_add_header_file.patch" From: Randy Dunlap lib/test_firmware.c has build errors on some $ARCH due to a missing header file, so add it. lib/test_firmware.c:134:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] lib/test_firmware.c:620:25: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration] Reported-by: Michael Ellerman Signed-off-by: Randy Dunlap Cc: Wei Yongjun Cc: Luis R. Rodriguez Cc: Greg Kroah-Hartman Link: http://kisskb.ellerman.id.au/kisskb/head/13396/ --- lib/test_firmware.c | 1 + 1 file changed, 1 insertion(+) --- lnx-416-rc1.orig/lib/test_firmware.c +++ lnx-416-rc1/lib/test_firmware.c @@ -21,6 +21,7 @@ #include #include #include +#include #define TEST_FIRMWARE_NAME "test-firmware.bin" #define TEST_FIRMWARE_NUM_REQS 4 --------------F0B99163494C332BC7F40931-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org