On 02/11/2018 11:27 PM, Ingo Molnar wrote: > > * Randy Dunlap wrote: > >> From: Randy Dunlap >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove kmemleak.h >> from slab.h and add to any users of kmemleak_* >> that don't already #include it. >> Also remove from source files that do not use it. >> >> This is tested on i386 allmodconfig and x86_64 allmodconfig. It >> would be good to run it through the 0day bot for other $ARCHes. >> I have neither the horsepower nor the storage space for the other >> $ARCHes. >> >> [slab.h is the second most used header file after module.h; kernel.h >> is right there with slab.h. There could be some minor error in the >> counting due to some #includes having comments after them and I >> didn't combine all of those.] >> >> This is Lingchi patch #1 (death by a thousand cuts, applied to kernel >> header files). >> >> Signed-off-by: Randy Dunlap > > Nice find: > > Reviewed-by: Ingo Molnar > > I agree that it needs to go through 0-day to find any hidden dependencies we might > have grown due to this. Andrew, This patch has mostly survived both 0day and ozlabs multi-arch testing with 2 build errors being reported by both of them. I have posted patches for those separately. (and are attached here) other-patch-1: lkml.kernel.org/r/5664ced1-a0cd-7e4e-71b6-9c3a97d68927@infradead.org "lib/test_firmware: add header file to prevent build errors" other-patch-2: lkml.kernel.org/r/b3b7eebb-0e9f-f175-94a8-379c5ddcaa86@infradead.org "integrity/security: fix digsig.c build error" Will you see that these are merged or do you want me to repost them? thanks, -- ~Randy