From: David Hildenbrand <david@redhat.com>
To: Liu Ye <liuyerd@163.com>,
hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev,
shakeel.butt@linux.dev, muchun.song@linux.dev
Cc: akpm@linux-foundation.org, willy@infradead.org,
svetly.todorov@memverge.com, vbabka@suse.cz,
ran.xiaokai@zte.com.cn, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, Liu Ye <liuye@kylinos.cn>
Subject: Re: [PATCH v4] fs/proc/page: Refactoring to reduce code duplication.
Date: Tue, 18 Mar 2025 09:44:03 +0100 [thread overview]
Message-ID: <0e48e415-b5db-4555-b73b-d2a032752bfd@redhat.com> (raw)
In-Reply-To: <20250318063226.223284-1-liuyerd@163.com>
On 18.03.25 07:32, Liu Ye wrote:
> From: Liu Ye <liuye@kylinos.cn>
>
> The function kpageflags_read and kpagecgroup_read is quite similar
> to kpagecount_read. Consider refactoring common code into a helper
> function to reduce code duplication.
>
> Signed-off-by: Liu Ye <liuye@kylinos.cn>
>
> ---
> V4 : Update code remake patch.
> V3 : Add a stub for page_cgroup_ino and remove the #ifdef CONFIG_MEMCG.
> V2 : Use an enumeration to indicate the operation to be performed
> to avoid passing functions.
> ---
Acked-by: David Hildenbrand <david@redhat.com>
Thanks!
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-03-18 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 6:32 Liu Ye
2025-03-18 8:44 ` David Hildenbrand [this message]
2025-03-24 3:25 ` Liu Ye
2025-03-24 11:55 ` David Hildenbrand
2025-04-07 1:39 ` Liu Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e48e415-b5db-4555-b73b-d2a032752bfd@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuye@kylinos.cn \
--cc=liuyerd@163.com \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=ran.xiaokai@zte.com.cn \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=svetly.todorov@memverge.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox