From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3992CD4F5B for ; Thu, 5 Sep 2024 08:10:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 351496B00E5; Thu, 5 Sep 2024 04:10:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 300496B00EA; Thu, 5 Sep 2024 04:10:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17A656B00E8; Thu, 5 Sep 2024 04:10:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EA3076B011D for ; Thu, 5 Sep 2024 04:10:15 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A0E78A7FD6 for ; Thu, 5 Sep 2024 08:10:15 +0000 (UTC) X-FDA: 82529961990.11.0CA4CAE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 5EBAAA0034 for ; Thu, 5 Sep 2024 08:10:13 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SkD4kSGZ; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725523736; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ShSslKXCzrzm4PV/rKrXG0jztbgFCgc6Rzgg0DG9CU4=; b=SGeyjm+Czqy+77MzEIjh7cBUeZbJ5sns+03aFVX8FJPO48JKdUKdMTgvSxZy73KenQ3lVA eDqux6+RhiMh0MOAKggK0YaLaQZNtrpHMTd4xw4LBOjV8l83IF5CDlZ+xSfONYxyt0BQUV doAYgw6QItgJgiDYDpf069hEL/+W23o= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SkD4kSGZ; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725523736; a=rsa-sha256; cv=none; b=OT0BD8F0STKpX/QSXmdDWmRbtw8xgNH+0Ia38kUzTTd1U8OTdMDKh3rJQEOMzWr7kEVWAE Jl4n2uGun2zrxSt0S5BK8LsZxsYHMiIoeEKxOK1oRqlZ+EXKarxoYa0HRmJ1rRYnVmU/zg 4AGlpOGIGRgUrdkPrCAP5fj84Kvk39c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725523812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ShSslKXCzrzm4PV/rKrXG0jztbgFCgc6Rzgg0DG9CU4=; b=SkD4kSGZU+zYekqKMOnaf3/x+dFyT1GyOK7pP98QmBnI57YQ3C3h7SrxvJ//T0dHiqblF3 OXWLoYcORu4US0vE7Tb/MTFw0xok1HupsS+Do1SeQgA8XjPck6psX37mdlz5WoqJDOMtUI bWP7DbCYEVxQencNyRv/KKOJ4tD1UIQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-uPE432JLOla9h-o2urHalg-1; Thu, 05 Sep 2024 04:10:09 -0400 X-MC-Unique: uPE432JLOla9h-o2urHalg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42bb6f0f35cso3901655e9.0 for ; Thu, 05 Sep 2024 01:10:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725523808; x=1726128608; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ShSslKXCzrzm4PV/rKrXG0jztbgFCgc6Rzgg0DG9CU4=; b=TZ6SDFhZcsOI7X+wlh4XzwfFlnlXV2kRMnzTKHNbj7NIrYCyzEjuyBGhljtN7U5y4M YcvX+NfRxYGTHPuQRx61ABSZNmNBTTa1T06+9zG/DOe2VNZU2me/TP/hZXIjZA3Mi/CV hBfjo2+lplOSwhiszN+7BHIaF7ZdUwmB0W3b5lZYis/ai4q7p+AUvE8C3Y2EJj/0Srd3 qJnZBPcshbSwu4fKFaqWpeaK6zOgJ88z6f1SJ1FZjYi3CJWPmwt0dvSrFP72/KYe7C+X SwgYIAePMBMZ715Y7abmF6gflBtOFVCV06B3HBERx5u8X5c7HwG3cA3Zi6Mjja6MwxFT UULQ== X-Forwarded-Encrypted: i=1; AJvYcCXz46O1ogEgz7TRneIf4ONXebK8G0xyTO4NsI6i3HDqQu045ZWwYoEICEkmccyezEJP4C0/Cr5Dig==@kvack.org X-Gm-Message-State: AOJu0Yzkb39Lm1O1QKgN+sX2OFrJdMtBn1oiI/bXELBN1b5QIVJ7eCnS bR2ZXR8TNZFVvmG6Dr1YxyNppxZRBDycJJ/iuLYbYX82hfl92BU85VloyguD0ZN4kN6ea8EvhpS rCaFrxnU2kHx9u4GRIXXIDkwiwoNBAt54j+td54TGatMfgU2Y X-Received: by 2002:a5d:49cb:0:b0:374:bb2b:e7c4 with SMTP id ffacd0b85a97d-374bb2be8a5mr9629602f8f.57.1725523808218; Thu, 05 Sep 2024 01:10:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFe2Qg9TkaXeyy4xBRgaD1gUvnm50duQvpkv3Dzqcu0iT6BYmU+3xEYX0H4um34i5/KqImpUw== X-Received: by 2002:a5d:49cb:0:b0:374:bb2b:e7c4 with SMTP id ffacd0b85a97d-374bb2be8a5mr9629563f8f.57.1725523807208; Thu, 05 Sep 2024 01:10:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:5400:6c12:d0e2:3757:2963? (p200300cbc70854006c12d0e237572963.dip0.t-ipconnect.de. [2003:cb:c708:5400:6c12:d0e2:3757:2963]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749ef812cbsm18793282f8f.83.2024.09.05.01.10.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2024 01:10:06 -0700 (PDT) Message-ID: <0e375929-9765-4c30-84a2-b5e016f51bdd@redhat.com> Date: Thu, 5 Sep 2024 10:10:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC] mm: arm64: advance pte for contpte_ptep_set_access_flags To: Ryan Roberts , Barry Song <21cnbao@gmail.com> Cc: Will Deacon , akpm@linux-foundation.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, Barry Song , Ard Biesheuvel , John Hubbard , Mark Rutland , Catalin Marinas References: <20240831083537.62111-1-21cnbao@gmail.com> <20240904151304.GB13919@willie-the-truck> <629ee1a6-c606-4a8d-bfd6-a2be31feddcf@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: c78mf1wd9mh3rmpen1adotw4yefbbiwz X-Rspam-User: X-Rspamd-Queue-Id: 5EBAAA0034 X-Rspamd-Server: rspam02 X-HE-Tag: 1725523813-6644 X-HE-Meta: U2FsdGVkX19t/FYU+F7b5wf5MTyGPvCuM/gR66zDRovCx3hWP+YsBFXhJD+6vb3AjYKYhpTTDh3V6BHnayFtHNVyBMoT0YUg1uTqTYzHilqhSzDYIhadRuzUFr4OfRgW9vI4hdjAQipvwLhC+4kvZoXlCuDU5GktN15ZuzdhlCMwhHAYUUrAb2T4g9LJN6Kvt7of3SykVBCNmUQBmMs81Yt3y4DxqXCX8J36DIH3gPTbCEqGj7Tb5m3SLqppKMeiZ/v6xWOwdkfIoniyjWNbcZjGYKrUF0XQNERmNkKNs3Neeg3MYfmAcVT6hdaTfQwyfwFjp8Al0eTS2Nw2OjaFB3nzryyk+LNaA0bu5Q75uWfoS15PoK8MhdvqUhW72JTwQ/p1XyxMylRVR4Ebreg3/TVzfXoiiUnvsd1juWZmKml6HP1yETod++0IkuNi6MLSvu7iylP33phcsgYb2Vufk60Fc0B7QuP+itCW/4JLVgrZMySBuANGlfif1hLyg7mHMaLX+VaQW9phhbmF/3rvf9JSYwa12fGR1kZrLBmMsHxgS4HrM86wKxZT9Y0YVLY3e0SktvgExPiz5okaoGZRfYgx36SF26+EtMSVpRKZowTYDXAvUv3h+ya4RwCqWFsaNieCaWQ8FRTWwHyuMVchXtdi29Zz5HbUJkmGX/3iZgsLr51aFa+8Lb0tqvoo/UDlQvSdxMEtIcjsprk4J6aMPAd80Rhz0yq9ykC/tsdp5ZgjlHVbAly2Q4EFvkf5bN/UFHErs20B1Z7Sx3w3nVNq8cZk8GRVo44LZxtZqrMaZKl2Px/20VZJfKdynGIjFyJmRZADFebhMMmItndOv9j3CdbKehlm7N1m8UuLvwwqVvw1CJMrRIP6Fvnv77AiOh6YaIa/MElgkeezWLRo+GmmSF/DpvV37OPcqCxuY7uHWjiH2SdVNnndkbwQIvgp6jarW8na2rey1BF/QYSNo5G R8JiUTTx 3xnRvm8Fe7pbyybJoO7gnTuX4oLjDbF1C2ca+NdSbi95X/ssDG57tvkPZLrfnVFUKEnq5KV0m53zWA/YQ8pINeOklpVv3vAABjmVx37ROzeBgFRyQL7iYdoWzStdU6TlvS+9SJs1L6P348aWRltREhimfxcs7yu2ShlTYuqOt4zOHOB/1qAzT1gyXBBoseullUeWC13862nqhT1YkmyJveIQaAFyQ7RgPiodC2uRVhfdxGPUWbqRGk2jtDDjXViOlE2LENrv02n0epxBDALBDqoyfK65cu2V/B0Q8DeOx4F0sG0wha0Po+UdEisEaIipXEM7RKllwxsJs5wA04joM142csrBMdPa0vkIEYjBRajRX1kxuQx6+jzUJrZGFGUEOfOP7aa515Q4rDSVvMLaE7xyZA6OH8/eqQ51fVy5FyCB8cpphkM2H4gpXMnvbustr207p8EpOrrA5b/qPWOCx/wzOcsTtuz8HKMgfa6xXt9DBAs4pZQIt0J07n7lP7bUzYeMjws9iq/lWqhjCdkTPVvCzQbtmyL6ICZQuhegcu2WyFzw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.09.24 09:20, Ryan Roberts wrote: > On 05/09/2024 04:27, Barry Song wrote: >> On Thu, Sep 5, 2024 at 3:50 AM Ryan Roberts wrote: >>> >>> On 04/09/2024 16:13, Will Deacon wrote: >>>> (Adding Ryan, since you're asking him a question!) >>> >>> Thanks, Will! >>> >>> Afraid I don't do a good job of monitoring the list; I'm guessing there are >>> automated ways to filter for mentions of my name so I catch this sort of thing >>> in future? >> >> It's not your fault. I just realized that, for some unknown reason, I forgot to >> CC you. > > No worries. I was just asking if there is a general approach that people take to > monitor mail that they are not explicitly cc'ed on, but I guess that's a bit off > topic. I do something slightly different: I filter mails based on keywords. For example, whenever a patch contains page_mapcount(), folio_mapcount(), folio_mapped(), ... it gets put into a separate "mapcount" folder :) Same regarding file names. For you, it would probably make sense to filter for contpte or sth like that :) [...] >>> >>> The code is correct and working as intended, AFAICT. But I accept that this is >>> not exactly obvious. I'd be happy to Rb your proposed change if you feel it >>> clarifies things. >> >> If this is the case, I'd rather add some comments instead in v2? >> >> diff --git a/arch/arm64/mm/contpte.c b/arch/arm64/mm/contpte.c >> index a3edced29ac1..55107d27d3f8 100644 >> --- a/arch/arm64/mm/contpte.c >> +++ b/arch/arm64/mm/contpte.c >> @@ -421,6 +421,12 @@ int contpte_ptep_set_access_flags(struct >> vm_area_struct *vma, >> ptep = contpte_align_down(ptep); >> start_addr = addr = ALIGN_DOWN(addr, CONT_PTE_SIZE); >> >> + /* >> + * We are not advancing entry because __ptep_set_access_flags() >> + * only consumes access flags from entry. And since we >> have checked >> + * for the whole contpte block and returned early, pte_same() >> + * within __ptep_set_access_flags() is likely false. >> + */ >> for (i = 0; i < CONT_PTES; i++, ptep++, addr += PAGE_SIZE) >> __ptep_set_access_flags(vma, addr, ptep, entry, 0); > > LGTM: > > Reviewed-by: Ryan Roberts > Acked-by: David Hildenbrand -- Cheers, David / dhildenb