From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0D2EC8303D for ; Fri, 4 Jul 2025 12:29:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4090F6B8042; Fri, 4 Jul 2025 08:29:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A09C6B803F; Fri, 4 Jul 2025 08:29:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 233516B8042; Fri, 4 Jul 2025 08:29:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0B8F96B803F for ; Fri, 4 Jul 2025 08:29:38 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C35601267D1 for ; Fri, 4 Jul 2025 12:29:37 +0000 (UTC) X-FDA: 83626513194.30.FB634B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 4581BC0010 for ; Fri, 4 Jul 2025 12:29:35 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PZgfAsbw; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751632175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nMfOzscqPrNeO+wtav6AyTkJRAUgHSVpqHt0DNresKQ=; b=lfJZpe79Z0/sHB2hwW5RGU+O2Mh0icTfi86/Lty+YbH1puc+tTObHsGQf477oB2q3wIFvB TsSd+dlzglm+F9m9o3EMQNESDqBqCXj0zkoljR80H2bu+4ZK5s+JYsmYce/W38l0rTcHGo KdMeCX1BdxrAuYFin41Kel5j0vjofPw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751632175; a=rsa-sha256; cv=none; b=FF365Fue8MJdhtWTxF0dvI9e5r01TMQR66TrmcKLTyHUyb+YyOTg37TI0QEpNi8rqArevV maa7JT+3o3Oizk96OhHkI51Iw1FM33NycvPBYVnk+K1HlLF90draq6ZtEyulymOSulf2b/ qEvRaAexekylWJVk2px8t3yrMAPbwJ8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PZgfAsbw; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751632169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nMfOzscqPrNeO+wtav6AyTkJRAUgHSVpqHt0DNresKQ=; b=PZgfAsbwjaDmPPT1WMFkBcqoJ1KVQ2mDPEAb4v2OlfcMwXbDZ3+LxMHYpfyuEk6tn3TRFC ZeMmz0LAghY27AKE43SFnu07IqxEmtfK2pmHoZMvF8pAZIVgK/UOmE8avtrSrA6kD2tAh9 1toVnzUFuHDTY7tJHmtJdhs91QJb5+U= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-671-hnhEZ7xyNMOFx7WN0FAPWw-1; Fri, 04 Jul 2025 08:29:28 -0400 X-MC-Unique: hnhEZ7xyNMOFx7WN0FAPWw-1 X-Mimecast-MFC-AGG-ID: hnhEZ7xyNMOFx7WN0FAPWw_1751632167 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3b39cc43f15so504555f8f.2 for ; Fri, 04 Jul 2025 05:29:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751632167; x=1752236967; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=nMfOzscqPrNeO+wtav6AyTkJRAUgHSVpqHt0DNresKQ=; b=Vc7Cd3jO9ksObd2bzCccuXLDtaKJvEdRD8sdUyBoCNxaawKJ62ahK4XUPnzkGBjC4q inuDYdUK1+rH/12C3b00dAeFhnWSWqMFdPYwXC9ZQ0zyOJRSJlVd3rUhbEL4yBFILB8M /tAI5oCcW34Zj7AAqKgLdatu1nvez0zUfUgaIeiRKydjCb4/LT8uag00e4KXZLSVTarn hJlrJGZC1kwjWL+IU5CfAU/Ng7B4vgBtTq7oVmJALJt0Cft4ET/POg/GFbXzmBznoYFv Ju+7vfMUYSn1jW3YX8Oy7VQoNMZJEgJQWOmINrv7DXXr+qWjCMzakihYXBawWOAun0KY ftZQ== X-Forwarded-Encrypted: i=1; AJvYcCUc1xuM8YmkYZdrwZCXQxsRVTXneTbn2SxKbj/1o1Cz64ZJPvh5WNZlZrYbtU8nR510uVrFysw1Xg==@kvack.org X-Gm-Message-State: AOJu0YxJXAwQVEW70ScoW7oY6uvMYPPWYqWpeeOliP9P3G6CXBDmH0Fg OLN2qkOaqsqXQdB2sY2YAttmf/IOd0ZchhPPO77Un5z8VTBRNSHGP8PkBb8/R2LbLcnVAPBW/E4 HhwEdDXkuHK9KWsGMLjD1ZF8jverBQw895XEHr6y7CjbENtnRXZqw X-Gm-Gg: ASbGncsizkibZ8i7JdkNoD9E6JTjrVknlQA1Q01hZGs1QQvUR8wSw4+y7ThOQ1paniQ OJiPbCpQtfO/lsJTCLi4apVReREDowXG6wPb0Y6vmt5kVkk7c5ujpNRTIPEQlt6oMNm8abH5V3i 2uQom9Eupg6kv89qcrejHdDErgFuKGZD33qFAPNh+5+chZBndjGwdZ+BP6BOysliSPb4Acl+7S3 P6ACo7h0jI9OXNwG8FFYHaMU7cdVbtOlPH4KpCAjRBV59w8XX5lwXQ2x3qF0TYSOQfVWBBe4u2v 3213ktfRcIQ2VQsQvlhdVgeEL3ECJVC2rKxgjkDafVmx7AEwkL8TsHYecLvt/AogC46SVpjWd24 2HhZr4wwzmpX7o0oi5VXDqMmFI3nrNCF//C56c8L+7DxsZco= X-Received: by 2002:adf:b350:0:b0:3a5:51a3:2ef5 with SMTP id ffacd0b85a97d-3b496627048mr1392763f8f.58.1751632166508; Fri, 04 Jul 2025 05:29:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqBeqY6SkUrcobkDtTYO7nmm0Jh5I1+0Jk87TY5Y0gDytQOExUortOgjmHcTphF5n1W0izoQ== X-Received: by 2002:adf:b350:0:b0:3a5:51a3:2ef5 with SMTP id ffacd0b85a97d-3b496627048mr1392737f8f.58.1751632166104; Fri, 04 Jul 2025 05:29:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:5500:988:23f9:faa0:7232? (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b470f871casm2381833f8f.45.2025.07.04.05.29.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 05:29:25 -0700 (PDT) Message-ID: <0e36647a-414a-4f53-9159-1ae3ac836d11@redhat.com> Date: Fri, 4 Jul 2025 14:29:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drivers/base/node: Handle error properly in register_one_node() To: Donet Tom , Oscar Salvador Cc: Andrew Morton , Zi Yan , Greg Kroah-Hartman , Ritesh Harjani , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Danilo Krummrich , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , KAMEZAWA Hiroyuki References: <20250702112856.295176-1-donettom@linux.ibm.com> <83012fcc-36ca-41fe-8e2e-949f1ba8adf3@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <83012fcc-36ca-41fe-8e2e-949f1ba8adf3@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: loQjWk7XFiwCTmN-eE9ML434iFD_NBr-mjP3ac3G7vQ_1751632167 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4581BC0010 X-Stat-Signature: uo1q8cjady7sy34be4c766g6krenseem X-HE-Tag: 1751632175-476516 X-HE-Meta: U2FsdGVkX190Qd0QmStaG/cFRMF1raZs7cAiR8+pcfuOxbzVuhHWvtEVkJxGaMqsyfB7A7LdoJ9BUJUwdx7/eAlRBuMg8arpBHoNx4poAvpsGuTP//9DXfiwGpKSmedzptH2WKB6QVekKUD5Qy9UUDkdH3Q8UAcqdKrqu7OFyRtFn7vvb/ODc5RBRBlCunvvRHlJ6DtOqMaz5uciHIxsNS8iFo4J9BgNeFJDNQ7qzCTNRWE+jIw8/HaiRkqU3cRUiwmtabObCM6SXUy1jgb34NTV+ee9Z29rxMQD84PV/g5rB0ASAT0mx6U0I2n3owclVpp4PYFyN7Eqvi+tVXKTfDDtr+Y9/TNDNX0SdKoSW+sJP+RTHPLaeKSfT/y685BMgDyBAzsl36/+VMKdyJJIQ4QoVisFzNN5eyIFhVIYoP0P+1+UHTpSATaBzuYGNRvBZBMFuoRfCe5bo/zctD5AvBzdp6XMIPKg10TsSvdbU9j1OrcFA37sa7CsO3cYF3MWLPoV2rCNcy+yHX+6mZik62q5eUC4s53Fbznm21z6+TD9JTgU9wkE2xa4pPIGtGaVSDr6fTGcBEKZsSybMrVA0EEEWJSUFbkOuggOeEI4AqUALv0vWxNPVKKxCTLgqFFJ5UMsZr8KxBQgFHGRyVagIlfH4pWP6tFJxzjKWrOvTlzpWrFTK9n1k/BPXbY+Qp60vg9p9RMZHdN2juE/F28wPQzt/pSdDLh8rpgj5gPPqbWKJMluucSrSCcRO3RjSgkgcY+8sm5P0W9vW6XEHbiDAQyS1DqK0EhSIPAO3DsOL2pI+qjrDIUtCRVPqWjG+emtolOSAuI4L8oKLsQKjB69vnyitGwANDFrrSkMBiILiKxot0VYdqjWx0oBOe8vGFI0w0Hx9UDMUq67odCh41865od3higDQuXG9rhSrR75QcnKchz106dA89+9mycLDAaNUTawb2v1kORVdzxI4fh k1Pq57tV dGG9r8maNC2iLb/0i5tNoJ/NtnasiWlDyKAmJxrwdhqgBB0Rndckicf2TM75tOwJFo1PlrZDb6XtS0Ulypq0cLSnQc1rOx2Jg5BgzhBN2hbQo413K6jzvLK6top1cwGnxeXZHYPFwlRj7zpL1Q/T3Fcn4mgh1O72/H3jRcl8ad/8Zd7KbkY/AQQECSygZy4K1jpP2nMnQSNSgrYDgkaTxU2KYb3YVOkYFYu4bkJ23yK4bSOQRrZu+IE+6e6DpBlndfAVFZvHLonil5uiYLstDYYF7ikvJ6nKyr4CPhFwBWUSdf7x7iaBoOVlW8iUPN5qSy5pNvj+91c4QJHDsq3kuhTAgO4JLlVXf79dc1bkZGNpKlHXuOrgiZtwf+xzMo/rarTg1O28xnL6IZ3D4P3pTH/MLFFZlowozPvlycjwTY1oLxaUoGejq1efd2YkUtePg7iAecl/ZEmHnSp3R9wVyboY0lAJXsoAuebEmlcRju6J7PKASFoSZzHIK3PKD4HBnWoMo9IelfrYgHhwVyiSWNK7TC0SSmx6GoHSfJFY89nIYfAWifCZosLP3Vy3q0iR5zjRiCU1nerrmD1juNK9NjhdNX9rGcPKbk7xQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 14:59, Donet Tom wrote: > > On 7/2/25 6:16 PM, Oscar Salvador wrote: >> On Wed, Jul 02, 2025 at 06:28:56AM -0500, Donet Tom wrote: >>> If register_node() returns an error, it is not handled correctly. >>> The function will proceed further and try to register CPUs under the >>> node, which is not correct. >>> >>> So, in this patch, if register_node() returns an error, we return >>> immediately from the function. >>> >>> Signed-off-by: Donet Tom >>> --- >>> >> ... >>> diff --git a/drivers/base/node.c b/drivers/base/node.c >>> index bef84f01712f..aec991b4c0b2 100644 >>> --- a/drivers/base/node.c >>> +++ b/drivers/base/node.c >>> @@ -885,6 +885,8 @@ int register_one_node(int nid) >>> node_devices[nid] = node; >>> >>> error = register_node(node_devices[nid], nid); >>> + if (error) >>> + return error; >> Ok, all current callers (based on mm-unstable) panic or BUG() if this fails, >> but powerpc, in init_phb_dynamic(), which keeps on going. >> Unless it panics somewhere down the road as well. >> >> So I think we need to: >> >> node_devices[nid] = NULL >> kfree(node) >> >> ? > > > Yes, I will add this too. > > But one question: if register_node() fails, is it okay to continue, or > should we panic? > > What is the correct way to handle this? panic() or BUG() is not the answer :) Try to recover ... -- Cheers, David / dhildenb