From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 582E5C7EE23 for ; Wed, 31 May 2023 14:13:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E51718E0009; Wed, 31 May 2023 10:13:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E02178E0001; Wed, 31 May 2023 10:13:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF0B98E0009; Wed, 31 May 2023 10:13:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BF15C8E0001 for ; Wed, 31 May 2023 10:13:09 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8D34C1401CA for ; Wed, 31 May 2023 14:13:09 +0000 (UTC) X-FDA: 80850742098.29.99627B4 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf04.hostedemail.com (Postfix) with ESMTP id 62B254001E for ; Wed, 31 May 2023 14:13:06 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=n83+i8eM; spf=pass (imf04.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685542386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NXtfwCo398mNssja20yM7iI6aJ4z57XXGeGmgzDUvNw=; b=UoNPgZmRrA/geXCc0J2hZgsOZNoPBADyymTjajpBxBBDq8fXuhCdqK5Cd067CxbiPdSlGM nCbtXT+ocXHyxwKMqZNsI6vCCiCkI42LRBuhUeOLByKY7HWUTdxrLDp4w+0YNHavFNpQ5a csJsiXnrrrQ4V4ilyxKsMRsJu2nvNGw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685542386; a=rsa-sha256; cv=none; b=f5YTTZyPXIa39tbAL+xoIXNRCI4bUUytyfSXWLDX/+QbgATYy4Ep/4/Y1H4E1sjO1sYyqn jfvx16qw4R4bXcWTZ3Snj0naz3guINFBWmiYUGMwbmtANbPTMQy3lvg2vU4gq5NnLVwuHb LDIQ+wfJsxhicUF6tCq73VqJ0pcRMEw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=n83+i8eM; spf=pass (imf04.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-3f6cbdf16d2so43248235e9.2 for ; Wed, 31 May 2023 07:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685542385; x=1688134385; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NXtfwCo398mNssja20yM7iI6aJ4z57XXGeGmgzDUvNw=; b=n83+i8eMwzD3kMQ/bOt8MUs50SBqqTJsdCejDBgqUeHkdZGxkr9lzs1RzZvqfh4VOg 41IbkrcZobs2SmPtO/ik1OGA1Bbf9m9omBPizRY1kqn+yP7GGOAVwlzGP73ep1WpzL9f 9FnRiwY6dRMBx3uLp0TGTtyQA4GGn6tc/6nOa/N4mO3aS0Sx70Hr9nD2dxXTd16Q19nw qPEmd7A7mdZglKoQWfh6NcJXfSt0wK2oIsvyoly9xhJd9pigGJq4KdQHBsmeU7mrYbln OPXrHY/tptYvQKh0ARk95ILnsfslZ7pT97oVhFibaFa2v3DqoItnNt80zLqgaqyDZdUj wRmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685542385; x=1688134385; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NXtfwCo398mNssja20yM7iI6aJ4z57XXGeGmgzDUvNw=; b=IkEuYBf4/4/k1d3R9MD46kk74H0DQlLgBjz8NwSSzaznlST3LsZXDwX2sVYEMq0KXZ h4Vh9u8o9fdDsqrV6N+R0Hbx4QCEYhQXi+YsLg7D05Nsvmuovzl//+2+yQeXQDO3W40q u1Ct2aW8i1mrpcHJqXtM2+GBor/PoZSN6ZgK59nXWUEW0LMFT2HMwzb90gKhuNckoBTw FqNzp46GMjYY2/VA3rtbnPyumeQJkMlJixp4ta/8ERFoY3YKjqTOAQLTFW1iMb7ZVjc0 VcVgeGWP6nu9gZsPmWr66GcQN4szbSiw1u46zGjtgQ/8a9RKND1eBNfThZ3fcBH7iMk+ 48QQ== X-Gm-Message-State: AC+VfDzpe7qcNOXjritHVga1T1kZt3/J26heCERXk6eoFp3HwjvLeg5P PvfJy9FPLWSxBQsE6Y+2nCY= X-Google-Smtp-Source: ACHHUZ5/jVczCOvTj0ujwU2RCL/cBkmLhK9+lxiAtMwXxjwFb/GUIB70AgI7OmEAsM0Ry99cY2cWUA== X-Received: by 2002:a05:600c:22d6:b0:3eb:42fc:fb30 with SMTP id 22-20020a05600c22d600b003eb42fcfb30mr4400956wmg.32.1685542384560; Wed, 31 May 2023 07:13:04 -0700 (PDT) Received: from localhost (host81-154-179-160.range81-154.btcentralplus.com. [81.154.179.160]) by smtp.gmail.com with ESMTPSA id x11-20020a1c7c0b000000b003f50876905dsm20954539wmc.6.2023.05.31.07.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 07:13:03 -0700 (PDT) Date: Wed, 31 May 2023 15:10:53 +0100 From: Lorenzo Stoakes To: David Howells Cc: David Hildenbrand , Christoph Hellwig , Jens Axboe , Al Viro , Matthew Wilcox , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH v4 1/3] mm: Don't pin ZERO_PAGE in pin_user_pages() Message-ID: <0e307b3f-d367-4bb2-9506-93a3d70b3e97@lucifer.local> References: <492558dc-1377-fc4b-126f-c358bb000ff7@redhat.com> <20230526214142.958751-1-dhowells@redhat.com> <20230526214142.958751-2-dhowells@redhat.com> <510965.1685522152@warthog.procyon.org.uk> <703628.1685541335@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <703628.1685541335@warthog.procyon.org.uk> X-Stat-Signature: pfugcqaa49q1tztygu6zzqh11idsftcc X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 62B254001E X-Rspam-User: X-HE-Tag: 1685542386-933814 X-HE-Meta: U2FsdGVkX1/zyDPPxaeQAoK44AeA4Z1ZqK6W2yNRt25LJkyOL4mOKGjaQeqbhjItb5edREXL3r0/J7ysg8dcrOXL5E9HxGTcdkhixzdmIcR7CsqN1TYP5ObyoSokeeJLVA12Z5etFQ+lqdyJFR7jC8+EE/eMWjmOjKGTZtBIXG5gnR49e6kQy+in/b1E61ag+gALvqBEEPpgXjE1gmallE8aaxAidUPQ10bWiLZoaia+TsTyQsGLTvMRRrAk+VxKJPxYCcAeCqCcQLoyBBRaI3iRBGWGbvKqSR8CEFyNspmQX5f+S/ghqk0DsA8gSDpX1/xfHQtSQnVpgbBH8ZeOBIShNy4AJmTDTttKMfs0EjTaLxukEHVkVsqSdniA/3AUTOYTjhxRVNDwUArk8Gg/C66n4e9RxcL8VME36DpmFW4GqVlGs/wlufbOpeIOKOAioTC1+ScHCDXTvM+lmnnhRkP05p9xBbB1tWNePzt5uW/0DHWoIRuNEpAy0YuLg1F5O8X+PR5f75pdxoUq8exbDdXoy+VTMdurU0orrvy0pCpPAFAa61PtQ3kWf8OWQUmL8Zru4OkGyv7QHipiXCrONLwjLzPlpuHK1WXdBgRGMmwZ0DqZf0bIi0yS6nFjLoBtUvf9ny9ILXufM9NYNRgFTDDkhobZ5JRHhc/3fgb3T+coe87dH5s67p+ITedTsCDedPVBinRxwyRspAOtosHSgrI9GN/KsVaQzzuvhLVrESmQ5PMUMhxGGWOUVXbh4bdmQnBUAjSrgYLlgnPzf4DVI8F5+G470NsfpKt8hQRYIQawW9y84ghzl//5/LfVEGps0ql2UM/9QeCoda5BOmL328UOravrh35KTYJiQOfje7VNVl1vxLBxskj8SvW6zgP2MkvnxXrLLAlVtjtupR74A5RhCP0oEA2HKFiGPrGusHKkci9/Vgox3naoQ5BLMGxoFP9La3EHtLT88m/JK4e G+mSTJ82 u6a8uiRr+2XxglX6+hs/OCgfLGzW1YU6/k6L34Z9L7ZPZd9vseI4Y/6xiCXh/jzRuSn6um3P9BqTod8vVIsM2hCazQYeEz8Z+ODE0Uaq+f0tNuHT6Aw103O+Rqn7LTgzO52H5nhovINQjfeygJ1Nrmf6ji1MkIMZRWZSobFPb3CExmlPw3yRsOCQubYpnpyhDbN56XZgyaZwTHY1y4uP4k7BVuW8cDFk1L6L7hflVf7fRGaPIeIhZAVj8z+MTif9D6hVuGcuOMz8YkhneHLSj9XUMT6klG+KMqWl5aZ5wlUXMobp6Sqg1HHH0FA2YpeH6AlNJcfdmlkHCcD19NSTsFYGl4GeKgHVzrSKxyNbxO6QnzCnNi+7ZzBwkoie2NH8UlHSxEE1KxFRK3M6SyfLSo5n8rzuW3mR60dUK0rRKTY7kQ8+bBkujvH50jFue+cXefuVofMOdHAqJ1c3TSANnkUuwxA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 31, 2023 at 02:55:35PM +0100, David Howells wrote: > David Hildenbrand wrote: > > > Yes, it would be clearer if we would be using "pinned" now only for FOLL_PIN > > You're not likely to get that. "To pin" is too useful a verb that gets used > in other contexts too. For that reason, I think FOLL_PIN was a poor choice of > name:-/. I guess the English language has got somewhat overloaded. Maybe > FOLL_PEG? ;-) > Might I suggest FOLL_FOLL? As we are essentially 'following' the page once 'pinned'. We could differentiate between what is currently FOLL_GET and FOLL_PIN by using FOLL_FOLL and FOLL_FOLL_FOLL. Patch series coming soon... > > and everything else is simply "taking a temporary reference on the page". > > Excluding refs taken with pins, many refs are more permanent than pins as, so > far as I'm aware, pins only last for the duration of an I/O operation. > > > >> "Note that the refcount of any zero_pages returned among the pinned pages will > > >> not be incremented, and unpin_user_page() will similarly not decrement it." > > > That's not really right (although it happens to be true), because we're > > > talking primarily about the pin counter, not the refcount - and they may be > > > separate. > > > > In any case (FOLL_PIN/FOLL_GET) you increment/decrement the refcount. If we > > have a separate pincount, we increment/decrement the refcount by 1 when > > (un)pinning. > > FOLL_GET isn't relevant here - only FOLL_PIN. Yes, as it happens, we count a > ref if we count a pin, but that's kind of irrelevant; what matters is that the > effect must be undone with un-PUP. > > It would be nice not to get a ref on the zero page in FOLL_GET, but I don't > think we can do that yet. Too many places assume that GUP will give them a > ref they can release later via ordinary methods. > > David >