From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F35ACC433F5 for ; Sat, 13 Nov 2021 20:21:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1F66E60E9B for ; Sat, 13 Nov 2021 20:21:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1F66E60E9B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A235F6B007E; Sat, 13 Nov 2021 15:21:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D1316B0080; Sat, 13 Nov 2021 15:21:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C00E6B0081; Sat, 13 Nov 2021 15:21:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 7DD246B007E for ; Sat, 13 Nov 2021 15:21:43 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 317748089F for ; Sat, 13 Nov 2021 20:21:43 +0000 (UTC) X-FDA: 78805027644.17.CBE4666 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by imf24.hostedemail.com (Postfix) with ESMTP id F2B27B00009E for ; Sat, 13 Nov 2021 20:21:40 +0000 (UTC) Received: by mail-io1-f43.google.com with SMTP id z26so15708537iod.10 for ; Sat, 13 Nov 2021 12:21:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PRtrotC7yQ1PrBoDQpI8uzdE+jeqJk3Tru6SSc7SL9c=; b=ndr+MYiHDHZEcgKWy0JRyuQ4KGUZYN6+9Yq2CxuQUusQq3Kg9wDqx1fMW391Q8/KFP 021v9u+yUJaJxBqo6UOrbp5lesyDiLfrIhAMLb08yU3WId4DDLf3jaxtlWFO/QONf6ms MySdKXUBI3ijksFRYHluXhbZPmSQJHdLcZpOLIAivOrbbmZJhndHOjod2i0MY6annzXU wK3AWoOc6/zpgd9PbU7ap5VwCHnTL/rExlv9wYRKS6FJH6u2x4iMJ9imlr6LSfVNqrVx TWX2Ek3IFF902S06lAzCg2B/CJu9tttHBBGnol2BObV2OVcVLRpJWTCrFZQumZ2awtyz 0pIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PRtrotC7yQ1PrBoDQpI8uzdE+jeqJk3Tru6SSc7SL9c=; b=td1gD/QrecA5NZ+mbt8ZkCTxG/Lmp1ZibwWn1o0hFhV2eJ9oFTbimTSQwyFBD6Th/H V+J/2fyCPJhQxUDHbeWTdgzxov9zaoItnGFETrap+xX51VYHXGCoiZo6qTw1y0kX1x40 G3BeYaIvOOj12N4doO1ddUjZawip+N0ZvxRBFIJsUae5MKd36zxlU/Yx6ZY5oLYs+7Nk NFOB/BWw9KtmqlpsvhP7w2YS8eXdJA6/3qCHndQrJoWlgRaxgFLxg2p+s8WaLCXhbfG0 ZF/V0/W/0D8LmH9ieTkPUR8zMMIcrtJeKsYlrDJ+rlubOw5dIL2lvG9yWLpKvMt3JiaN fwfw== X-Gm-Message-State: AOAM531u1sa6JaG1GD2OqNB7ZgWLZJpbqVZEcDkb1sPOTlL34k/t8eq5 UEDkqwdIVnriSGseFna0JL691Q== X-Google-Smtp-Source: ABdhPJyO3pxnCczbmt6f4j4mtMF0RPmDjqusCGzdmPW0XBJEkrtZLZdc1Ztkn9g6r0dRij4PslR8JQ== X-Received: by 2002:a05:6602:2585:: with SMTP id p5mr11745011ioo.65.1636834900217; Sat, 13 Nov 2021 12:21:40 -0800 (PST) Received: from [192.168.1.116] ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id g10sm7114831ila.34.2021.11.13.12.21.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Nov 2021 12:21:39 -0800 (PST) Subject: Re: [PATCH] mm: shmem: do not call PageHWPoison on a ERR-page To: Linus Torvalds , Arnd Bergmann , Yang Shi Cc: Ajay Garg , Hugh Dickins , Andrew Morton , Linux-MM , Linux Kernel Mailing List References: <20211111084617.6746-1-ajaygargnsit@gmail.com> <628a49dc-f6f7-5aa4-8a4d-4f2ed19b7f3f@kernel.dk> From: Jens Axboe Message-ID: <0e2ad5ac-020f-7e2b-4e15-c875b4634546@kernel.dk> Date: Sat, 13 Nov 2021 13:21:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: F2B27B00009E X-Stat-Signature: c6c47ximyx38pe76ahcw91zddxq6eq67 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=ndr+MYiH; spf=pass (imf24.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.43 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none X-HE-Tag: 1636834900-170382 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/13/21 1:16 PM, Linus Torvalds wrote: > On Sat, Nov 13, 2021 at 9:21 AM Jens Axboe wrote: >> >> Maybe Andrew is out - Linus, if you follow this thread, there are two >> proposed fixes for this. It'd be nice to have one of them in -rc1. > > Neither of the fixes were sent to me, and honestly, I think the real > issue is that the original commit is just too broken for words. > > The error handling in that commit is just entirely lacking. > > I've reverted the commit rather than try to fix up the breakage. > > Because at some point it's just better to say "that was broken" rather > than try to fix it up. And that original commit was too broken to be > worth fixing up. It already had one fix for uninitialized variables > before it even hit my tree, and then caused problems and had obvious > broken error handling. Thanks, that obviously fixes the problem as far as I'm concerned as well. -- Jens Axboe