From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 424E9C433EF for ; Tue, 31 May 2022 12:48:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 883E16B0072; Tue, 31 May 2022 08:48:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 835CF6B0073; Tue, 31 May 2022 08:48:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AD006B0074; Tue, 31 May 2022 08:48:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 572666B0072 for ; Tue, 31 May 2022 08:48:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1394020537 for ; Tue, 31 May 2022 12:48:25 +0000 (UTC) X-FDA: 79526016570.09.15B04CC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id A3DCEC0058 for ; Tue, 31 May 2022 12:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654001304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EPrMSZovc8VHOvaBgoFEXFty7pLwDi2QHtnXl6KmPkE=; b=bZf+nRMMGBY1Oqb+wquP7UPSoGz5Q85OyOyRYzab73Q8MvhL857aKmnbqlXhGLpoY47kUb Hv6aQuDhDVnCMM6w0YOzqOWT1RtqV6HpyfMFzA6k4pDC1d+fEKrkpkEUIldKvj6eS8MZeg YIpnJ4W7iHaUOUYp+YiZOzSY+Qdkd/g= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-hveYwMNpOcGzS9V_lXCqxg-1; Tue, 31 May 2022 08:48:23 -0400 X-MC-Unique: hveYwMNpOcGzS9V_lXCqxg-1 Received: by mail-wr1-f71.google.com with SMTP id e24-20020a5d5958000000b0020ffd1d62b2so2039490wri.17 for ; Tue, 31 May 2022 05:48:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=EPrMSZovc8VHOvaBgoFEXFty7pLwDi2QHtnXl6KmPkE=; b=XGISbi0prox+LVzFstNdMMBsLBq5yhqK7xRnkDXxKGzcR+tmW4/jm987PsPC52EHIA nGbHpz59YcUjCwV9PArMP2vDQgSCTXh618zsaeN2954AVNiyJwltzVVQnW+emixn2z9q FwMBx0iXMY9bdXC2RSou2PLmFmFKd1rSMmqt4mutRltiHfDt2sZsIfA02jVNAOS2OErQ MrRksvBUdqDzhlmBmSjQ1FF3z7tqkJy6YMXLxiMlYjqM2vE4UfGqJ5V7iFUT2TCUdnfq fJULPM2jQl4t01NNW7gimCsgjZsbVyyHycmX/3cvvCKRkTOyOPov1Xfs5OMQ+GudET9q DQBA== X-Gm-Message-State: AOAM5321uKUykNc5r+qO7d4hDhNWDeaPxqfGQI8AmIcBVGc/BjqPWLyn 68qBoiwXpGoaWHrbGjtOXrwnA2/g8or2KWmSzSHR4Yohxb+aA5sZjOD2A5/4dMDRWIUXVWCULE9 lhjHhVb+XNHw= X-Received: by 2002:a05:600c:3b05:b0:397:54ce:896 with SMTP id m5-20020a05600c3b0500b0039754ce0896mr23468724wms.3.1654001301763; Tue, 31 May 2022 05:48:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3yBlVpu/2rIV/yUlL+sCnuhz1GmFj2iWNFe3ezeBDW/ktzwfQ3Xlkqb6JMZM4m2Fl8gnmXA== X-Received: by 2002:a05:600c:3b05:b0:397:54ce:896 with SMTP id m5-20020a05600c3b0500b0039754ce0896mr23468714wms.3.1654001301565; Tue, 31 May 2022 05:48:21 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:f100:8096:9368:ba52:a341? (p200300cbc708f10080969368ba52a341.dip0.t-ipconnect.de. [2003:cb:c708:f100:8096:9368:ba52:a341]) by smtp.gmail.com with ESMTPSA id n9-20020a5d4009000000b0021022ecd0a7sm9479833wrp.74.2022.05.31.05.48.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 05:48:20 -0700 (PDT) Message-ID: <0e2005c7-8ccb-7d07-57ed-a04cfd7af369@redhat.com> Date: Tue, 31 May 2022 14:48:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] mm/memremap: fix missing call to untrack_pfn() in pagemap_range() To: Miaohe Lin , akpm@linux-foundation.org Cc: anshuman.khandual@arm.com, osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220531122643.25249-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220531122643.25249-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: w1tgbpie9utqosmixpbo5hztxkmmfekr Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bZf+nRMM; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf28.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A3DCEC0058 X-HE-Tag: 1654001266-162769 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.05.22 14:26, Miaohe Lin wrote: > We forget to call untrack_pfn() to pair with track_pfn_remap() when range > is not allowed to hotplug. Fix it by jump err_kasan. > > Fixes: bca3feaa0764 ("mm/memory_hotplug: prevalidate the address range being added with platform") > Signed-off-by: Miaohe Lin > --- > mm/memremap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memremap.c b/mm/memremap.c > index 2b92e97cb25b..b870a659eee6 100644 > --- a/mm/memremap.c > +++ b/mm/memremap.c > @@ -214,7 +214,7 @@ static int pagemap_range(struct dev_pagemap *pgmap, struct mhp_params *params, > > if (!mhp_range_allowed(range->start, range_len(range), !is_private)) { > error = -EINVAL; > - goto err_pfn_remap; > + goto err_kasan; > } > > mem_hotplug_begin(); Thanks! Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb