* [PATCH] mm/memremap: fix missing call to untrack_pfn() in pagemap_range()
@ 2022-05-31 12:26 Miaohe Lin
2022-05-31 12:48 ` David Hildenbrand
2022-05-31 15:30 ` Muchun Song
0 siblings, 2 replies; 3+ messages in thread
From: Miaohe Lin @ 2022-05-31 12:26 UTC (permalink / raw)
To: akpm
Cc: anshuman.khandual, david, osalvador, linux-mm, linux-kernel, linmiaohe
We forget to call untrack_pfn() to pair with track_pfn_remap() when range
is not allowed to hotplug. Fix it by jump err_kasan.
Fixes: bca3feaa0764 ("mm/memory_hotplug: prevalidate the address range being added with platform")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/memremap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memremap.c b/mm/memremap.c
index 2b92e97cb25b..b870a659eee6 100644
--- a/mm/memremap.c
+++ b/mm/memremap.c
@@ -214,7 +214,7 @@ static int pagemap_range(struct dev_pagemap *pgmap, struct mhp_params *params,
if (!mhp_range_allowed(range->start, range_len(range), !is_private)) {
error = -EINVAL;
- goto err_pfn_remap;
+ goto err_kasan;
}
mem_hotplug_begin();
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/memremap: fix missing call to untrack_pfn() in pagemap_range()
2022-05-31 12:26 [PATCH] mm/memremap: fix missing call to untrack_pfn() in pagemap_range() Miaohe Lin
@ 2022-05-31 12:48 ` David Hildenbrand
2022-05-31 15:30 ` Muchun Song
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2022-05-31 12:48 UTC (permalink / raw)
To: Miaohe Lin, akpm; +Cc: anshuman.khandual, osalvador, linux-mm, linux-kernel
On 31.05.22 14:26, Miaohe Lin wrote:
> We forget to call untrack_pfn() to pair with track_pfn_remap() when range
> is not allowed to hotplug. Fix it by jump err_kasan.
>
> Fixes: bca3feaa0764 ("mm/memory_hotplug: prevalidate the address range being added with platform")
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/memremap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memremap.c b/mm/memremap.c
> index 2b92e97cb25b..b870a659eee6 100644
> --- a/mm/memremap.c
> +++ b/mm/memremap.c
> @@ -214,7 +214,7 @@ static int pagemap_range(struct dev_pagemap *pgmap, struct mhp_params *params,
>
> if (!mhp_range_allowed(range->start, range_len(range), !is_private)) {
> error = -EINVAL;
> - goto err_pfn_remap;
> + goto err_kasan;
> }
>
> mem_hotplug_begin();
Thanks!
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/memremap: fix missing call to untrack_pfn() in pagemap_range()
2022-05-31 12:26 [PATCH] mm/memremap: fix missing call to untrack_pfn() in pagemap_range() Miaohe Lin
2022-05-31 12:48 ` David Hildenbrand
@ 2022-05-31 15:30 ` Muchun Song
1 sibling, 0 replies; 3+ messages in thread
From: Muchun Song @ 2022-05-31 15:30 UTC (permalink / raw)
To: Miaohe Lin
Cc: akpm, anshuman.khandual, david, osalvador, linux-mm, linux-kernel
On Tue, May 31, 2022 at 08:26:43PM +0800, Miaohe Lin wrote:
> We forget to call untrack_pfn() to pair with track_pfn_remap() when range
> is not allowed to hotplug. Fix it by jump err_kasan.
>
> Fixes: bca3feaa0764 ("mm/memory_hotplug: prevalidate the address range being added with platform")
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Good catch.
Acked-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-31 15:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-31 12:26 [PATCH] mm/memremap: fix missing call to untrack_pfn() in pagemap_range() Miaohe Lin
2022-05-31 12:48 ` David Hildenbrand
2022-05-31 15:30 ` Muchun Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox