From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Yishai Hadas <yishaih@nvidia.com>
Cc: "hch@lst.de" <hch@lst.de>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"willy@infradead.org" <willy@infradead.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"logang@deltatee.com" <logang@deltatee.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
Jason Gunthorpe <jgg@nvidia.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leon Romanovsky <leonro@nvidia.com>,
Maor Gottlieb <maorg@nvidia.com>
Subject: Re: [PATCH V1] lib/scatterlist: Fix to calculate the last_pg properly
Date: Wed, 11 Jan 2023 10:22:24 +0000 [thread overview]
Message-ID: <0e0c8aaf-9ec6-d3e0-b530-1a4ec405d0f2@nvidia.com> (raw)
In-Reply-To: <20230111101054.188136-1-yishaih@nvidia.com>
On 1/11/23 02:10, Yishai Hadas wrote:
> The last_pg is wrong, it is actually the first page of the last
> scatterlist element. To get the last page of the last scatterlist
> element we have to add prv->length. So it is checking mergability
> against the wrong page, Further, a SG element is not guaranteed to end
> on a page boundary, so we have to check the sub page location also for
> merge eligibility.
>
> Fix the above by checking physical contiguity based on PFNs, compute the
> actual last page and then call pages_are_mergable().
>
> Fixes: 1567b49d1a40 ("lib/scatterlist: add check when merging zone device pages")
> Reported-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2023-01-11 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 10:10 Yishai Hadas
2023-01-11 10:22 ` Chaitanya Kulkarni [this message]
2023-01-16 16:10 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e0c8aaf-9ec6-d3e0-b530-1a4ec405d0f2@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=maorg@nvidia.com \
--cc=willy@infradead.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox