From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1335FC4332F for ; Tue, 7 Nov 2023 03:54:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8564E6B025C; Mon, 6 Nov 2023 22:54:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DF556B025E; Mon, 6 Nov 2023 22:54:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 680C86B025F; Mon, 6 Nov 2023 22:54:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 544E06B025C for ; Mon, 6 Nov 2023 22:54:10 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 27DC7B5A06 for ; Tue, 7 Nov 2023 03:54:10 +0000 (UTC) X-FDA: 81429790260.29.1A4474C Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf02.hostedemail.com (Postfix) with ESMTP id 2A15B80016 for ; Tue, 7 Nov 2023 03:54:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=dnkOFzwu; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.41 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699329248; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5ohRlubhGgc/ByJJVo91v+dC9pOe3E7CBQIDJq7OEEU=; b=KWCcHIwDMqkPl0XPsdLxXbFBNyNrZf8cbdkFvpB4S4+dlesqSBVd1nDppyYvDsaNN+Mqns dEhtERcrbQqRFGQ9LiEeEwh+GBj/GnkA+QHFcFKLF5pVjxyKbYbq7y9izGDHZEA0vxYNap ZDwD/CO/nMVCBm0+kLi5lLvfhKeuXAM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699329248; a=rsa-sha256; cv=none; b=sKGYYop0J32eT4wJfIYXlvKBbtUI2DZ+tfrTqoCi2El8od4VorxzRmlyAoVy8/kZp/ZQQ4 CczJZSQGWn1jg0kh0YRXdiW0z/rFkmR7hk8UxTXWWH4W3VY8p4AxGuIa/gth/SmLJ+bRlK fFj2QgYFT5x8cr/GspQa3mIgJSiNZn8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=dnkOFzwu; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.208.41 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5441ba3e53cso6267431a12.1 for ; Mon, 06 Nov 2023 19:54:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699329246; x=1699934046; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5ohRlubhGgc/ByJJVo91v+dC9pOe3E7CBQIDJq7OEEU=; b=dnkOFzwul/KmW0g1yu0fEb7ePeg7Olm53w1/JYWDLJYJzQfdiPf6TSzU+ZBVyMBWd5 dU/h+nXZ4iV+9BIDDIQdU8kJnxPbSneAVAOoHtrfkNnPBih/MyfL0rhcwTNG9OVf2aaN gr4D4KWPjpMxy8xmCwnMIzikZGFX2WADHbt2lotOMLkc7c1/JpvgGWW/+ExCc3KkO5g2 bxiazx7olLlYwGwWZ3p6El9ImW4v4EO7yuM8ndSJ8c6boUIR9GPFoQMqMIOERnGpr6YI 1KPyCcd3IH3irogI/dHlyHi/uz245drvfRs1nb+ZQKUL1oC5qbx/pYGj79Y2XVpn4BCV RMhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699329246; x=1699934046; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5ohRlubhGgc/ByJJVo91v+dC9pOe3E7CBQIDJq7OEEU=; b=h4fjgrA4KK2llqq1xufz8nt9IL7i5cNdzut2V1uiDw0j1Z1cLDBDeHV3c3mA4Kj25N azYBhv+bnmIqilY5pJ1NnBaDk8JlXALerXs9qaElwChmhu6sN4bRR91QF/eBxoZPwCkE hV8e2YLJFYlV4k1MO1N0KDEwPIe6PwGztyl0gtpW+iUb8nUgTv4DsBaog1b4uobxZtTc s1bwG/R0tVoN2Cy9iDCdhwV1ddUT0pECfluYFtVQacNou7ZLNmus4UAotPRFfLo4Fq0k wMknMACGnCmcUm6YwjYuUjAGr2u+q2S6+DaoII+db7WoEnBPOn57HpdqujVIB0P86kZn joXg== X-Gm-Message-State: AOJu0YxTLxrTh9VJOZml5ek+k3aa1VZre3Ipzc2zWtJP25r36iTSaRMn xRQXo0dsLBLXHxMvAIVg2Z6MCw== X-Google-Smtp-Source: AGHT+IHRcH59lDrKp36GaSoTXGdBrj80c45Dg5D5kg/o2f2kX1Ge2cCV5nB0wgAbn+E0i3WM9zCrQw== X-Received: by 2002:a17:906:7305:b0:9bd:931e:30d8 with SMTP id di5-20020a170906730500b009bd931e30d8mr14069528ejc.14.1699329246453; Mon, 06 Nov 2023 19:54:06 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id bi19-20020a170906a25300b009adcb6c0f0esm535379ejb.193.2023.11.06.19.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 19:54:06 -0800 (PST) Date: Tue, 7 Nov 2023 06:54:03 +0300 From: Dan Carpenter To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm/damon/sysfs: eliminate potential uninitialized variable warning Message-ID: <0df4612e-6035-496b-96c4-d790b098aadb@kadam.mountain> References: <18d2f41d-e442-4f73-89f1-50bf20cd85f2@kadam.mountain> <20231106165205.48264-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231106165205.48264-1-sj@kernel.org> X-Stat-Signature: eif4kefd5jy5igsuke4sak3koq6ds6jy X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2A15B80016 X-Rspam-User: X-HE-Tag: 1699329247-300425 X-HE-Meta: U2FsdGVkX18onLVbu7W5nLveHAN+rSHEsT78UHdzZ7QoZhsede+9GWQZcfXAkcvotwLHuAKC3pHGQ4an0/Ur5jgH1Qxuaax4DeC39kUyDXWiewMZy3zH22KhdloYPIqfpO5sZUSWFLmtZ8OOcxt5trN5lJjURybV2gBif+KQsQ5YypdCAZ2kUU/qEL0oKYwNwc5lV8VdFYLPuN1WBA3chQ58+ZU0cm4o01sLogaMy/bA4DHfLOPvlQPcueGrcO50LT3Tsruc/LpKg1jvDAyeIk6D8qrit8QwGwHPRpTJLpjF2NSgXYemY9z2VqDYNtmOhYymThUWLzWoAJQ7/xrxAID92T55ncp74S4fI+V/90b9B1e6NfiO4zYB0xtLP6wdoBteQwUCqhJ/azKCyGIXsJc69Qn7ySTz3o3nKCSh0Ul8evjF12wRan/2WrY1k+6twnprSitklpOVeakGhK7s0ZzE6AuDWfoGaKtYt6BHKkY4TCs2xcs0XIUgRsM6GHDk5IxPnaj5O7ZlK/pbryHdcvbl5+dZyFQHGwPoXd9obcCR2K/Vf3vCPWuwg5gukPlAjcYbscNL8eHpGU31Z+OLgWycBjwezi3hbwZCBBF75rbrqgDd3OqiJWjUXem8zRFzoViHAOeTdW1H+M9Ep5XROuWMcXyCoe11s7zZvyJ1WyVOQOzUfHDENTlwN3SR7xMfqnYc5iSFPj7c8vBhBPxt4pwxByYVDayknWOgmo4OcyeZ44dSSTYMMfGzxre2KKiIHVd9CQQauPQAa3k1o+SXEmkZ/YCle2BYf+iShLyIXjcT7YPQjCXB7xh12q7tJtf5JhgVoiu4GMKra5ExYqQSrEDUP0TsJlw0sxuZW49TEGEFzrGRNdmn4jC2lC3zReJ/cER+0M18R1JP49Y+GEgBsoHjZPUFX8j7cCLl4tUGcEcx7PniFeR5jF7B/aTY4gjJtrkfPuFhuhujTcACNEH t2YAWTo/ gpQfG1idclx/CwW/qATS4mHu74JwzCqUYLjrrgujcibmRf3PFDWZYCbTga40yn1Nt2MpxB8I90FVrgu/xMbjHWW/6fFGuomvlvMqc3TUh/I5WyKAAlaYgja1MJfEYZUhHqMxoq9Hdcbsu0/dZ6O54F21YZNuJdbxoyF/71nJ9ctpHqMt7Az/MxvyoF433pqQsg0ZiOv8G0iHsIn5XLeJD1OR3K62U/TWtiD559LI0gSQB1oAmj8VSzHTRj2HEkNFgaS8cIN4mexTtwM/ICa+HaJATrtBLgqEuVcZJxV2mnAjbBm0ayBQF5pfo3Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 06, 2023 at 04:52:05PM +0000, SeongJae Park wrote: > But I think the unhandling of the return value is a bug itself, that not making > system crash like things but might make user confused, so I was preparing a > followup fix for that, too. So, though the problem the fixes will fix are not > significant, I'd prefer merging this and the followup fix to stable trees if > ok, since those are anyway bug fix, and should be simple to apply. If > something conflicts, I will provide backports. Sounds like a plan. Thank you for doing this. :) regards, dan carpenter