From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01232C87FC5 for ; Mon, 21 Jul 2025 09:12:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9295F6B0093; Mon, 21 Jul 2025 05:12:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D9F26B0095; Mon, 21 Jul 2025 05:12:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77B4E6B0096; Mon, 21 Jul 2025 05:12:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 607736B0093 for ; Mon, 21 Jul 2025 05:12:03 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 07B0F111C81 for ; Mon, 21 Jul 2025 09:12:03 +0000 (UTC) X-FDA: 83687704926.21.94DD156 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012050.outbound.protection.outlook.com [52.101.66.50]) by imf08.hostedemail.com (Postfix) with ESMTP id 1251516000A for ; Mon, 21 Jul 2025 09:11:58 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=arm.com header.s=selector1 header.b=TMR8xeRI; dkim=pass header.d=arm.com header.s=selector1 header.b=TMR8xeRI; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of Dev.Jain@arm.com designates 52.101.66.50 as permitted sender) smtp.mailfrom=Dev.Jain@arm.com; arc=pass ("microsoft.com:s=arcselector10001:i=2") ARC-Seal: i=3; s=arc-20220608; d=hostedemail.com; t=1753089119; a=rsa-sha256; cv=pass; b=Iag45Y23GkvT5tUOhR7jFxAfY9XsdWv2iTWFB9UWtja0tWUHqQivGjiTjFa+fnMeCvvcYa CFFoqcgnL2A4JV/tnCNL2Uf/+ACOumvJDgFp4Cw85cd05Y51KbKK9qRMZyBpNEB68rvRQS QYEgqKqEodOp6YeFh8GXPJgFHL2TTyA= ARC-Authentication-Results: i=3; imf08.hostedemail.com; dkim=pass header.d=arm.com header.s=selector1 header.b=TMR8xeRI; dkim=pass header.d=arm.com header.s=selector1 header.b=TMR8xeRI; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of Dev.Jain@arm.com designates 52.101.66.50 as permitted sender) smtp.mailfrom=Dev.Jain@arm.com; arc=pass ("microsoft.com:s=arcselector10001:i=2") ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753089119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BWPNAKT15T3Dy7cNVBdptztPTjspID7aTO073fKyKNA=; b=na9AWbw34QSQZ+oc3ntnjFG4Zc4qaWiLHhXXtobJBObyJYKD5RnHqfvp3QS3+4WtZQlPWo TwdVJL++VXf5dDCxx1wIgrkyfxW3Wiml6KHkDe4XwkjqPrtyRdzNYemUaLNSXMJW4HmJw4 UXx/K8GagU61xbC6PEFjsjB1g05rZGk= ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=qFmY3rXgR8cjsjsKhp8e23FCI2N0xkJP4Cc1sJB5OiA2alzAYZM19NmyVstyr5tg8YTFp0uDXQLhsMJ5RVtdJ6VK/Qo0netVZEafn8k/obolmKEB+oMAUNk+uF9G3dwX7T2Dk05RZJwuC9cZdqEZYpVT/azCC9HeYStSMtS6sULtERm/l6HMcnlqwxwie2Dk1Js/OQXscWgNKgu/wGmSQKvyZJMNg0GEUZ0c8bUHnJcSwpJpxjYFnZb5qNLcQKm788wO6gz37p5lvWJkE8vBjPcfyrxyIlseBiDuB5Xg0qOySTxqORP2iDW3mDAhRo3Gug8xrji6+S4HncSW9hAYYQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BWPNAKT15T3Dy7cNVBdptztPTjspID7aTO073fKyKNA=; b=J7JW//8+IBova8+pnUPyZFJeGPidoYUkzNRcx48cB1mz7dv7RhyEnvY/BjPfwkj1T+abLMOMFK/GJXB7MjFOZwGVtzca1Eti0NT+uUS6vs1iJHQI25nJIwpGvS4MOTTohRaxFpa8MP8mqfKa/P2e1thkls+rhuFrE4q9II5VltvpbfgOnR1Sf+e+WZJ/VkUf0VfcUzx5C22ExGm86IucJSnbI+xTDdNG9LHUE0WycAFX2Oxqo0iXjav34RO0tbMRKniqjfU8/4nQNR0914+qW0+c+3qmwP5+1HkY/QYLbUQj7Drdz7F29emuvCx4vGHhKDzwaEydM2C2lb8APXbZhQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=huawei.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BWPNAKT15T3Dy7cNVBdptztPTjspID7aTO073fKyKNA=; b=TMR8xeRIHG6BoDOSJEGsQtS+QwarAwSRTSrIh3XWg4K9KJweDMJcs1yQJcGDgAzF6p+CinekUKyvaF/kX7+dVSuzBkx3nIkAngu3QHRN8Yuzux7MQ0wJApN1trI82RN1DZRXXJ1rq0/bIMsqUmhxaH7qTCLbTzfm6vZx1MRIfsU= Received: from DUZPR01CA0169.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b3::13) by AS2PR08MB8718.eurprd08.prod.outlook.com (2603:10a6:20b:55e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8943.30; Mon, 21 Jul 2025 09:11:55 +0000 Received: from DB1PEPF000509F2.eurprd02.prod.outlook.com (2603:10a6:10:4b3:cafe::3e) by DUZPR01CA0169.outlook.office365.com (2603:10a6:10:4b3::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8943.29 via Frontend Transport; Mon, 21 Jul 2025 09:12:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DB1PEPF000509F2.mail.protection.outlook.com (10.167.242.148) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8964.20 via Frontend Transport; Mon, 21 Jul 2025 09:11:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=piEJIIASX3jepcwF6AvI3BUdxD//YxMXY8cc8qXaUCIixl+50gK1lgMqfLbRU+Hw+yNeICi++RISD9ut1Heq3F+fWUSxhBszX8zUi2n4jn5FsQWlR8JRzuWKmitjUJ+y8p1I4A94yyRMpGA7oRkT1AW6bow8/YNpxNKWRc3chTFMQwYMojLouRZiNX3EcEYraLluwO7lcIOPuINyT1cHz+CJNlIW0Aer7dDgOtdkvNJsNhnV8uiggeBFFIUsIrtyxMRCm0M2x9B9RZWNKgrsWTdZqjsMmWrpcLQGjXLAE3OWd1GyG8YSRyiVazDUDEdL3FNJiV+4V6AhXCVIYvXhsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BWPNAKT15T3Dy7cNVBdptztPTjspID7aTO073fKyKNA=; b=yKKDjUJcUUDEBAL0ipG6gCOBP6XLjR1hIfcfkv+VyltI+hz0yQkf63MKw4al0Vy4liZhoDJnJfaY3HNVwfMIlW0PNtQJ167AfYXZPqIyH2574m4exyyx++Z7CehuKSfgPgKwQbRwMNMdMrlZfZGrJwY3A3ru9MUTeAzLLwO/6WeC+ravIZQSbcGZGbxJpGCvwXa7rsioXWE7Jng6R3W6mmvZ7QONvTw9aKbNcKVPM1dVpJStUcVLlKY/ECg+udBuV2dahFSORFxdQLJRVy0krxJhizMyJDFgcPiakw+rLnwAwrUfGs5q5QEPmOHY9supcWCCi5CXM2RLj6fSRJ/dbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BWPNAKT15T3Dy7cNVBdptztPTjspID7aTO073fKyKNA=; b=TMR8xeRIHG6BoDOSJEGsQtS+QwarAwSRTSrIh3XWg4K9KJweDMJcs1yQJcGDgAzF6p+CinekUKyvaF/kX7+dVSuzBkx3nIkAngu3QHRN8Yuzux7MQ0wJApN1trI82RN1DZRXXJ1rq0/bIMsqUmhxaH7qTCLbTzfm6vZx1MRIfsU= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AM9PR08MB7120.eurprd08.prod.outlook.com (2603:10a6:20b:3dc::22) by VI0PR08MB10941.eurprd08.prod.outlook.com (2603:10a6:800:250::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8943.30; Mon, 21 Jul 2025 09:11:22 +0000 Received: from AM9PR08MB7120.eurprd08.prod.outlook.com ([fe80::2933:29aa:2693:d12e]) by AM9PR08MB7120.eurprd08.prod.outlook.com ([fe80::2933:29aa:2693:d12e%5]) with mapi id 15.20.8943.029; Mon, 21 Jul 2025 09:11:22 +0000 Message-ID: <0df4133f-f9e4-41ee-88e1-ab1c857ba923@arm.com> Date: Mon, 21 Jul 2025 14:41:15 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] smaps: fix BUG_ON in smaps_hugetlb_range To: Jinjiang Tu , akpm@linux-foundation.org, david@redhat.com, catalin.marinas@arm.com, lorenzo.stoakes@oracle.com, thiago.bauermann@linaro.org, superman.xpt@gmail.com, christophe.leroy@csgroup.eu, brahmajit.xyz@gmail.com, andrii@kernel.org, avagin@gmail.com, baolin.wang@linux.alibaba.com, ryan.roberts@arm.com, hughd@google.com, rientjes@google.com, mhocko@suse.com, joern@logfs.org Cc: linux-mm@kvack.org, wangkefeng.wang@huawei.com References: <20250721081444.277183-1-tujinjiang@huawei.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20250721081444.277183-1-tujinjiang@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MA0PR01CA0105.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:af::19) To AM9PR08MB7120.eurprd08.prod.outlook.com (2603:10a6:20b:3dc::22) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AM9PR08MB7120:EE_|VI0PR08MB10941:EE_|DB1PEPF000509F2:EE_|AS2PR08MB8718:EE_ X-MS-Office365-Filtering-Correlation-Id: c7c49b8d-9c2b-4473-cfaa-08ddc836a2fd x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|921020|7053199007; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?VGM1bWVrcmpuRWlSa3BoUEczbFVCVVlLSmJzU2h0KzhiQ1kxbEliOWxuTVRT?= =?utf-8?B?c01NZGdUQnNXNVJobkw0MTNyZThVSFFmaGN3N253Wm5pelFoZDBMT2cwSDFn?= =?utf-8?B?Mkh4VWt5RWdndmJKUlZWaXRSZDZsb2x3SE9yaFB1ZDJzSmpWcmM2NEpJR1cx?= =?utf-8?B?QUNMcFZCbE80QStWZFBaM1FwY0dFVkxMSUxQbFNDR0NnYU9ndTJyUEQ2dHdM?= =?utf-8?B?cVBOMDJqTjJucmg5RVEwRFR4MGFhTlVIckpKczZpVURvVHZNWjJVNUVvMGhU?= =?utf-8?B?SkRzbDg1MGp2UFRGRldOZTJUZzJhQTAxV0UrWHc0ZzhlcnFYWHFMKzZ1WUVU?= =?utf-8?B?K0NBQ29yZ2xZOHlhVzQrZkR3UWk0NUZ1RGFOYVVUR0UwdGh0dERTSVJqKzdp?= =?utf-8?B?Z1oyQ1pjamtMTWsvWWVCcEZpbVIxZCtIb2tseDNQSFliQ0lYOGhva0hHL2xv?= =?utf-8?B?Q0Q3RDR6YWxnMVRyRElNc1pPYWZhL2RuRWpUVnBXamxHODZ2ekhnMm92Z3Zz?= =?utf-8?B?cG1SZUp3Ni9rRVRkdk9ZUW15SjBjTjdDVGJhWG11SlJKYnpyblJFTDlQQ1Iw?= =?utf-8?B?YVZVYVFuYitTZEZRVjd5VmxQc3ZIc004TklMdzZCbkhkQzhxWDl1MDdxdFE2?= =?utf-8?B?VkNPbG9nVzdNL0tsWUdHVUhvQ0xuMmpNL2VobnBKVXNyOU5PNmRzNHBmK2wz?= =?utf-8?B?Wlo0Tk5oSDhtbmhOcno0OXpwZzVpbEtIYXAwUEtQQ0p3WEE5eU1Yd0hoR1dv?= =?utf-8?B?dXFNNVlnRDhkbGdxTytQVG43eEZuV0ozdWNNeGxLR3MvaHV3eWgrTFBaMDc3?= =?utf-8?B?MWY0U0NhLzNjSEZMNndUbzFUQzV1MUhtUU0yR0pmaW44S3dLUW5kMHFFSVdT?= =?utf-8?B?TTlBYjlNa1U1eU5OcXg5RE1YK28vWVNOTFpuTG4yaE5GY1RtS2R1MjFDblAz?= =?utf-8?B?MGVaREVBdk9raXJzK1BGL242eDgvcEVmb1BjeFc0WjV3cTlGekNGalhMRjF3?= =?utf-8?B?Wkd1MG91VEw0ZjJxNTluN1VzUXVXeFVOVXZOMHhEQUhkcVRUcTY5Z0M4K2Jr?= =?utf-8?B?TmgvRkR5cWVGR0VGQjhWQzZKNVZ6Uk9JQVJUTGkveUN1ZmNJZkp0YkZ4anRU?= =?utf-8?B?dTN2aE1kSVRJU2o3RE1sVDlmYWZGMjVsNWVKWU5ESWw4aUJST2k5OHMvQnpW?= =?utf-8?B?WkQ3ME9FWDRwYnIrSk52VGN6MmJyQkp0K2p3eHltaWZlMGNaU1ZTUWZIeXps?= =?utf-8?B?MXVhVThLSmhZbHV0SmhaQnVxMTJIaDkzOTRuTUlEdm5lV0FmVmNuQldmV0p3?= =?utf-8?B?ZFVSQzZRSlVveHJMNGRRWlpCaGdiRXZxbmJoTTRlZk51akwrVzRrdkRzZ3ZB?= =?utf-8?B?TUk5K2V0KzFZWFE1Mm9wMXczVkxuKzJXSXU3eXQyUTFKUHFxVGdibCtidDEz?= =?utf-8?B?MmJtWWxKQ25IOUhZZ3g0VGY1Ym9uYzYwZzFEYkhITU5oL21NMU5qYVN1MkN3?= =?utf-8?B?MHRncEVvdldLeUFiM2ZnOFIvQktLanNwTkhOVFBtRHQ4YkxOb0tHalkvWmJk?= =?utf-8?B?NnIrUlQwaXRSb0FkeEZYZlVxZVRPVmJRUHJRMkZBQnVNY0VVc0ZUWGRxd0xs?= =?utf-8?B?emRsdlkwcTRqRkNTa1pJZzRVRTNCekdqMjhNcmpWajd0WUViTCtNdC93YVAw?= =?utf-8?B?d3BteGhiZ0lQR0JRamdxVDB4UjVGZHM2OVhBa2V4TEY3aWgrNkNJMDlzdTZm?= =?utf-8?B?RTZuTGVLQ3BpeHVuRzJLdklHdnFZVDExbEYvYTRFeTlaT2pSNXJWZXZGMUpn?= =?utf-8?B?aFB6MGE5bjNLeU1nQmsxRU1GL0J5dEJyWU05TGV1QnV1Z0MwS3Nlc3hacVAv?= =?utf-8?B?VU9MRmYyWGo0ellFUGxoNjJ4bmRWcUw1aGJxQ2RTUU9zQ2c1Q2NzbWgvUnlQ?= =?utf-8?Q?ZNGzeuOnV9lv2YgY13gD+jPYJlMJH1wD?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR08MB7120.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(921020)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB10941 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF000509F2.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 891e1bfd-4290-465b-0174-08ddc8368f62 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|14060799003|36860700013|82310400026|35042699022|921020|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eDVCVzkxTDFUbE96UFcwbkdBbEtLcERUaGVxTUNLTlFsOW56dTdVMHpGNmZh?= =?utf-8?B?WEtGODI4WENabFE5ZytnMTRmOFYxck9uV3VPSHlxeDc3L1BsYXJtNHhIV1E4?= =?utf-8?B?aldTNm9TOEtwMGxMRFlreWNHQlZ3OXZ0NUE4VTk2VnBCeUlGcjZ0eXBNZzYr?= =?utf-8?B?d1FrQTBnUW91NGt0ZDdQamZmckFMdU5UajVmdVB2empKTUc2ZndIdkREdnVv?= =?utf-8?B?RnBDZmliR29la2VqcE5vYXdDZCtHZW5UaWgxZ3hUS2lSdGJXak9uTVZUZ3Zh?= =?utf-8?B?c21kc1NVTjdSY1lrcDhYMEJUQzBUblliQTlRbWdzcTBLUTRodjZpZUpMWlpi?= =?utf-8?B?QUFPaHdqTkRyL2UvMGk5cENGOEgyUHg4ZXhUUEIxS0tTR09HYjNVZFRBMHhx?= =?utf-8?B?aWd3b1ZRWGk2amVFQVBNOGNnKzJJbUZjaXF3dHYvbnpIRU9GbWJ2SkxDYzlX?= =?utf-8?B?MjdFNTZYNWtsMTFtNWFIaytwb1dCUzhMdFpVVkpsTTh4cWEvdmFoYkZuamdH?= =?utf-8?B?OElaNVl6NzNreWJIVi90MlhVR2E1UmNpbzByQXhPTnVhcUhvNEVzN1l6eUR1?= =?utf-8?B?Z1ZNWWFjMGdXYzhudnR4eDBLWnFrTStnZS9BOHgzRVFWeXczVkhaTUc0c2pI?= =?utf-8?B?SjM4MlpZLzMwTHd1aFJUVnp1ZmlTdGNyMDBOeDlVeXNLamw3SEVwSjArUWhs?= =?utf-8?B?bVVLTmdDdk5hTjJZaWVPMkFMTHVmWXR0MWE1WEV3akhXYzQvaEhKYlNpNSt4?= =?utf-8?B?U3VCU1FEczF4NGplRk9OU1ErV1dMTFo4VFJ5M3JKaFczbExmTEN0STNqTlhu?= =?utf-8?B?NDJnRGNmOW9WdkdWNG1Tc0ExRzJQbGhzVDQydWJOYlZic1l4WEsyWUxuNjU5?= =?utf-8?B?cTFINGtDQlQ5QlB5RHdxMDRhbXk0MVdqVWVBYWVGaURjZnNkczN1Vmh2d2lp?= =?utf-8?B?RkF1MmpEci85Tm41L084cmdxTGdrS3VxcEhjUnhwVjhONUw1MThvT1RlYkM0?= =?utf-8?B?M05rRXBndjRrRGQxa2V0VjdMdTd0bVJndllMcGVRSlhGK0lVeDM3MEt3bWR0?= =?utf-8?B?ekFSczlIYU11dFc5dEhiaEptUml1VzBiOGRwbEduSlh4c3FtSXZuUnBQTjdx?= =?utf-8?B?SlR2YTQva1cvbkpaS1pDOWxxVDJPcjd3SnBJbDRWaWE2UGJ2MlFLUmhOaTlG?= =?utf-8?B?bkkwcllIYWp3K0t3RFN0TUpqNnB6VExVWTNiZjFXZENmTng2bFhmZC9UU2ps?= =?utf-8?B?RFJaK0xvVHQyWmtKQ3h3NXN6cVhhSlhkVGRyZVpTemV6emNHMTFBb2IxNnJu?= =?utf-8?B?R2d6REp3SXRQMGNxVTZ1eHlScVgwMDNTUjRCQjdoeHJCaXpoWDRlekdRNVUv?= =?utf-8?B?R01oTHAwUXhPd3A0U0RpODRVVHJuTHRsbjJhNmNERlV4eUQxQ2JuUC9PUkM1?= =?utf-8?B?bEdkSkwwdFl4azN0bmRvdTVCSnNoYlByQ2lrRmtoT3BzQXFzd1hCeDFBY3Rk?= =?utf-8?B?QndJZGl1QlVUOUQvYnBZRWpHNFNCZjgyODJBT1FZVHlveTB5d3ZVaGNNeS9M?= =?utf-8?B?dnE0dDIzOE1EOHRXOXJmL2V4Y1VLbGVUNm1wV20wWHpibHRFTUVVRFJjWFJx?= =?utf-8?B?YlBJbDVzbjNXUWFBTUlRdWJ5UGt6eU4zZ0MvdURwMEU4Z2ZraDY4VG5iMnZs?= =?utf-8?B?OUhMTU44UmFXSkF0NGQrRW1RMFZ0OUFzQWdGcXZZQzU0b0xNWDE4cGMrWWlT?= =?utf-8?B?cTlwa0t0RWF3MzJWeU5CT2xpai8xUk9weFVJaGxTcEc3bGYvVTJTSXZJN2Zh?= =?utf-8?B?Wm82bkZXYnZ4S1RHQU1HYStEOWQ0VFp3UHRnRFJ6QUpseTdJWFh4TUpQZlh1?= =?utf-8?B?NzUvZnM2L0dreHAwd3E5SWtVdmNQUFd5Z04xcjRTVmx3VlJlbEJ0ajJwdmlG?= =?utf-8?B?cFc1YU1jNFJTZVlLcUxnRVJxVkJ3SkFiMXE3K2FpUnQwd0ZkazhvQTBkTExX?= =?utf-8?B?U0QrbVlNZkVra0U1NCt1Z3hER0ppcEdXd1hYRXhrZDZKR0tEdlpid1daVmFp?= =?utf-8?Q?oK6WRC?= X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(14060799003)(36860700013)(82310400026)(35042699022)(921020)(7053199007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2025 09:11:54.3803 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7c49b8d-9c2b-4473-cfaa-08ddc836a2fd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509F2.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8718 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1251516000A X-Stat-Signature: pt194o9c19t1hk4egh71zq9zj3dknsbt X-HE-Tag: 1753089118-841876 X-HE-Meta: U2FsdGVkX19T0PPt6h1Hk3MYpQXLdtfHQI+lT4NG7+TWo3Jr1/PHy6cqZDcGVp2fZ06Juu1weGLRDTw4kSe4yxGkWxglKvr1FVJWcfslgy9nBrgYZwl5xrgewm/feh5fYWAQPgfGQohlCySkdy/nBkIT9Y5nGrT21TxVTVueOe0FVg+AhWFldePAz35kNnbnhglzzUs6xmlRdFJQSCJ9SubMWIYti0MCLuHD/iUXNEASuw4vuIjHCgHeVVqu2/SwWCMuTS22NWo6knyWe+gs7mZhfrGvpSirMXF/q93zC9CvqAOMArZnZTQR94aOLG2BLt3e1yoFZUrMX7K05bw/T4n7jM1r3IBiMhf4SVNv7jjG6FXn3afTDQ4sR9OJq7ldfRU2UgzOho4kf6rqJVMwuWcM5rjXdmz8Rt4VRVfdRJX0mcAWfGzSJOgmrE671anPkDzmoJ55OInyPkC0mmBxpVwxiHhzKl58Dk1LuoauDVywCPsfGvND6tRmAUCpuBQmEzNcuTY6qkkYHYJgTCo2gNYWeQZQ5/kf8n/SzCd2piKXkzwUbpeCYTV5izV+WGHerK9RaUpLvyy6FgYe7WJ6LId0psqK+60Zjtkvdl63g0u6wIgIBZjaxvxgXEKBbscd5d71ofimhExZgGFF+ls07jYEg/HhKh52jZCvrFLvylNkVEi8aEVJrn65HjGyrvHV4onw8Rt4L153jok/KKpRkspIos0F1BB6lTaiNSVPb/Rdnj8AS1/fHQFJgMziS+p3TN0N8Z6IDsfVKD8chKu8JQPgeVMXN40ZI09YBbyuM4FtWvys8B3TQTkUw944OkeMyB5oexvOPAwcjQaa9tdIsKl1hcn1UhiPYa/Yg00a9/bV9sK7yXB+ToOWw7XDukRI2ip5MvP2nUfgB70twUm6pra9XktpVmYX16k58tuH8Mk9hhwzd+UUIot3WmgzjkgiFHRUr/PeUdV4bWyX90I IdX6/Ppc UCR0k/UtTa2afiwxfYJlAJtjxFiOYZABj5RdNf7wamaiztOG4HAPj3CLdTmtCon3wOE2tb6VpwpypW6rg44QFBCkf//06bx9q8gQr0r1nRJ+NeTt8qpIA4aU2iOP2Of8lsviFkXOaqnXdQnRhwkX/ow4WIf04ml9pbJP92JpsOlnoQ4iHOJUmgfvq6Gni7qN2u1lVB8xsSADgujjQ1x/tG+2w52xOTx4ub7j6Sbi7qyrix3IfSXuq02qi8uHFZ76iul+irHBuWk4RQo5L3Ig4aR86yv7HCXpxdLEz7eK+f7B2y5SS/J6AEfYGemVdRFX/wIPGnAxWnSN1mZYfn5W5QiHVb/weeSWeen2OZgkIhGVoLmoQzkLBmO1oFtTgiq5RqZ1UlypDWr8+jW9eEi3qiJjiBNilTl0S5P5LbrGq04AkULR+pvdLoP1bLZoyXKuMb8+Jko2TGTu1VAcNDYnBkJ72hCAbRO9XHaxIRAbKQ54MfKC039Bx3KnLH1Skh4X4NmQ96/tOJxcGucmwy9z6Mp4unDH0HjppSYaqX3nU9qQyhFzpQqq33zjNkT8XwsoEzL65oB1xM3BBAySIsu/jb9hfSTS7Kg37QeX/4ezQF5Ocm3gStLa9cfs8XXKgDV/RWoXePALmfn1tIiM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21/07/25 1:44 pm, Jinjiang Tu wrote: > smaps_hugetlb_range() handles the pte without holdling ptl, and may be > concurrenct with migration, leaing to BUG_ON in pfn_swap_entry_to_page(). > The race is as follows. > > smaps_hugetlb_range migrate_pages > huge_ptep_get > remove_migration_ptes > folio_unlock > pfn_swap_entry_folio > BUG_ON > > To fix it, hold ptl lock in smaps_hugetlb_range(). > > Fixes: 25ee01a2fca0 ("mm: hugetlb: proc: add hugetlb-related fields to /p= roc/PID/smaps") > Signed-off-by: Jinjiang Tu > --- > fs/proc/task_mmu.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 751479eb128f..0102ab3aaec1 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -1020,10 +1020,13 @@ static int smaps_hugetlb_range(pte_t *pte, unsign= ed long hmask, > { > struct mem_size_stats *mss =3D walk->private; > struct vm_area_struct *vma =3D walk->vma; > - pte_t ptent =3D huge_ptep_get(walk->mm, addr, pte); > struct folio *folio =3D NULL; > bool present =3D false; > + spinlock_t *ptl; > + pte_t ptent; > > + ptl =3D huge_pte_lock(hstate_vma(vma), walk->mm, pte); > + ptent =3D huge_ptep_get(walk->mm, addr, pte); > if (pte_present(ptent)) { > folio =3D page_folio(pte_page(ptent)); > present =3D true; > @@ -1042,6 +1045,7 @@ static int smaps_hugetlb_range(pte_t *pte, unsigned= long hmask, > else > mss->private_hugetlb +=3D huge_page_size(hstate_vma= (vma)); > } > + spin_unlock(ptl); > return 0; > } > #else LGTM but will wait for others... the subject line at the very least should be "fix race between smaps and migration"; or, reading smaps_pte_range it doesn't jump at me why one would run smaps_hugetlb_range without the PTL, it can be "take PTL in smaps_hugetlb_range". The current subject line doesn't sound right, "fixing BUG_ON" means nothing :) IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.