From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50862E77198 for ; Mon, 6 Jan 2025 16:51:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 849FF6B0088; Mon, 6 Jan 2025 11:51:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FA9B6B0089; Mon, 6 Jan 2025 11:51:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 672696B008A; Mon, 6 Jan 2025 11:51:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 492E76B0088 for ; Mon, 6 Jan 2025 11:51:04 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AB1981616A4 for ; Mon, 6 Jan 2025 16:51:03 +0000 (UTC) X-FDA: 82977616806.29.AA92B40 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by imf20.hostedemail.com (Postfix) with ESMTP id BED351C0015 for ; Mon, 6 Jan 2025 16:51:00 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DvJonIkq; spf=pass (imf20.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736182261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ABREfEjXLTl9yGzWrLZydQginbGxRlQZyNh5PnTpF/o=; b=WtA3j1jyclTWlYNc4dl2Qrp6HNRO9cNLtRT+HTFINCG4PpufUSUf0iTgMoWVbaxuI4D4+/ NpfAta0KIYudjrAONZzbswYdwJJ7ikRCGArAkSGxHSu1WI+r9jFev/bB1gCe506o2T3EJl cY5TdlAUn//zvH2PDGTonyuFWyGN41w= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DvJonIkq; spf=pass (imf20.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.16 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736182261; a=rsa-sha256; cv=none; b=e67/za6t7OsMAdqH3yZWMoyySnASeo0NMRnrKI7hAHlICk1PRbMPTLRSyoagpFV49sJrqL //PEHIUn3VI+igt3EItZHA9dk2QCxTZOqccIqNIo5+XaMBNu4bXqdgigzH5zRxkzjK6TMR z106gIv9+tOeAg170FwA1B5Y9rq4uTk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736182261; x=1767718261; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=IhcfZmYkTYDEHHrhcjTneRESP50P2mQB95K+VuVA2j4=; b=DvJonIkq9sylD7spfGhP8cneIP3eaI1eD0pD4VVstChTKb1tObyRCB8x 8nuvGEthrI4bouTOIhaVV7A5/xynMvoC8blNcZqf6GtIsQYarU2XWGNRY 8sVvD5wXQcTlBMvOwqdWrH9wTZTWrcxtSSvQBEvdItWP665asGUxh9OXj xtb9qGQ6v3Z0eA/+s8jiT3dKU6YZwCKm4qyMO2Dz1MyDJUegN6yb6QTz5 YjQScie2lXPRNOrRUBR65SnkSoDh63nDVRc87N5BchdMfibiAbwhhbdOG 1ODMjnvddL1VBXvSr/pJq3lpfXWHAwedBmeQrOotJZsqm0JH2nC4zMpYR Q==; X-CSE-ConnectionGUID: 8R9z5G0MTHugbbQitG8wug== X-CSE-MsgGUID: NYR1HFY6QoWKHyKBHXy8eQ== X-IronPort-AV: E=McAfee;i="6700,10204,11307"; a="23938503" X-IronPort-AV: E=Sophos;i="6.12,293,1728975600"; d="scan'208";a="23938503" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2025 08:50:29 -0800 X-CSE-ConnectionGUID: IyAMlXf+QCyWgQSx2VewPw== X-CSE-MsgGUID: wOmDsHaXS8WZW6puw0XfkQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="125773724" Received: from lbogdanm-mobl3.ger.corp.intel.com (HELO [10.124.220.224]) ([10.124.220.224]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2025 08:50:27 -0800 Message-ID: <0de32bbc-66e9-4875-af87-7a2fa2e03e39@intel.com> Date: Mon, 6 Jan 2025 08:50:27 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/12] x86/mm: add INVLPGB support code To: Borislav Petkov , Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-6-riel@surriel.com> <20250102124247.GPZ3aJx8JTJa6PcaOW@fat_crate.local> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250102124247.GPZ3aJx8JTJa6PcaOW@fat_crate.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BED351C0015 X-Stat-Signature: hhtunjf1u3s1kgfmecnuhiqy4amwba8w X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736182260-386995 X-HE-Meta: U2FsdGVkX1+FFdKmy+qXj+jDLmE12FDOdWBKhLmqGyyULF+VglN6TcPXRW0RbqbGTgcOossKJY/Ei8JhWdNPhZeQclfOdL4nj1hAir4BdVOl1WCSb/CGKN3EH2MVJU/jrRvqwuNAlvlJwgYiJYtA7Ywrs7pVmQ1lrBXknWRxZqpP9hKHdT8WLnVH4wy1bkmJN802upBvRFVqr58/kTai8MaA3ODsgU5azVl3Oq8caoUid2I/ZALpQoLzK/cbb/Z7/M4sXQVzlzEWz8zVMtM1SS0pIgn4+KX022cpXPuNaz/tsGPSmxW3DSEEL0Lg2bwSQoTme3vJJC49tHB78cChsSlvlciAWOIcOWhwOzvZJ/KA+PwU1G4w8xAno5zlUlDbj9GJVgI3KTjL8vbAQcowalIJMtCurDkv9XO4u4FxvJWbpLbO34ItHkKu16LnJK3gS0yKOF3XX7NNUCX4U1P22wUOioafvS6R8eJok7e+ig5DfkDJfQqctpCrr1q4bqDBKS8V9we3aa6ebC8DmkGIREj2y5mhuvXWHq23IcVm0pBM3C5DznCJXUA3Ds4TpbqjXdlQvWEsL0Vzn1e+hmEhE3V3+YVIpafDwObkuAeOtVVNM0q0I5/IhHS8BO7rw0FUlnLKx2wK8lcgrIenZZkoIaTQhr+fDQt9+TqAI+/13GnyDPKdo0oY78TLFmHy+MJLNWxKo+kQs0nd0eMxmlIDenqQFvlWmdQk1W+uhpqE6RRyT3fcyonckKf3G0P64m+qItRidch6nz14nWeYAGIO5dwdDzlKYzr6NC7x/F+364YjKpahs6dvbMJPimNDIrju0UpfaPiXdqrAxIZZuWS3aSlLCkvnq2r8OS2O9UB7Ikcn0RTgPJWnBTE1qtV/NDlFUV1zf7Sf5pSvo/sg8rmnTK58D+ODiGNbafEtzDw9RhoJKI6iKw07eHwNuesJ9nK51AhRMlzLuC9yGEYbBo8 5tJZoZwZ mAjnp2lyfdjqMclTAwcu0/vdifOXvUlTTKut73tquNR14uSEwC9VYyvrmkKDJ2C701CE1hVBYVZ9h0Ur077Zqev/G1MXUF2wcjpR/qAV/5x+gGyRjwBgtZuO4nXIPjsjGToHNKBydOzsZfZ18IBSS692Zra1XEDdXWOK9sPBaaQmgQ/PRWTX60Ev58r56WAhwg0T3RP8Vt1hpEV/965+84wGAPzJNwnzCGAg33NvlVnt0Sev2oQS7MOO+WXHkSBs9XIBs+/DeKCOKbt76RK1dA8bIxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/2/25 04:42, Borislav Petkov wrote: >> +#define INVLPGB_VA BIT(0) >> +#define INVLPGB_PCID BIT(1) >> +#define INVLPGB_ASID BIT(2) >> +#define INVLPGB_INCLUDE_GLOBAL BIT(3) >> +#define INVLPGB_FINAL_ONLY BIT(4) >> +#define INVLPGB_INCLUDE_NESTED BIT(5) > Please add only the defines which are actually being used. Ditto for the > functions. There's some precedent for defining them all up front, like we did for invpcid_flush_*(). For INVPCID, there are four variants and two of them got used up front. But I get that it's a balancing act between having untested code that might bitrot and introducing helpers at a time when someone (Rik) is very likely to get all the variants coded up correctly. Rik, how many of these end up being used by the end of the series?