From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA33FE7718B for ; Fri, 27 Dec 2024 10:34:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 157796B007B; Fri, 27 Dec 2024 05:34:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1078D6B0082; Fri, 27 Dec 2024 05:34:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE9EF6B0083; Fri, 27 Dec 2024 05:34:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D2A356B007B for ; Fri, 27 Dec 2024 05:34:19 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 07AB446904 for ; Fri, 27 Dec 2024 10:34:19 +0000 (UTC) X-FDA: 82940378388.15.7C0E3A3 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf06.hostedemail.com (Postfix) with ESMTP id 8DD9218000E for ; Fri, 27 Dec 2024 10:33:46 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=HGDWiVz5; spf=pass (imf06.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735295607; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/DQvCiNPnnZO+rTl/hONFzvLITaJ9hLi2huHesCNJec=; b=jJc3aIo8QOjEvqsf91tV5EvmBNTZHfdl6UGCtbm6tHraQUNwSkvg37liC46o9YqDdbbQFI 3pFNcZHAqpnUht5dMkEWvmqwo446HE3fA+rMaWyX4FykrM5MkQq1qhzcrk/qbtWeMD2hSk Anz4k8FjSiMi7y40IXQ64wwD9Q1jPvs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735295607; a=rsa-sha256; cv=none; b=heP2saooDgW+gD08Bn4biJyNkWRde+irseKoxRGJTe0V5yTxbyntc/7fzYnbG1PmnMji7x ViyHDyI6WNqpGfYBFruhb2iR/4iCV6DB/k0r2L7pKbsdzkh+UupQOY3NIm+cICco2u36sI yO67K4Fd/BzR6lcbv5Uzr+r3piYVhIY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=HGDWiVz5; spf=pass (imf06.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BR85eVV003598; Fri, 27 Dec 2024 10:34:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=/DQvCi NPnnZO+rTl/hONFzvLITaJ9hLi2huHesCNJec=; b=HGDWiVz5ckd7RRPMrKP5+z Ua5fzfALPYEJ3OFf33nOqbrD2PzXLREbClFUHyNyNtoIKnUeXa+cR15xhLhERGgE YNbmKuorUeqj6K2ubl0jFzAwNzlrWYKk2+I1oIRn6q643//iuyc4B+ALGSuQzk9x Ag7PTo0civqtrg2MkoISoNHU1dykgnKpO8XUQw0FdF8u37VTmIbhK3bXck2xRfHN 9/CS5tgHK20aeQiwN1PoME3LdqHmiRlXoeOhzwQUlJeXT/4EiBJn6UlfprGRUOG7 o6oCbjLplEGd193dMLNoIntQYgfrzRVLG97dum+Ru0n++SHTLcM0JRmIe62xoM1A == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43sre2gej3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Dec 2024 10:34:14 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4BRAVldr030015; Fri, 27 Dec 2024 10:34:13 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43sre2gej1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Dec 2024 10:34:13 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BRA6CxM002062; Fri, 27 Dec 2024 10:34:13 GMT Received: from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 43pa7k58y4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Dec 2024 10:34:13 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BRAYCCd39977242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Dec 2024 10:34:12 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5405F58069; Fri, 27 Dec 2024 10:34:12 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B232858064; Fri, 27 Dec 2024 10:34:07 +0000 (GMT) Received: from [9.179.17.222] (unknown [9.179.17.222]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 27 Dec 2024 10:34:07 +0000 (GMT) Message-ID: <0dd42f11-2c2d-4fab-a115-2b0c8c69952d@linux.ibm.com> Date: Fri, 27 Dec 2024 16:04:05 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 PATCH 2/5] memory: move conditionally defined enums use inside ifdef tags To: Gregory Price , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-3-gourry@gourry.net> Content-Language: en-US From: Donet Tom In-Reply-To: <20241210213744.2968-3-gourry@gourry.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: SVWmR1vxoczy2I-GNj3wzeTYk-y4RJ7K X-Proofpoint-GUID: gL1BRGuBlCSE3Vg_5mIKJhoOV9rxR2o0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 spamscore=0 impostorscore=0 bulkscore=0 phishscore=0 clxscore=1011 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412270087 X-Rspamd-Queue-Id: 8DD9218000E X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: je95ckqhqtw79or13wxzp3f4mr9rbabr X-HE-Tag: 1735295626-200902 X-HE-Meta: U2FsdGVkX1/TikgCszwaRvhIZu1OTS8bAuwtFqbq4AVQpzTJt86Mru+aJCXrxOSp0ILTbOQ+mwK+XK9QmncDTiP3kxyvfUBxFYRO92qFlRrBM4/1f8WKHGdZ34DTjMI51ZAus9jweKXxC8ZlqDQeF8LFVgROuFOySDXJAGOig00z6c9PkSjGw317NYX8mKXKUzJMKWCPTjMGYa/3D0tTsQBaAmBEqUNKgcFX998YaOiFf8EHXOHFYtf6PFvD6Ou74ZO14cyxSxs0keRO5B9bJop1fJst2sdyQOCBb7wZMF8Pznbh+C6L2qGb1wr5RdmIdEDOciFsDlwluPyV5YrBmZU60Ecvx/MicILrRJcJY8sK8SCiTC+zfgv6dx2W3d8ZKvsSAorBIuxIWgCucYTBxr/N4NfwPpq++gTK/Axwmdq0M2u+h7ctjNdhFw38VyNGz2wfoGZaE+NuX9LTEYtW4c7Q2zvmhePiSRtw54KvqRW+s9r83MHjJHjiMya2+jz6+PKHQXMtkyErFp19YmKkqkqO1srqyWlWHiYJ/gFZQMRcOOzbJ11Bjja4bprBjD4dcfySq4N+O1wVGBRM3DS28zyUYEVXUpdtsf9D1LqTN8KGtKxsjZz1W3bs+cIVteSu/PBC8oamQnY3o1+8C5qx62QdGXUvFsyvZRPoEZClntEfWN5djvURWNT+yc/9Mv728eTgPAGEW6m2U8nP/oaQIvYV8HI95xZRp+R0+f6Af+zRX3IKD1DqfP18qZLGnJ/TuzAV0fuP83ft5+1fMSHqF0LsyFDKRzlpFI5l6kliZIvqeZYGZJya28xCdz11X9aameGT8BMr1caY34SMaru6TY27NhuPFV7WIfpd1p7LZej8yM7pCJpu+mOyOwz7Feku8AVWWjgs+4W/okIOSwWbLVcXA2u6DjanzWjAaADrIDormX/cWoXh4Gyck2eUoqgGvo3pJR05a6jo3zvz51W l9oOAF9V HGRAAFcKcNnpX80Q7/I8nNeoT6Q7MSi8PwxQB1OdmXmienCN7ARFm9O5L6hOakuZox36pm6BG6Wtdf+rMI+A4feJpJ8JftFpRwQWFbWmNZ7n1TuxaChR6jT9Fp0qrBzBJOj/KO2PZJFnpqo0l2B8PLHoS2nTu314imGg2DCJyjA754h/zReqxUNePx6CeWwNgpmSeOqfiK4N9evHjoQwddukntcU1Lk24NMy1S/hdfoihn+Y6GrMS5PxbT3wgTOEr/iDsigKUyHjDtus27t/ccfMaiv1AX0VMusXuvbPojp+hSBdWGTA/6bpE7ZufuDnNjJfXGt8GIx8lUhPNs/1lSYcQUETXN+qV/8+ILIxgQcbFuzQX6M7fzheejqQfVfva7ysH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/11/24 03:07, Gregory Price wrote: > NUMA_HINT_FAULTS and NUMA_HINT_FAULTS_LOCAL are only defined if > CONFIG_NUMA_BALANCING is defined, but are used outside the tags in > numa_migrate_check(). Fix this. > > TNF_SHARED is only used if CONFIG_NUMA_BALANCING is enabled, so > moving this line inside the ifdef is also safe - despite use of TNF_* > elsewhere in the function. TNF_* are not conditionally defined. > > Signed-off-by: Gregory Price > --- > mm/memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 83fd35c034d7..6ad7616918c4 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5573,14 +5573,14 @@ int numa_migrate_check(struct folio *folio, struct vm_fault *vmf, > /* Record the current PID acceesing VMA */ > vma_set_access_pid_bit(vma); > > - count_vm_numa_event(NUMA_HINT_FAULTS); > #ifdef CONFIG_NUMA_BALANCING IIUC,|do_huge_pmd_numa_page|() and|do_numa_page()| are executed only if |CONFIG_NUMA_BALANCING| is enabled (|pte_protnone()| and|pmd_protnone()| return 0 if|CONFIG_NUMA_BALANCING| is disabled). Given this, do we still need the|#ifdef|? > + count_vm_numa_event(NUMA_HINT_FAULTS); > count_memcg_folio_events(folio, NUMA_HINT_FAULTS, 1); > -#endif > if (folio_nid(folio) == numa_node_id()) { > count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL); > *flags |= TNF_FAULT_LOCAL; > } > +#endif > > return mpol_misplaced(folio, vmf, addr); > }