From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3632DC433EF for ; Mon, 18 Jul 2022 02:25:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 340D96B0071; Sun, 17 Jul 2022 22:25:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CA8C6B0072; Sun, 17 Jul 2022 22:25:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16A7E6B0073; Sun, 17 Jul 2022 22:25:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 03AB86B0071 for ; Sun, 17 Jul 2022 22:25:31 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BDDEE34AC9 for ; Mon, 18 Jul 2022 02:25:30 +0000 (UTC) X-FDA: 79698629220.15.D5A1EA4 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf13.hostedemail.com (Postfix) with ESMTP id CF9AE20095 for ; Mon, 18 Jul 2022 02:25:29 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LmQjJ50xvzjWww; Mon, 18 Jul 2022 10:22:44 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 18 Jul 2022 10:25:25 +0800 Subject: Re: [PATCH] mm/hugetlb: avoid corrupting page->mapping in hugetlb_mcopy_atomic_pte To: Andrew Morton , Peter Xu , Axel Rasmussen CC: , , , References: <20220712130542.18836-1-linmiaohe@huawei.com> <20220713102357.8328614813db01b569650ffd@linux-foundation.org> <20220716160629.d065828c84ad2423c10f7733@linux-foundation.org> From: Miaohe Lin Message-ID: <0dcf8902-b14a-860a-cb66-46e57b6d14a9@huawei.com> Date: Mon, 18 Jul 2022 10:25:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220716160629.d065828c84ad2423c10f7733@linux-foundation.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658111130; a=rsa-sha256; cv=none; b=f5FjjQKEXnxm1Sng90tJJW2b1xtkm/W5Rva3C/tuSx8YANqowdLxYHHbqEU00iagOBb9PR imu9ex8hFIsWgwcstRCeSt3Te72euAwwTWdJmGu2E689aSqREdhip2brQS1WR7g3Gy/zuv AKdLLaXhDsjvbiwY1uqAWgpWJYA2zYs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658111130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vjV8paoIj7Tq3EXFgztnfvSe2oBcBC4VIWqLX4FKYoY=; b=xqDGDLNOGBATTpsPE8IrDR4g81k5iyKOndokVpw50L/uvsRGUL+Cu7b3rZ/tfPyiBkEl1f xWkVLyQrYh77BXJF5K7SgzbPM9W3M+ix0EuidZ7kIjiAGjME3EWY30tJbrVOTFv2NcWBZD q6LpDOmDSb8qoHKGrr8E77vUAT+6XnY= X-Stat-Signature: b9d67qzkcqwox7fh89tmnjb8xgnyci38 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CF9AE20095 X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-HE-Tag: 1658111129-629245 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/7/17 7:06, Andrew Morton wrote: > On Thu, 14 Jul 2022 17:59:53 +0800 Miaohe Lin wrote: > >> On 2022/7/14 1:23, Andrew Morton wrote: >>> On Tue, 12 Jul 2022 21:05:42 +0800 Miaohe Lin wrote: >>> >>>> In MCOPY_ATOMIC_CONTINUE case with a non-shared VMA, pages in the page >>>> cache are installed in the ptes. But hugepage_add_new_anon_rmap is called >>>> for them mistakenly because they're not vm_shared. This will corrupt the >>>> page->mapping used by page cache code. >>> >>> Well that sounds bad. And theories on why this has gone unnoticed for >>> over a year? I assume this doesn't have coverage in our selftests? >> >> As discussed in another thread, when minor fault handling is proposed, only >> VM_SHARED vma is expected to be supported > > So... do we feel that this fix should be backported? And if so, is > there a suitable commit for the Fixes:? I tend to backport this fix. And I think the Fixes tag in this patch should be suitable, i.e. Fixes: f619147104c8 ("userfaultfd: add UFFDIO_CONTINUE ioctl"). Thanks. > . >