From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85DC5C5AD49 for ; Fri, 30 May 2025 18:34:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB9916B017A; Fri, 30 May 2025 14:34:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6A1B6B019A; Fri, 30 May 2025 14:34:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D32316B019B; Fri, 30 May 2025 14:34:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B0E746B017A for ; Fri, 30 May 2025 14:34:42 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 19430811F8 for ; Fri, 30 May 2025 18:34:42 +0000 (UTC) X-FDA: 83500425204.28.95F1F1F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id B024918000D for ; Fri, 30 May 2025 18:34:39 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jI+BR0Tx; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748630079; a=rsa-sha256; cv=none; b=uFnnoppi7b0jWupYxjesxQAEU78nkkYeRmzh/NqBTWlEPa0iN95mjVz/6UhtYd6af33Dws aWUEywhhNmiw2bH0l5cl7w5hmdPXLA9vfn6eZF1gX0y9AXf+bRy2EsockT+16maBi7zURQ JsI/koR/zZUZUhgQLy3siKMtd1WkNn4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jI+BR0Tx; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748630079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BZV+aBQAgS7/ANJw8jO7o/sxZUwh/psYla57JLFsPxM=; b=urWQFg4nb8X0npzqghSwEisR+FrNKfGbnr9ZGr8CeRjB1mS3lgGXxWdIywG/qd3L2qmru0 nxitKXLsSXn1tETuv/dWMcA6lvxT07AeodXhgtwJOd71dokmobkhsxnJX/d9B1br5/SFhs W1DwqPvupvUt9MhyTLyPyH/0UpMdJMs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748630079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BZV+aBQAgS7/ANJw8jO7o/sxZUwh/psYla57JLFsPxM=; b=jI+BR0Tx83SQZCxyqhsUuYZihreJnZLM/4X6zh7W4XLKmRNdTM8gvpMeDwJoxiDexVYxpc NyAFwjuV5pzi1TGRhjaaVSAS+0XP12oLnQeG0QIZ8Csnv2QqzVrlYgzPE88yvYE1Hm1GCd WyrHrkTgFVcgsgbtEjyk/boO++UD2jU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-630-c6sYGFmVMPKNcblOEokcPw-1; Fri, 30 May 2025 14:34:37 -0400 X-MC-Unique: c6sYGFmVMPKNcblOEokcPw-1 X-Mimecast-MFC-AGG-ID: c6sYGFmVMPKNcblOEokcPw_1748630068 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4edf5bb4dso1332674f8f.0 for ; Fri, 30 May 2025 11:34:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748630068; x=1749234868; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BZV+aBQAgS7/ANJw8jO7o/sxZUwh/psYla57JLFsPxM=; b=hyTVZMEOED7+C1DyOU6lpm42dpvtiQ4phi2Ow2sNWgEarUA+1oi1Zh0iVFPTvbKuTU RgqEKVqNEj6qmqQJPYEY20JeIHowoO4LL/xdLdInPnUXo5hskROMh5SKjfb35zwMhUPr WEsqD0VZpBb1Sq4nQVr0nWCU6SOkDVSShl1rtI4qVAIl5RI4z2JFnNis6so/wTokJRA4 CAKZgTz7np78ShNn7Amvi/SuvhBlUaMzmFdltqUA6TgsVNerdmzTs4s7bRUrGIPFGmEx AYG41QXJLeqNzNwC92uooPjAVwrDwHw6t/TGvuIaqZhJDNdpiL/prRdx4l/d7RvDYqXw fFlg== X-Forwarded-Encrypted: i=1; AJvYcCV3wLK4cqFBra5qbUW6EJtpUAIy9oaBXQqDnIFZebn4ED/qDk8TGMZDB71ys0lbovOT0FMq3dQ7HQ==@kvack.org X-Gm-Message-State: AOJu0YylNSFvMoXzfc1jiQD13qb6D/BXfCI8UmOFPzyjvREwhlHVox5z 9drXajCZt/hP4fD7rsZuCXGOrphEwyCMLbwRgwx8m329yakJaD2lEMhYEZR2tuNNDJi1DW0fplE JX1Lw/wSdVnX3X1PT/cOwlhv8EZ5Qt//69WsKUfOoZx4+1imBWgXu X-Gm-Gg: ASbGnctNs8EgZbqevcQUavNJ3YvC28SPdSvNqP9ftBQ3SG7aRd0jw7hXIVNNRI0PxYl bDKtzgfTTb6MFJ6HzmDEn5RrRE34p94Grx5CzBtJuz3Q5O/Nm/vz7VqPTdOIYhZZ9xfpzU0DnTe w39YfKVWF9ZfPe8OuPdrB3tDSa4JH+CMns5zUMiR0w713VtgUdrR2WNcIM5X+ZTreJI9/6d0NfK dHN6F4dDEBYOzJQ2jbBi7vByPxdb1WtSYNIythRTCwifq9zQnKzAhOXIVIQVT1rQSe92367FXP2 5RVRDa7OSxoZhM1GemLk/DQxfkJDZwqXOs0Dcl41hVoXxbfJSmEJWImJY9gf7+p9JfLQ3wTnxYe fhqouNhJ5EL0hCTS2MkyXJx+9TZnwSRp2dAEpGg== X-Received: by 2002:a05:6000:1887:b0:3a4:dbac:2dc1 with SMTP id ffacd0b85a97d-3a4f7ab16abmr3314066f8f.54.1748630067782; Fri, 30 May 2025 11:34:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4NVAy54+opBF8sRLwzv0VdyKtt7A/mCOnZq+cWe/C5ahGQFGETuXDqBFRVgMWhKZdHhATMw== X-Received: by 2002:a05:6000:1887:b0:3a4:dbac:2dc1 with SMTP id ffacd0b85a97d-3a4f7ab16abmr3314043f8f.54.1748630067437; Fri, 30 May 2025 11:34:27 -0700 (PDT) Received: from ?IPV6:2003:d8:2f03:5b00:f549:a879:b2d3:73ee? (p200300d82f035b00f549a879b2d373ee.dip0.t-ipconnect.de. [2003:d8:2f03:5b00:f549:a879:b2d3:73ee]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4f00a1678sm5475714f8f.99.2025.05.30.11.34.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 11:34:26 -0700 (PDT) Message-ID: <0dcec9f4-eef8-499d-a96a-dc6ab3433039@redhat.com> Date: Fri, 30 May 2025 20:34:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/mmap: Fix uprobe anon page be overwritten when expanding vma during mremap To: Oleg Nesterov Cc: Pu Lehui , lorenzo.stoakes@oracle.com, mhiramat@kernel.org, peterz@infradead.org, Liam.Howlett@oracle.com, akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pulehui@huawei.com References: <62b5ccf5-f1cd-43c2-b0bc-f542f40c5bdf@redhat.com> <13c5fe73-9e11-4465-b401-fc96a22dc5d1@redhat.com> <4cbc1e43-ea46-44de-9e2b-1c62dcd2b6d5@huaweicloud.com> <20250526154850.GA4156@redhat.com> <06bd94c0-fefe-4bdc-8483-2d9b6703c3d6@redhat.com> <57533126-eb30-4b56-bc4d-2f27514ae5ad@huaweicloud.com> <956124be-c73c-4023-9edd-25372f3f865a@huaweicloud.com> <20250530180920.GC25160@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250530180920.GC25160@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jzEh2F8AHLXmaXPU6oDDRH7p-4cLBuqRfjE28z1kBrA_1748630068 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B024918000D X-Stat-Signature: r73ysrxdyjbdu55dbke9d7gfykjk4jag X-Rspam-User: X-HE-Tag: 1748630079-630174 X-HE-Meta: U2FsdGVkX1/i2F2dsmifsk9Nj2Xk2JO9ExzLXiQUsjcc4o6mxXPd+TlYse1SjB6/z/X+GMKWfvynFnBCsfKQNim4RZLa2aasdc5/eFgcMFeCbyLhS9VgXyC8UdQY2P6yHmc5Lpucy2M/Vo1EyCA/2T13U2RkRVFA8LUYwGw/FG6BWT+mKMUcWVeM0tT5TTgOC/beS0utedCINWnTqkVw8XJzUgQ1VmurfjSm4Zg9dsaVedBtqzeXxOyCsr6PYQ40O9MQedkoeIMBzHrj98Qndnv2jDDkPpmycEoZ7PWdF1EwbhgxEoyrS4RlNMz1otEhrD/REy2jE95MAV3eWj3EpnDWFSgM92nLxImTkt01f/Mzl2f3Bn69P2qXlxf6UmeROBP4QPkKvcOamaRtB3xRUsYDGfaGuvB7LBcYUxsoLGM2M6GS+HWSRnsi2EZ2qRwMTJbed95JWqaYVmqKAxrdwFmDMMd8uC+BkLkYDZh8uEGFYJfa3WKd6NjndkfYCycDcwMyVdLfa+tVvsLw/OE8Gl7VUS/Q/C/tuv57/+3+iOXfa1KKJclWMKGnHhU167bfTB7toX8fogsQuc29jK6g/r7zrY5OAbGphqD1+zWGd5ERDd1+rxUH9Ab44KW+QXgvZQayQDhIDF9GnsyYJg3e3ztbvL3PjH6cFVF6qkxMcO1OxB7EreyIJiv4VOPEhdN7vDSxfuuqMHtp6urg1wv/nK5XoGRNDKP0VDvsBIkWV1VMI7+34gZc/rZ2kpBfI+R44gB8LJ1EHYE8o99Lo7iRMfNdh9Ve171gFtd3yoVlGR35hhacR0VSPFBGnn0vg2KPUdTpGgUeu8nGuPcDTsat8JIdbUnR/d9wmMP4hO0h+QLj/nAHomgQIMXDvNPStCcPrV2OX30U0RL0QpoNJIJcwCdCQO2Adcx7MbtdQMS00iNmHCxah43ZOdnoucfN7DijVL5JeSEQQqEnbzp8WF2 pqlyhEEb tsIrYqHFgw4D0m54bdEJtF6EZ5XZ6bE63WquYwKXmNewXWarMczxBmehFJ1/v0uH3r4dAvI7yGJ84+1tSN0ks0AdJvXw3cWgzxubaI0n3bDZL279MJ6b8rPswP+3mWUf6oTrRMC1T0ZxPmtJZTggApTJmkYCYBBKmt/5sHD0s5AKRFdutWW5H60vLhWVC9QcuXdz1z263uj32GOjEFdhfXx9RUF4Xlj5/FPTDTGhAScXADepgEZT3LReCa6v9JXfRQeyi4gjjCpmsuqkWQ/3+CoytB4RhrEawMIXIJG/vGtJfuxHkffmhalsH5E8DQOZOG8FqmWLJRIxrHMfzDNtqG3RsQt0MAgfjuhfmbVOpMDeU2gc3FCF2D/4MZco8W4e3vfjUvHodiDOZ1OOEhq0dJk3A2dRO/NK8Q3nefI34uiMloJ+BqR59UqC9TBS/eQ5ivLh7YEsIaTN/lTU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.05.25 20:09, Oleg Nesterov wrote: > Well, let me say this again ;) I can't really comment, I don't understand > this code enough. > > That said... > > On 05/30, David Hildenbrand wrote: >> >> I wonder if there might be a clean way to move the uprobe_mmap() out of >> vma_complete(). > > Me too. > > Not only the uprobe_mmap() calls in vma_complete() doesn't look right > "in general" (at least to me). > > To remind, vma_complete/uprobe_mmap/install_breakpoint is not even called > in, say, this case when VMA grows and moves. See > https://lore.kernel.org/all/20250526173845.GC4156@redhat.com/ > I guess we don't really care, but still... > > > But just in case... I agree with Lehui and Lorenzo in that we need a short > term fix, and the last patch from Lehui seems to fix the immediate problem. Oh, there was a new patch yesterday. Too bad I wasn't CCed on that. -- Cheers, David / dhildenb