From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D570CC2D0B1 for ; Fri, 6 Dec 2019 08:28:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8B08624677 for ; Fri, 6 Dec 2019 08:28:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="ru2aIusP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B08624677 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 367A06B14D7; Fri, 6 Dec 2019 03:28:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 317996B14D8; Fri, 6 Dec 2019 03:28:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DEC86B14D9; Fri, 6 Dec 2019 03:28:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id 056CD6B14D7 for ; Fri, 6 Dec 2019 03:28:45 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id A5E5652B4 for ; Fri, 6 Dec 2019 08:28:44 +0000 (UTC) X-FDA: 76234040568.29.mind49_867e4c2185250 X-HE-Tag: mind49_867e4c2185250 X-Filterd-Recvd-Size: 4410 Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Dec 2019 08:28:44 +0000 (UTC) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 06 Dec 2019 00:28:25 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 06 Dec 2019 00:28:42 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 06 Dec 2019 00:28:42 -0800 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 6 Dec 2019 08:28:42 +0000 Received: from [10.2.163.87] (10.124.1.5) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 6 Dec 2019 08:28:41 +0000 Subject: Re: [PATCH] move_pages.2: not return ENOENT if the page are already on the target nodes To: Yang Shi , , , , , CC: , , , References: <1575596090-115377-1-git-send-email-yang.shi@linux.alibaba.com> X-Nvconfidentiality: public From: John Hubbard Message-ID: <0dc96e40-5f2b-a2fe-6e5f-b6f3d5e9ebde@nvidia.com> Date: Fri, 6 Dec 2019 00:25:53 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1575596090-115377-1-git-send-email-yang.shi@linux.alibaba.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To DRHQMAIL107.nvidia.com (10.27.9.16) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1575620906; bh=1U4N9I7Sc9y0IjpHHe/ILL0my6L0bvlv/3soA/LZXBQ=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=ru2aIusPL9M9jcFeBHIHwJL3XtTEuuYrZjBbbQ3J7Cbg8Ami0xgtltwuvHSHLAYnj ufrGfv8+HhxpcBAqWuj+1diQqpDKAt6+G0arLN5UFadEBm5m3sv0FD1X3slEkcOrZC exXvz6mIgaxUz6oK/oBsVvNU4BmwWeuo6IA1/1qyCTtgtSj48AAE/T9A2raC+/quM/ Hs7+SMLGPgIjxjs6IlK58OmrEkie+Jb/C5Z5YBpdQe7YWrwmqkOdmpPaIXCUbrYcIK NKygTVKq1TqzibJgX8z16/XaOlsI8p1DHz4dWRBxr7Q3OxT2rqJoALrdAwOY0LfxFQ H2vFanrsahMdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/5/19 5:34 PM, Yang Shi wrote: > Since commit e78bbfa82624 ("mm: stop returning -ENOENT > from sys_move_pages() if nothing got migrated"), move_pages doesn't > return -ENOENT anymore if the pages are already on the target nodes, but > this change is never reflected in manpage. > > Cc: Michael Kerrisk > Cc: Christoph Lameter > Cc: John Hubbard > Cc: Michal Hocko > Cc: Qian Cai > Signed-off-by: Yang Shi > --- > man2/move_pages.2 | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/man2/move_pages.2 b/man2/move_pages.2 > index 2d96468..2a2f3cd 100644 > --- a/man2/move_pages.2 > +++ b/man2/move_pages.2 > @@ -192,9 +192,8 @@ was specified or an attempt was made to migrate pages of a kernel thread. > One of the target nodes is not online. > .TP > .B ENOENT > -No pages were found that require moving. > -All pages are either already > -on the target node, not present, had an invalid address or could not be > +No pages were found. > +All pages are either not present, had an invalid address or could not be > moved because they were mapped by multiple processes. > .TP > .B EPERM > whoa, hold on. If I'm reading through the various error paths correctly, then this code is *never* going to return ENOENT for the whole function. It can fill in that value per-page, in the status array, but that's all. Did I get that right? If so, we need to redo this part of the man page. thanks, -- John Hubbard NVIDIA