From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B513C47258 for ; Tue, 23 Jan 2024 11:46:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B869C8D0006; Tue, 23 Jan 2024 06:46:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B36B38D0001; Tue, 23 Jan 2024 06:46:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A260B8D0006; Tue, 23 Jan 2024 06:46:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 943708D0001 for ; Tue, 23 Jan 2024 06:46:51 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6BE5EA18EF for ; Tue, 23 Jan 2024 11:46:51 +0000 (UTC) X-FDA: 81710399022.18.A116094 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) by imf18.hostedemail.com (Postfix) with ESMTP id 68BD31C0002 for ; Tue, 23 Jan 2024 11:46:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ujUBXYAk; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf18.hostedemail.com: domain of sui.jingfeng@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=sui.jingfeng@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706010409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8iNYNzEMbXX7eH867vEjEN6jWmpHqLfs5hth9+WNIjA=; b=JVEPecC8zMbT0xYl3Ht9U+BtHnaCvic6+YsLd6ixmyi8sGNorHcYs5d/Um5IcoieGmz2Dc 2fh7u1kX3UX1EQ4qM4sSg+D4Nj25ZEoJz4HQJH5zCwu03G/g9ZDiQwUH7BCKxD85iuFApw o8QHf/r8FyFviMiV5tj48rLK4GBQ0KY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ujUBXYAk; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf18.hostedemail.com: domain of sui.jingfeng@linux.dev designates 95.215.58.170 as permitted sender) smtp.mailfrom=sui.jingfeng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706010409; a=rsa-sha256; cv=none; b=tJ6gvdNeU/VdlrM1Xv52P++P6Fwub/G7IcOhwgBbKC1itNfmw9Bgw6ULyJzwx4ZsC1GVbs 8kMaLKhL4fwxLrBf45PjZk44tfCZpVOfKN8iRprt/ttIFfuqw3JiqKPVOK2XTSGHsim5Bx n0or+Cdi0lSZPg59cAGjq01vzR2BCB8= Message-ID: <0dc8a682-1d6d-435e-9633-98c9d5cc9520@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1706010407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8iNYNzEMbXX7eH867vEjEN6jWmpHqLfs5hth9+WNIjA=; b=ujUBXYAkEQQWkzcnisTyl0YIx1jC+baclWANZoDdANpHjJhgsWBmbmsToyjtz8LH4zbX/L mSbjqTblSior+bsjrcAdM66ypgBol4+fRvGDwssKyA0dB0TYApz8fYyRPlBZ0o7POf57vF ArtmneLagj8pzHbB0VAnkjCXN3I90KQ= Date: Tue, 23 Jan 2024 19:46:42 +0800 MIME-Version: 1.0 Subject: Re: [linux-next:master 139/1036] drivers/gpu/drm/etnaviv/etnaviv_drv.c:614:3-14: ERROR: probable double put. (fwd) Content-Language: en-US To: Lucas Stach , Julia Lawall Cc: Linux Memory Management List , oe-kbuild-all@lists.linux.dev References: <94afe420-f3b-5620-2380-82c9c62838f0@inria.fr> <8f844ac1-eecf-4ace-854e-6d7d7aad9ad6@linux.dev> <387720feac4593ac66fac594950975a6a317da46.camel@pengutronix.de> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: <387720feac4593ac66fac594950975a6a317da46.camel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 68BD31C0002 X-Stat-Signature: m8msmxakyqwwp31kfquq1dadxfzkcr83 X-HE-Tag: 1706010409-712543 X-HE-Meta: U2FsdGVkX19XAWHwocSsMrXVkUf79iWuE4oFOwdRM8yzSDDVih708onnQvHoa5GS/tQHQQCgMjmwhA9LL8rtQCegRHbYSX8tvMSmIQmedIDOqDbMaxD/0wb54J7E8/opWT/KqJIcgAX36IYquBFfcvYfPaSnyeHjNdQIweFDc3PrrceYPMAA59ppfB/pH2mxCeyEyNr3lbDlfrJHe0G4m34Fm0ov/ejA7ydTpDL/eDC0zzUBFxtRw2jdNDnclEakbOhs+Ul4aP6fhW5wiJZf0LoGopT86GHfSBGT/25TcH0RPYwLLUutD3NqPdob2IyFK2f1sy9r6wfe2axee5MYabm8v6wh/KtnVuSnq8J3ivqCJjqdN/qnNbbk1ang/KzZcvbloc6Ge64BcOCkb8OknKijQGjauZiIunNiCsh6JJyXclcHHE33Ixk6rV3vjGO977/XpRbATxuqYM5sxuZnTXJyWZm3tTNc3z2aQ2rSQ//abLLyOOBSjvfVGgtiTaqu97KdvaaohzjKg0HVj+GqshYfCPrM+ynCO6XdF/uMmAaFxkGFAn6Xijie/3jjuu6n+CtRYgXZ7Q/oGgXcNN5jvNpVqh479hqMqfpScCKhIw5jLPs8D0wzK2I+fXIR2CuMg+UldYT8kh6ZDkv/pxXCEsygVmcCqRlJqvkhHXAe2cIcaWFoTAPAmek5KsgSHJjWKaNg7LlM+epLkavBiu8yMYInqjabnD3ShiZWISP7SQKM7861N1dXzvCJaplRM+WrLAZDWkFNjINkmBIZ+dafRu53hgNTVQUfLIynQtuTeHK4tzNkU5TN3lGfiXWmAd7QRFPrNM4wRrBBOtBmWoJzDs4fGAB71gHOP17RUiIlqwojWRliYDeiXtvueCE/c8ylBmFiVGc7GeplueZTZrXubx3iAFQ06CBkfW4jlEBWSYgQJMst41GKj9qevp4cFjk6xksm8wy4XsqxRGoPNKr 7BJCno0H jNmKauohONPd2SRp1TJPYl/gQgNZqhndJwcnysLXjd6VgpcnU9fzr47S0GYffNWidEvT+ER4QArVqcYMrIrSrBOsZiUfD2q7cMNuWqzNOwXSV7eatspx2gNcqh4YlRDCj5S9Q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On 2024/1/23 17:25, Lucas Stach wrote: > Hi Jingfeng, hi Julia, > > Am Montag, dem 22.01.2024 um 21:49 +0800 schrieb Sui JIngfeng: >> Hi, >> >> >> On 2024/1/22 20:33, Julia Lawall wrote: >>> The of_node_put on line 614 does not look useful. >> Simply delete that line would solve this problem, what do you think? >> > Yes, that looks right. As the patch was only in etnaviv/next, which is > not a stable branch I amended the patch, dropping this line. OK, Because the for_each_compatible_node() will call of_node_put() for us in the loop, Since you have deleted this line, the warning problem get solved. Thanks a lot. :-) > Regards, > Lucas >