From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Lucas Stach <l.stach@pengutronix.de>,
Julia Lawall <julia.lawall@inria.fr>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
oe-kbuild-all@lists.linux.dev
Subject: Re: [linux-next:master 139/1036] drivers/gpu/drm/etnaviv/etnaviv_drv.c:614:3-14: ERROR: probable double put. (fwd)
Date: Tue, 23 Jan 2024 19:46:42 +0800 [thread overview]
Message-ID: <0dc8a682-1d6d-435e-9633-98c9d5cc9520@linux.dev> (raw)
In-Reply-To: <387720feac4593ac66fac594950975a6a317da46.camel@pengutronix.de>
Hi,
On 2024/1/23 17:25, Lucas Stach wrote:
> Hi Jingfeng, hi Julia,
>
> Am Montag, dem 22.01.2024 um 21:49 +0800 schrieb Sui JIngfeng:
>> Hi,
>>
>>
>> On 2024/1/22 20:33, Julia Lawall wrote:
>>> The of_node_put on line 614 does not look useful.
>> Simply delete that line would solve this problem, what do you think?
>>
> Yes, that looks right. As the patch was only in etnaviv/next, which is
> not a stable branch I amended the patch, dropping this line.
OK,
Because the for_each_compatible_node() will call of_node_put() for us in the loop,
Since you have deleted this line, the warning problem get solved. Thanks a lot. :-)
> Regards,
> Lucas
>
prev parent reply other threads:[~2024-01-23 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 12:33 Julia Lawall
2024-01-22 13:38 ` Sui JIngfeng
2024-01-22 13:49 ` Sui JIngfeng
2024-01-23 9:25 ` Lucas Stach
2024-01-23 11:46 ` Sui Jingfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dc8a682-1d6d-435e-9633-98c9d5cc9520@linux.dev \
--to=sui.jingfeng@linux.dev \
--cc=julia.lawall@inria.fr \
--cc=l.stach@pengutronix.de \
--cc=linux-mm@kvack.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox