From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "mhocko@kernel.org" <mhocko@kernel.org>
Cc: "martin@lichtvoll.de" <martin@lichtvoll.de>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
"willy@infradead.org" <willy@infradead.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: Block layer use of __GFP flags
Date: Mon, 9 Apr 2018 15:03:45 +0000 [thread overview]
Message-ID: <0dc5f067247d10f7e3c60f544b2a9019c898fbad.camel@wdc.com> (raw)
In-Reply-To: <20180409090016.GA21771@dhcp22.suse.cz>
On Mon, 2018-04-09 at 11:00 +0200, Michal Hocko wrote:
> On Mon 09-04-18 04:46:22, Bart Van Assche wrote:
> [...]
> [...]
> > diff --git a/drivers/ide/ide-pm.c b/drivers/ide/ide-pm.c
> > index ad8a125defdd..3ddb464b72e6 100644
> > --- a/drivers/ide/ide-pm.c
> > +++ b/drivers/ide/ide-pm.c
> > @@ -91,7 +91,7 @@ int generic_ide_resume(struct device *dev)
> >
> > memset(&rqpm, 0, sizeof(rqpm));
> > rq = blk_get_request_flags(drive->queue, REQ_OP_DRV_IN,
> > - BLK_MQ_REQ_PREEMPT);
> > + BLK_MQ_REQ_PREEMPT, __GFP_RECLAIM);
>
> Is there any reason to use __GFP_RECLAIM directly. I guess you wanted to
> have GFP_NOIO semantic, right? So why not be explicit about that. Same
> for other instances of this flag in the patch
Hello Michal,
Thanks for the review. The use of __GFP_RECLAIM in this code (which was
called __GFP_WAIT in the past) predates the git history. In other words, it
was introduced before kernel version 2.6.12 (2005). So I'm reluctant to make
such a change in the IDE code. But I will make that change in the SCSI code.
Bart.
next prev parent reply other threads:[~2018-04-09 15:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 6:54 Matthew Wilcox
2018-04-08 16:40 ` Bart Van Assche
2018-04-08 19:08 ` Matthew Wilcox
2018-04-09 4:46 ` Bart Van Assche
2018-04-09 6:53 ` Hannes Reinecke
2018-04-09 8:26 ` Christoph Hellwig
2018-04-09 15:11 ` Matthew Wilcox
2018-04-09 15:15 ` Bart Van Assche
2018-04-09 9:00 ` Michal Hocko
2018-04-09 15:03 ` Bart Van Assche [this message]
2018-04-09 17:31 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dc5f067247d10f7e3c60f544b2a9019c898fbad.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin@lichtvoll.de \
--cc=mhocko@kernel.org \
--cc=oleksandr@natalenko.name \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox