From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7675CC001DC for ; Wed, 19 Jul 2023 08:21:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0678A900008; Wed, 19 Jul 2023 04:21:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0186E8D004B; Wed, 19 Jul 2023 04:21:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFB46900008; Wed, 19 Jul 2023 04:21:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CC0F68D004B for ; Wed, 19 Jul 2023 04:21:19 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8ED3D40175 for ; Wed, 19 Jul 2023 08:21:19 +0000 (UTC) X-FDA: 81027666678.01.C2A5AB1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 64FAF40012 for ; Wed, 19 Jul 2023 08:21:16 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H+85tU3l; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689754876; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lHNdzhJYXIyEvVVXeSxx/4ftxohEVfyVH2IVByUb0ic=; b=iBAEs/6qdELuGcFo93DT074IZFVUi4TAggeEH+hY6u0pTaSm5AGv8gmGDh8vJS8VAVCVp2 ga+tb7FpHH0bfWk5Q3norIDv+xekVx7Y3WhOvu0Ju2mYDPH1u6f1iQR9x6hJkr4x7lxDJW swDqjFRETADDQagId5EXqpBAzRCLiK8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689754876; a=rsa-sha256; cv=none; b=3EexkiSZIoyBSngpM/FIQEDXOaIVratb5M5o6+dOFs0bKy5Wfp3tDQmRJQdtIXTtex8pnd j0fwrhfIhA8bJlxLFl3NFww6uGt40RnpY+KvK12xSg6RKqAJmJK4QNFks6AmHAVYtjyxtN ZUTmgBeIqEPuZCz+DrT9xv+pEM16tEo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H+85tU3l; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689754875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lHNdzhJYXIyEvVVXeSxx/4ftxohEVfyVH2IVByUb0ic=; b=H+85tU3l/XL2ySiw1RieVnRnd6OaOXcXMdxqg8OZbdp7J3klrQm/jrs9qEseqh4gA5bo04 sIapRpQfiAJMLpDN63kSjdesp2Yq5gp+i5V8RVQd7I6RlHmIqjuEyYLzFcNKps/wIZvV+f BX1dVl8n3OyO6l0yLwelTperNImAVrQ= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-wfLai1BtPOCguwdSODOS7A-1; Wed, 19 Jul 2023 04:21:14 -0400 X-MC-Unique: wfLai1BtPOCguwdSODOS7A-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4fb76659d44so5671781e87.3 for ; Wed, 19 Jul 2023 01:21:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689754873; x=1692346873; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lHNdzhJYXIyEvVVXeSxx/4ftxohEVfyVH2IVByUb0ic=; b=jICf/CdRXIbcQjxVgRVSO4n6iikwKNIQeIK3ZOuRU/zDwTYMvxNs0PZnFSnUGhxFdY fV7EblNXORoeLc3KBsRYpy/D08BeF7RY47lOBKOrkNREAYuoYxM404SnnHBsfICLR8hB K1VDJ7tl7mDE/y42ZpSOJxgw9XinFVBE6kRf/xT2iVJl++KA4YyW+vrwzkk/DJNasjc2 DWgGk2eDLFy/ePSh9tpKfm16V0ccB193XHgiAAABxeufa/5zAMaJrn9vgMr9IZ4QfAIb gLXb0MC+A/4mye//Vzv67fZBSlBUUirT7UcBjsWZy2/LENOKKBM7tLqwxNi6/ptRMljp M13g== X-Gm-Message-State: ABy/qLaGZMWbqe0khGmOBBl24bmipGLlABYktHTwyxrT2kD9cV8Fgom+ wfdWaUifQT0uPilvqjBUd+wLjGKr3JnM2+Hdpyuybbf493sslkSGpRhPCtb75cP4KGeMPSG1P3+ w7gKNPJkeglw= X-Received: by 2002:a05:6512:750:b0:4fb:8cc0:57e3 with SMTP id c16-20020a056512075000b004fb8cc057e3mr1188133lfs.62.1689754872991; Wed, 19 Jul 2023 01:21:12 -0700 (PDT) X-Google-Smtp-Source: APBJJlFai0n0RcKXdiYpXZ+aojTS7Ksd/OHMwbJ10bIJdz+36AnhayvLRUmFZjEcfE4R/uLtmx1AWQ== X-Received: by 2002:a05:6512:750:b0:4fb:8cc0:57e3 with SMTP id c16-20020a056512075000b004fb8cc057e3mr1188110lfs.62.1689754872632; Wed, 19 Jul 2023 01:21:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:4f00:b030:1632:49f2:63? (p200300cbc74b4f00b030163249f20063.dip0.t-ipconnect.de. [2003:cb:c74b:4f00:b030:1632:49f2:63]) by smtp.gmail.com with ESMTPSA id 7-20020a05600c230700b003fba6709c68sm1048356wmo.47.2023.07.19.01.21.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 01:21:12 -0700 (PDT) Message-ID: <0dc0e6b5-4c07-2ae3-80d3-99a5386c8f7d@redhat.com> Date: Wed, 19 Jul 2023 10:21:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 4/4] perf/core: use vma_is_initial_stack() and vma_is_initial_heap() To: Kefeng Wang , Andrew Morton Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, selinux@vger.kernel.org, Peter Zijlstra , Arnaldo Carvalho de Melo References: <20230719075127.47736-1-wangkefeng.wang@huawei.com> <20230719075127.47736-5-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230719075127.47736-5-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 64FAF40012 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: q4qiahxe9mc7zmo6w4dw3ne3nowo8f5m X-HE-Tag: 1689754876-174196 X-HE-Meta: U2FsdGVkX1+hUyt00lew4MPUu51Axn4kYrpMqzvsvJhyHUIQgdI1JaBi/2lNNFWHXxq3/DA+Yx0obIpdAtNC4fOueNl9BxZfn09vANghSOPoePueQ2jTi5UPkIeWCTbHNNOjCJ9YEgywWQYXZBk+o7uiH3CqCAQ9ikCjGP4pCh9HjlDYW0xuQCqRYwmLKXmulq+4P94GmWBIYsR3Nh+iyE6gf2tMTfrCUUhKOKw7Mn6Wi7sLrbPpVYLDJCQOECarNZs+vuvQQWEipklgJuw1bKcaEMs91ooRpB8tMUpgeyg59moc/3WC55I84kfk7fVjZG2qe/iW5Yu6F3orvbjUJOGl4EZe9InUyO8eX1QU+ylUtwvpiyIXMv53DpYvMaP4rTNYBETFJRMSqxDx3jcji7ig/xUq9dazcpCA/K4HPHHo6nO/CWHO+0BgH7t7239QhvmH2u4170UduWz/0wkddP0zYoM6OayZcQ34zRFckJNTiXI4osyDDJ0C3jmqcjPvZGC3Rn1M+8AZJC2d401YCVWmwkaslN+mGvRjRSaHjP7uMtLJqPDvgQDBx1LhP7HqyqeND0e8AUV2l0+iOq+NltkeKp0jUtM19RaTU41ykhXt9+lwurmriDrj3QqBEz+VYHojKyYxYXXIwPLs3IfXKdgL86guVIBNgT1/g7mFBsBYSNHII9SzePounmtGHFEkB0V62+4LPgomag/1W4Ei9xYHGIAVtKc9cjy9eiU7EtEK/q3Vo5dsh45LGaLgzYwKKJPJj7uIfXDedyhw7ZlCYWC8BGvC7U3u0d/myI6u9gHc//Mfkw1za9FWwLXdZEC0gjpvx30jjIZ2LGF9xL+2ynbm5YGzjjMMCp2ypm1si9XAXPjiLCMyUJjbVS8wqQ0TQooLjZBUZflIA48G2WrD1CxRtu6s20Ze2jLFgCuyipDLzdFH02Pv0VRmZH3va3StWZmMw7NxqDURUQmsx3/ Yc3a+ZZT 9mSkp4VBgguDHfCfmmV992LBG1uDVIPBSr55I7hn1EdLUXtmP0x6WPkGM2tf8dqBKz7Nw5och0hTc8bDOpVK8dHlrq2lZWqL9LiiSMaNqhojXpuWWSfigX/y9L0B0ya3ihBI/LiV5mbqMKNfPLCPdnZg6yElhEoJfI1ZC+oquZmDekgLPgMx21hHhQfGNZmPv2fJpaqw+WWjXAziCjH/jP3frhmk7PddZMyxghtDjJAI5ieucTKbpL9HK3aPHeiOxmjsOcZ8/r5rN8Hkzvn/qC4ZMcljDpLCPGRDi/z44HoFIRecVevRpmB/lz8NVWspOSCOqmGWjKrtTZQx1fzOy9GV23YJ6ZzXeCKa1yqr4gWhEhP3qCNY9atcM7AmED2vj7d7WTxV1EGZdV9pfwjJOl7V4rv1EznTOHaO7QUsCwx4E6AzCT56NntPMjZVLJcLqSjQQfajRpzasM/5nwo7DnnagFQ5WBDQUe/LwwbMaJZj4dMihJdJC4R7l1GlVFo6qv198njVCOH2JElyi4pDxkUB+TjV6MTk/Sd5Le6cvkkCiMx5+0CMUaw/m4artjNfK0qfYWPjRlRay7VUJ0u8A23qv2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.07.23 09:51, Kefeng Wang wrote: > Use the helpers to simplify code, also kill unneeded goto cpy_name. > > Cc: Peter Zijlstra > Cc: Arnaldo Carvalho de Melo > Signed-off-by: Kefeng Wang > --- > kernel/events/core.c | 22 +++++++--------------- > 1 file changed, 7 insertions(+), 15 deletions(-) > > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 78ae7b6f90fd..d59f6327472f 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -8685,22 +8685,14 @@ static void perf_event_mmap_event(struct perf_mmap_event *mmap_event) > } > > name = (char *)arch_vma_name(vma); > - if (name) > - goto cpy_name; > - > - if (vma->vm_start <= vma->vm_mm->start_brk && > - vma->vm_end >= vma->vm_mm->brk) { > - name = "[heap]"; > - goto cpy_name; > + if (!name) { > + if (vma_is_initial_heap(vma)) > + name = "[heap]"; > + else if (vma_is_initial_stack(vma)) > + name = "[stack]"; > + else > + name = "//anon"; > } > - if (vma->vm_start <= vma->vm_mm->start_stack && > - vma->vm_end >= vma->vm_mm->start_stack) { > - name = "[stack]"; > - goto cpy_name; > - } > - > - name = "//anon"; > - goto cpy_name; If you're removing that goto, maybe also worth removing the goto at the end of the previous if branch. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb