From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 406D1C369DC for ; Wed, 30 Apr 2025 09:02:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 814746B00C4; Wed, 30 Apr 2025 05:02:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79CB66B00C5; Wed, 30 Apr 2025 05:02:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A28E6B00C6; Wed, 30 Apr 2025 05:02:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3411B6B00C4 for ; Wed, 30 Apr 2025 05:02:29 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D5C89BA6E5 for ; Wed, 30 Apr 2025 09:02:30 +0000 (UTC) X-FDA: 83390119260.28.3BD05AA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 465461C0003 for ; Wed, 30 Apr 2025 09:02:28 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XUbaduGj; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746003748; a=rsa-sha256; cv=none; b=vVFb3cGRaSK8iY0ceN2VEzgCFuLsD63wxqge5rkyE3I7dd0cE4aJmW8J/YPAJy76cXXhMn P8CPxZeCeBceXmmU1nJsHWwvZJi0GJ1Jq91iTSkP6foxmz+3p3QK3E9M5DrIUcEpOxxE+8 Gq5Tr7j0DPR4xkTSs1jcr1kLIISFBII= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XUbaduGj; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746003748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HlOQwhXNNGDrS3OJ/8pVFC8SE8/TT0zkRIcc+T6vAtI=; b=S2H/7b9Kij+/OUHHhpWyvPWQ7GLMEhdUWy94fLLSK8l45a8IMjsJrL+jmFDL+5U+UXqbv/ dFfskUFQ8p7EUs//GZDShjIFSarD0UFzD6hyysN1wZzty1JJQfXvIvV87+f2QPdVA0QRvr 20C3OSjto7Hn8gkngWacYv0Z0cM0w50= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746003747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HlOQwhXNNGDrS3OJ/8pVFC8SE8/TT0zkRIcc+T6vAtI=; b=XUbaduGjzAkxRXbtspHRM6b6D+mjrUbAB13dfnhQDi+rIT9u4ARupT1k6sZWRzN/zq59zT SUvpgv8ZcuKO6zZALyKuT0rVQ0BCf+rZl4b3e8PNUx0DzXI6ydoRn/RTForlzB+suKGqf8 ZkzyT4nONJUo8adeReCLZhy9lofjz7g= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-298-o87FaXn5OQmSRlOJvGdzKw-1; Wed, 30 Apr 2025 05:02:25 -0400 X-MC-Unique: o87FaXn5OQmSRlOJvGdzKw-1 X-Mimecast-MFC-AGG-ID: o87FaXn5OQmSRlOJvGdzKw_1746003745 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-39d9243b1c2so2386356f8f.2 for ; Wed, 30 Apr 2025 02:02:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746003744; x=1746608544; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HlOQwhXNNGDrS3OJ/8pVFC8SE8/TT0zkRIcc+T6vAtI=; b=s/BhDKKsQCK4h/mIlh9ue1jAtF/qoyLuAOVogJU+Kgpkqt7Pvo9nPdHs/boYIct37E LcxH9TfxyXStVpN//GeRjGc9GvmyhOdWMqpVTxw47rl20W9j+UZnj6JkGimahjotIedi ycejVvLsyszhslQU9zL+9VOOE1HWz0MNbENMtDIP+fDkue4z1ezi6V3pTn0yVTMp81Fm l7jjY6m9mLMcRzRcAnafAI3xrYrpoWVLSpU6Z6bz01mGfV8OuG2po8uRzifx5Csf7E34 hCB3o5OkU4INQZGu6zfeNQHfJXGx6dTEBfuBHPO8Z0cFAqGVz+5TO2UO/FM7VHqUz8ww kTVg== X-Forwarded-Encrypted: i=1; AJvYcCXQcD78HmyD9fe3NDaEOsxb1rVNYU2E9SAyjD/zou2k/IrvrwuLgt95Nn7pf1b/ZXB3JUrUKXISjw==@kvack.org X-Gm-Message-State: AOJu0YxB79PAIBC5A5WOJRwymZvjpuoz1XPoN9qWWv13mS2NQpWy13aJ R1Qp+avEbh/ga5fCaxWCfpVIcWaUEIIXsBzQH23vFrF8gFyHjpJRKzkR2Zu/JD0qxeq26McLUOH 5HdW9IUTzjosMmtP7MRKj+PD0l752GPur+icDdwLDqoQ/H3X4 X-Gm-Gg: ASbGncsOoAdVthnH7g24lOfstmv3VpUixzoiLW/q/BTA5hcGLfOG134xnc/wqraSVPO 0mJYgqA26SQ7XrIrzTad3G0gsI1DIsRad75n5l8Whl/r9OjJDOQ/gSb4S54yEe6JQLY3rCAmk3X 3UgWscnNFKch0GnE0q363zP2qcddwGwFodiuPCqq+3fMdQMaOWAY6ApbvTXCcAIbM25GoXagSG9 JANObFhATPr3wynf39DWYjBxlF2F7LgmrY92AzcXGc+RYgnxY0iyQ22pKEoCvy1NhN7+mpmhL3T gHFe57iHc/mzucY20KflZ9KSde+G0ETAfXu328gMm1zXkGrnKRj0h4foA71R8VY55buSqOoAxVb snodd513Z4kw5RKyRnFDdf4TW9CZV4WPkT+LzZqc= X-Received: by 2002:a05:600c:19cc:b0:43c:e7a7:1e76 with SMTP id 5b1f17b1804b1-441b2634d59mr14747695e9.1.1746003744685; Wed, 30 Apr 2025 02:02:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHPkqg071oBTCMv5yXkndW9/oYqy/4WUrpgNaM6fWdgfaRVDQrbkV4ZKrIu5wdVxfGbOISQzg== X-Received: by 2002:a05:600c:19cc:b0:43c:e7a7:1e76 with SMTP id 5b1f17b1804b1-441b2634d59mr14747405e9.1.1746003744372; Wed, 30 Apr 2025 02:02:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:a500:7f54:d66b:cf40:8ee9? (p200300cbc745a5007f54d66bcf408ee9.dip0.t-ipconnect.de. [2003:cb:c745:a500:7f54:d66b:cf40:8ee9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2ba48b0sm17027745e9.10.2025.04.30.02.02.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 02:02:23 -0700 (PDT) Message-ID: <0dbcbb75-9d5d-48ee-9bbb-02eacd856aaa@redhat.com> Date: Wed, 30 Apr 2025 11:02:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] mm,slub: Do not special case N_NORMAL nodes for slab_nodes To: Vlastimil Babka , Oscar Salvador Cc: Harry Yoo , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jonathan Cameron , linux-cxl@vger.kernel.org References: <20250408084153.255762-1-osalvador@suse.de> <20250408084153.255762-2-osalvador@suse.de> <92ff4f7f-90d2-48ab-8f7d-7fc3485276b5@redhat.com> <60ae4d6b-3ace-482b-9945-1261003f3785@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vtaqe7jv_2ODMyoSwp7euRJ5jU-n2eWjkmxhw_kUPIk_1746003745 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 465461C0003 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: rd8u6ppzcnoh8wy311psy7tf3xwz57sh X-HE-Tag: 1746003748-203896 X-HE-Meta: U2FsdGVkX192Efp+eiyysJ8J1TIOFa8H5QdSIfvHjI7hl+xxA4knHSyBxNU9JHtTznU1L5G6bTbei6XC4xd0e1gO8MNbzQBm/C4rUdAPwhX30qqU3yZTij/WKvPhK/jx3MmfNp7W3wZuqkqbS+EQm+8zVW/bvSfeTYN4tzi+ve0/5a1bJRB3XDT9n94GFFDdSBYzo9zsM2TbFyL7iOYnLUFkFVc1wfUEoL7F14LTqbpZ5WuBjaAHRTskXAWRv/qM+TDNXRyOh7NCXZBz00ViW99rV5LtQqD5BBi9oJ7RBRSFDDWC9Yf6KRWthYNer/rYU6hMxEcg+l1ZxA6A+h1il8OJ4fMw9i98cq6LwrdSN15WOdL8RhZTBTI03j+qjhx9PTztsHt0mXnLFGgptz1+bTE4AoKOXlcrIzppDinlGVgB30yR8tc0rLTqC9F4zGsz8VFLY9O6ioukWLZDKwvtn5ZiGriyP34ulF5ZCU8s+2la5Quky0qVVrFoCbSiJZ8pAxREN2XnsEd5DILgbI4yAcGz3M1lxumSGeJRZ0LBwG7H0HfxG7ykHUQfvWuMLJrOX0xjvDhm0k1lUpdvWLa922R5win4eNKZzHblG4ICFAj2zR4H1doxoQoURsiw0V5KtCfisUKbVvQ/uqGpXsKen2Wj1A7b7WQVji0rAINEMhVnNNQveXcBF2NvYHxDShoNOaS2eTfBibWzLX2ioUwyUxuStRMEbQrf+HpChYQVeJUmI43CGLDkN3N2ZSQLRL8TRqsawRyd3RmEpg9Iscn9C9yHjjstK+LAv0eS1pckKTCf11kpnYpaK3t9g6Q2df0NnB4ewM0PpM5vyi2d6zXXxfwHMbbxmrGAx2b3J+J0oDZxfRKxoYbK7nwgcQ8z3ooxYkKOsx785oTtAEHyaG1CCRE8Y+ADC3gLUTpG6jcPYNPHU1GWxLAR7Qn9BxnMEbryaGjAbA5A+0PhvfObDCM Ohpz2w03 8/g3rJ0w0wkNStiu12k7ycVMZUyPPC3q1FNjyCitx5zf/0TwZr0ElXTEv/72L7HXo8F7VWitTI/IhoGjIQUiawCX1qsTygCSLQyvflw7uZy5UbQDVlpozOVCv/4KoDhUD5lo/6LbyrSzx5CdJqKsGHYjlDfNjm7tWJdHu3K0nVJL/HpmvP5yN82hMUQGiFT2ARHjhJs26yUTB3awR9HJ6eCqfpdRCej0BRiydadik8fTQqln/hCen1jM1JEyRR0aAeTX7R6ugm/8K8bZ9lJJS/gVGe5HuWkhd37tyF194LQsJbAGFWOuBUSn1FJm6cFivjFdbp0NNuFUSYdbMivbH4gKjbpm+FsXbB98oa7L96YXwskibpkHSImjcXHOIzf213MmGh2tARwFAF6sX6UpX9Ijk4TG7j4QVRZQLFgyX+yO9EJEoeTXnCKVvxldu9QlWrzYw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.04.25 10:57, Vlastimil Babka wrote: > On 4/30/25 10:47, Oscar Salvador wrote: >> On Tue, Apr 08, 2025 at 08:18:32PM +0200, David Hildenbrand wrote: >>> We could by grabbing the mutex in MEM_GOING_ONLINE and putting it in >>> MEM_CANCEL_ONLINE / MEM_ONLINE when a node is going online. >> >> Hi guys, >> >> After a few busy days I have been revisiting this. >> >> I checked the proposal of slab_mutex spanning GOING_ONLINE <-> ONLINE, >> and I did not see any issue. >> >> The only concern I had is that we might be calling some slab function from >> {online,offline}_pages() that also takes the mutex. >> I am not aware of any though, and quickly checking did not reveal >> anything either. >> >> If there is any will be quickly revealed though :-). >> >> So, unless there is an opposition, I can move forward and see how it >> looks. >> >> Thoughts? > > I feel a bit uneasy about it, while maintaining slab_nodes doesn't seem like > a huge issue to me, so dunno. Maybe David has a better idea now :) Yeah, let's avoid the slab_mutex change for now. -- Cheers, David / dhildenb