From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52CEDC64EC4 for ; Thu, 9 Mar 2023 02:09:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81C716B007D; Wed, 8 Mar 2023 21:09:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CD2D280002; Wed, 8 Mar 2023 21:09:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 694156B0080; Wed, 8 Mar 2023 21:09:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 59CA36B007D for ; Wed, 8 Mar 2023 21:09:18 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2CC82A06B7 for ; Thu, 9 Mar 2023 02:09:18 +0000 (UTC) X-FDA: 80547727596.23.CE06C5A Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf23.hostedemail.com (Postfix) with ESMTP id 3941D140011 for ; Thu, 9 Mar 2023 02:09:15 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=dXMSkm5Q; spf=pass (imf23.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678327756; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gfu/KwFVzc/Mhm/dGygFGmdSj7EneRyv1RVogBuDfAE=; b=Si83hCWM+KDMBP+dZjSIPogasqT3Pu9zsqMvaln05nHjgRQZgMFmh8HPuSVXOc6AokATUY fYtjbGcbX0GeFKl7HiueQ+FweEVH7jITnT2I9RLrHfTtoByjvxD1QlIXZleUBOSvySD94h haqxP3IKTYLz9s5lFIYmtObNXNyMhCM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=dXMSkm5Q; spf=pass (imf23.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678327756; a=rsa-sha256; cv=none; b=BHYRq8kTJaC+/689aaD261TP0mfGL5OhajeHgzz3CMqAi4otQZs8qG4Msi+Bi32mMvqa8w CZkl6xCLiVe6OvYsGoDf/3kI2V5JEVOb0rrtQ6xRLNMxV2et7CobC1AiKHwcVU2BgTrOPz 8cfNkYF4KcnLu9qw9kk7ORw9DUPrxxI= Received: by mail-pf1-f170.google.com with SMTP id x7so591166pff.7 for ; Wed, 08 Mar 2023 18:09:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1678327754; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=gfu/KwFVzc/Mhm/dGygFGmdSj7EneRyv1RVogBuDfAE=; b=dXMSkm5QFUg2hsGRa4whtQxI5kX2Yob0l1M6NHTCTBKyk2aDxjuGjsxDmsf/VsT3yt +vBaQBn4wAy2wTV2IJXgtXZiBox6aLuDUBb9j9YM/MrO3dCXownD0aFUkxxlUjxI/QfN N50mjt9fjA9WUydgKZQqk7JZYjVsm3bYr3KZOD+9pHN6rxqTA8pS5SfyLdfBN6XV0gQ2 C0K5A8ib0AycdBrxr+2pVK008q4e4+7oWZazp9mA8kTIjvGt/efb84Ic4T0njNXzIHqX OH8bOX4H5UjfLBTC6pTO69QtOwIO/7N9nNPL9fcPBDBcIOzmk+Olb8oiKbghyJRZiLHQ Tpjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678327754; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gfu/KwFVzc/Mhm/dGygFGmdSj7EneRyv1RVogBuDfAE=; b=o/HBiSDW8k/Js+OXokLhsppfvXduH9cYThhkt8kwlv4ElZ95e2eO9DweN/IoXXdKuK r7TOJjtPCSVEUe2DThDrQUkr4Db4yF+ocH6Y29eb26nal/M7fvCVFgrKTtiP2KaRFbhl UsRGC11NpdBTE2mFzQdPeB4ZF69uAXP5bciGaDUJctqr7Xy0oCJZRlUJGFsyDZ+dKK+m xQ60lro8sMCrd5K3quKGfkXF7ym02nhrTxfe5ZK+4lNs2sVx5JT3n9zW0X7euHm/dFSR L8HiylZFJPn+PURW+hlYJAf23freRB7NNNXAgXDHDDe2NgCDgAneE57enWZQVnIAYZ52 Q4CA== X-Gm-Message-State: AO0yUKW9J7IiQnj1gtNvPTwWsmtkKzFKSaBmkFIidZgvHlZ2s9YCe9TK rO+enxpq3YSNI++UBJAOE5rc6A== X-Google-Smtp-Source: AK7set+ABtdw3r8PqslQtAfmOu77yAOxg1w+6Hbo5FZcHMgjcM9JtbFcCj6g9bdZOqW8uRINlX9Z4A== X-Received: by 2002:aa7:9ed1:0:b0:5e0:316a:1fef with SMTP id r17-20020aa79ed1000000b005e0316a1fefmr14444906pfq.15.1678327753983; Wed, 08 Mar 2023 18:09:13 -0800 (PST) Received: from [10.200.11.19] ([139.177.225.234]) by smtp.gmail.com with ESMTPSA id j19-20020a62e913000000b005ae02dc5b94sm9996356pfh.219.2023.03.08.18.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 18:09:13 -0800 (PST) Message-ID: <0db9e2b9-e5ed-e817-bd3f-9812fd914c97@bytedance.com> Date: Thu, 9 Mar 2023 10:09:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] maple_tree: Fix the error of mas->min/max in mas_skip_node() To: Andrew Morton Cc: Liam.Howlett@oracle.com, snild@sony.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, Stable@vger.kernel.org References: <20230307160340.57074-1-zhangpeng.00@bytedance.com> <20230308175552.60b3f6a3efda2289dc6c5bc9@linux-foundation.org> From: Peng Zhang In-Reply-To: <20230308175552.60b3f6a3efda2289dc6c5bc9@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: ugs14o68cknyut3a68tk1fkds8xh5nhs X-Rspam-User: X-Rspamd-Queue-Id: 3941D140011 X-Rspamd-Server: rspam06 X-HE-Tag: 1678327755-289122 X-HE-Meta: U2FsdGVkX18QaqhAlh5jEcZY7CIneHMebGlb2i/YjZABRoUqT5u0x3Dh3nvm4LFphQKFK+17nTTv9PtNk5oLsol+6Phg/ZqPOxsxBXQBoXatvx71oYBCkY9TE5a2ZLvlXGfgM/xsSxTl8M/f48Iearp/AIEwXBVYi6buDjDA5SEJLwEhUf0+nBWpy6dQuNF6OfDhmzM3LT0JQKhl5N/Qcvl7x0mgMP5UX2V3NeS0QGlPk7Gt5yecP09FPwJLhP5UwXIHB+4PzzYWskFmplikCSYb8iq+wQinhQUltvwcEPL7ucaBH/5CjN6emz/Boh7hc1II3R/ZJMWSOcK9qcFkmbrNOcPYLCPsQ2EiWAwkaUH2pz8TXz5FRVX9dweYeC1G3yLyd7fJsleTbuOh55U9DCjlp+0/Yd2Vd/6CQa0m6o2bN7eaCtkX6uH9247BzSNJ06aTZGB1E7WwLA4gbbOF/8hwnfz+UUYMZy/oZGHxB5wQC06A1nX/PJuoXAFvdA7YcZE5HbXK5Kr6J9wRGXTf3V4mPz4nlvUC15Z+kyzou/wzO2AWnTGMNFVfBlBkDnKOfLhMnysmyZyrPpGMtSdqi61EGviwxnkr5LQdhXH2LIRXgiS08eGf7W+lQGJREiZ2LCCULBezcKkdIM8vdM0AbQf7nR75T227Nq3Ks59Ty6YTh31UUrMizSLqVyH7hbZQTk4SPHPa/n+jB2dAOq6l9fufYe34svtE4oSrbmhEgQqaRyyNfEr8TsK60D6zl0b1lTJHt6yRGLaYinMJDdfjrfr4Uy2hMTS29Jn8tKIRG37vo3v6MUK/2VjfmqMvy/jwZKgjjWAkC9lEPWvVyie2uQg08KWeXBGl7QeZyN/pfXkr6KXlmW+c2i/Q0IU5ZDutSnsVsBJTzquVVS/zop0wtQ+MWM9Is42RlX8Mldx0teb+3o/FflQMFZ1FQDztJ/ukgHfKVHtra8Q//IIuTzP 62bMlJQt 4o5YW1HsE3mnCMMjnNvTaXH2EQIQTuDBDM+/sfu9YtjGgXE+LIj/jbmJDsAs8BPlP3S0ETxOUmZkytOfji0kEOvXN0ui6H/HTlEhkh8sC2RE3wwG4O6o/qE/RsNn2QF01KpUGX7eKXzcPuBIisnbWQD5j+k1SAiL84pp7guYpPjUeXqE0vFqmSh7eWY4gKTob4QqOzMq5V2aB6T8NNRa+gsnfBbOMOzekGZ7Iww6Gp0Nub0earDRyq3H5lQW9UGB2UGtboxjb4adpzvtXALBJieDhTJvMeI+cx35wLvFh7K/0CO9xPUVtuOsWZTCYV9wqOpJBzstVnlW4oQJASry5ZYvSH9XOIzI8vByZjXaiAVtX2wCFt0V/sJHIQv7rTLVu/WaDlI7EUNnDtRZbFDXYR40xalSjrJT4VKFWKVpc1y+lNDD83smJT0dxi+4hwqnuH+igqaPX1AvL07ShSKw0LWzx01MahDxDHAce01YPZRgBHReZixcXgbsIlcJHQc8fkYpCd2x9y63hnjRsjQ1+NW6qwaRQQM6O0bttmYlWESKsbI0CFWAu6KcU5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000198, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/3/9 09:55, Andrew Morton 写道: > On Wed, 8 Mar 2023 00:03:40 +0800 Peng Zhang wrote: > >> The assignment of mas->min and mas->max is wrong. mas->min and mas->max >> should represent the range of the current node. After mas_ascend() >> returns, mas-min and mas->max already represent the range of the current >> node, so we should delete these assignments of mas->min and mas->max. >> > Please fully describe the user-visible effects of the flaw, especially > when proposing a -stable backport. > The fixes made by this patch have been included in https://lore.kernel.org/lkml/20230307180247.2220303-2-Liam.Howlett@oracle.com/, so please don't pay attention.