From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mike.kravetz@oracle.com, catalin.marinas@arm.com,
will@kernel.org, songmuchun@bytedance.com,
tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, ysato@users.osdn.me, dalias@libc.org,
davem@davemloft.net, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 0/3] Fix CONT-PTE/PMD size hugetlb issue when unmapping or migrating
Date: Tue, 10 May 2022 12:26:32 +0800 [thread overview]
Message-ID: <0db300f4-8a91-b330-5c6f-bbc63cf2f151@linux.alibaba.com> (raw)
In-Reply-To: <20220509210404.6a43aff15d0d6b3af0741001@linux-foundation.org>
On 5/10/2022 12:04 PM, Andrew Morton wrote:
> On Tue, 10 May 2022 11:45:57 +0800 Baolin Wang <baolin.wang@linux.alibaba.com> wrote:
>
>> Hi,
>>
>> Now migrating a hugetlb page or unmapping a poisoned hugetlb page, we'll
>> use ptep_clear_flush() and set_pte_at() to nuke the page table entry
>> and remap it, and this is incorrect for CONT-PTE or CONT-PMD size hugetlb
>> page,
>
> It would be helpful to describe why it's wrong. Something like "should
> use huge_ptep_clear_flush() and huge_ptep_clear_flush() for this
> purpose"?
Sorry for the confusing description. I described the problem explicitly
in each patch's commit message.
https://lore.kernel.org/all/ea5abf529f0997b5430961012bfda6166c1efc8c.1652147571.git.baolin.wang@linux.alibaba.com/
https://lore.kernel.org/all/730ea4b6d292f32fb10b7a4e87dad49b0eb30474.1652147571.git.baolin.wang@linux.alibaba.com/
>
>> which will cause potential data consistent issue. This patch set
>> will change to use hugetlb related APIs to fix this issue, please find
>> details in each patch. Thanks.
>
> Is a cc:stable needed here? And are we able to identify a target for a
> Fixes: tag?
I think need a cc:stable tag, however I am not sure the target fixes
tag, since we should trace back to the introduction of CONT-PTE/PMD
hugetlb? 66b3923a1a0f ("arm64: hugetlb: add support for PTE contiguous bit")
prev parent reply other threads:[~2022-05-10 4:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 3:45 Baolin Wang
2022-05-10 3:45 ` [PATCH v3 1/3] mm: change huge_ptep_clear_flush() to return the original pte Baolin Wang
2022-05-10 3:45 ` [PATCH v3 2/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when migration Baolin Wang
2022-05-10 23:17 ` Andrew Morton
2022-05-10 23:28 ` Andrew Morton
2022-05-11 3:59 ` Baolin Wang
2022-05-10 3:46 ` [PATCH v3 3/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when unmapping Baolin Wang
2022-05-10 4:04 ` [PATCH v3 0/3] Fix CONT-PTE/PMD size hugetlb issue when unmapping or migrating Andrew Morton
2022-05-10 4:26 ` Baolin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0db300f4-8a91-b330-5c6f-bbc63cf2f151@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@linux.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mike.kravetz@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=songmuchun@bytedance.com \
--cc=sparclinux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
--cc=ysato@users.osdn.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox