From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C5E9C63798 for ; Thu, 26 Nov 2020 20:14:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6A0320678 for ; Thu, 26 Nov 2020 20:14:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6A0320678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 08BA66B005D; Thu, 26 Nov 2020 15:14:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 039AE6B0070; Thu, 26 Nov 2020 15:14:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6D6B6B0071; Thu, 26 Nov 2020 15:14:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0027.hostedemail.com [216.40.44.27]) by kanga.kvack.org (Postfix) with ESMTP id D0B876B005D for ; Thu, 26 Nov 2020 15:14:46 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8D0A4181AEF1D for ; Thu, 26 Nov 2020 20:14:46 +0000 (UTC) X-FDA: 77527672572.03.sheep81_500b3b327382 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 694EB28A4E8 for ; Thu, 26 Nov 2020 20:14:46 +0000 (UTC) X-HE-Tag: sheep81_500b3b327382 X-Filterd-Recvd-Size: 3141 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Thu, 26 Nov 2020 20:14:45 +0000 (UTC) Received: from imladris.surriel.com ([96.67.55.152]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kiNf1-0007dD-UQ; Thu, 26 Nov 2020 15:14:35 -0500 Message-ID: <0db03554214e8a84c890a03ff6502e3c75db7c56.camel@surriel.com> Subject: Re: [PATCH 3/3] mm,thp,shmem: make khugepaged obey tmpfs mount flags From: Rik van Riel To: Vlastimil Babka , hughd@google.com Cc: xuyu@linux.alibaba.com, akpm@linux-foundation.org, mgorman@suse.de, aarcange@redhat.com, willy@infradead.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, linux-mm@kvack.org, mhocko@suse.com Date: Thu, 26 Nov 2020 15:14:34 -0500 In-Reply-To: References: <20201124194925.623931-1-riel@surriel.com> <20201124194925.623931-4-riel@surriel.com> <8f2428a049f2c29f092782699bcb3af76bf72b6a.camel@surriel.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-Iko6vb8mwgrbi/3mSMUt" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=-Iko6vb8mwgrbi/3mSMUt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2020-11-26 at 20:42 +0100, Vlastimil Babka wrote: > On 11/26/20 7:14 PM, Rik van Riel wrote: > > On Thu, 2020-11-26 at 18:18 +0100, Vlastimil Babka wrote: > > >=20 > > This patch makes khugepaged treat the mount options > > and/or > > sysfs flag as enabling collapsing of huge pages in case > > enabled =3D [always] for regular THPs. > >=20 > > Should I send another patch on top > > of this that causes > > khugepaged to be enabled when regular THPs are disabled, > > but shmem THPs are enabled in any way? >=20 > I think it would make sense. Although it might involve counting > thp-enabled shmem mounts and only run khugepaged when there are >0 of > them. That seems feasible. I can do that as a follow-up 4/3 patch after the Thanksgiving weekend :) --=20 All Rights Reversed. --=-Iko6vb8mwgrbi/3mSMUt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAl/ADKoACgkQznnekoTE 3oNeeggAtfMYAJ9ersho1Vt9x7gbzcYm5Hu/TcvWCZFOppy2qXS5kdq+7X+QTKaW XUdI72CexjKGTZ8ZnLP5qb+LSUZ7JTJkve86wXiG+cFCoN416qFwpq796hpMBfRe 1JJCn6WHyU89o4bMknSxrQUCZ3NVFZNDI/noBgJ/cdlYh6Y/yL6UwnS4zuX2hCIq 2yliRmHApgXBA8kGyVrcxNtQldSynxEt/BESel2VkgbX2HUwEUNnQopECukFYsjv AeaNYNUhKaN/NI5G73JEqCGBKNr6kfLuZPNgq/HqraLKTmnkDN5Zll4dCdHj8u3x iGTzJWNjzdLqxMHM2kWmHX/hk/mOKA== =wldL -----END PGP SIGNATURE----- --=-Iko6vb8mwgrbi/3mSMUt--