From: Mike Kravetz <mike.kravetz@oracle.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
syzbot <syzbot+57876cfc2dca0c6b2e6a@syzkaller.appspotmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] BUG: unable to handle kernel paging request in alloc_huge_page
Date: Mon, 16 Aug 2021 10:00:35 -0700 [thread overview]
Message-ID: <0dab09ed-2277-bd7e-42d1-1fee3a3e7947@oracle.com> (raw)
In-Reply-To: <CACT4Y+aEo5qWg0CmjUQsi3UXwmiCwmK93XUnt+DfRUtD2YLTmg@mail.gmail.com>
On 8/16/21 12:47 AM, Dmitry Vyukov wrote:
> On Sun, 15 Aug 2021 at 20:17, Mike Kravetz <mike.kravetz@oracle.com> wrote:
>>
>> On 8/14/21 4:24 PM, Matthew Wilcox wrote:
>>> On Sat, Aug 14, 2021 at 03:06:52PM -0700, Andrew Morton wrote:
>>>> On Sat, 14 Aug 2021 04:07:23 -0700 syzbot <syzbot+57876cfc2dca0c6b2e6a@syzkaller.appspotmail.com> wrote:
>>>>> HEAD commit: 92d00774360d Add linux-next specific files for 20210810
>>>>> RIP: 0010:__list_add include/linux/list.h:71 [inline]
>>>>> RIP: 0010:list_add include/linux/list.h:86 [inline]
>>>>> RIP: 0010:alloc_huge_page+0xdcb/0x11b0 mm/hugetlb.c:2821
>>>>
>>>> That appears to be
>>>>
>>>> list_add(&page->lru, &h->hugepage_activelist);
>>>>
>>>> I'm suspecting Mike's surplus page changes?
>>>
>>> Is this not the same as
>>> https://lore.kernel.org/linux-mm/846c4502-3332-0d25-87f5-cb3b71afc38f@quicinc.com/
>>> which is already patched in your tree?
>>
>> Yes, I believe it is the same, and already fixed. RCX: fffffffffffffffc
>> makes me 99.9% confident.
>
> Let's tell syzbot about the fix:
>
> #syz fix:
> mm/hugetlb: Initialize page to NULL in alloc_buddy_huge_page_with_mpol()
>
Thanks!
I verified and removed my .01% of doubt.
--
Mike Kravetz
prev parent reply other threads:[~2021-08-16 17:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 11:07 syzbot
2021-08-14 22:06 ` Andrew Morton
2021-08-14 23:24 ` Matthew Wilcox
2021-08-15 18:17 ` Mike Kravetz
2021-08-16 7:47 ` Dmitry Vyukov
2021-08-16 17:00 ` Mike Kravetz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dab09ed-2277-bd7e-42d1-1fee3a3e7947@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzbot+57876cfc2dca0c6b2e6a@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox