From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1904ECE7A86 for ; Fri, 22 Sep 2023 20:19:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20CBD6B030A; Fri, 22 Sep 2023 16:19:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BC226B030B; Fri, 22 Sep 2023 16:19:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 084AB6B030C; Fri, 22 Sep 2023 16:19:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ED8526B030A for ; Fri, 22 Sep 2023 16:19:48 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C54F381189 for ; Fri, 22 Sep 2023 20:19:48 +0000 (UTC) X-FDA: 81265349256.12.7B9130A Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf22.hostedemail.com (Postfix) with ESMTP id F2E89C0025 for ; Fri, 22 Sep 2023 20:19:46 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iiAAYzNG; spf=pass (imf22.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695413987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=koDz7uR4JuD5CtafYggyuJ5hDx6OJdYJKuUjsBOIOJw=; b=EpdYTSQHV+E1zSyZ2HsAU0lItlc1WzTvb8wK7ZSlb9wgwdyB7AkIX1CtgOiXmiAns8lX9w vcS+vmDCE24foe72BnLJQFJglKXjXJHTDBK5m78emMsb4VjvhjeZCuhQOKWsVXO+QUqwfO 791p2/rV3XIhoBUr6aR+uu1OdPHCXtQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iiAAYzNG; spf=pass (imf22.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695413987; a=rsa-sha256; cv=none; b=IXWTNRXxtxwYH7xbuT+AOm9QWoDwhAsG0y4tOPRvEx01hpv/3pyW5mLMB+e6Mf2DVEYNou d069QNSISc+JBlE8N0pkJ3CzSv/gH77ytEp/JhECpqXj/Q64/VF43maCJQzr6FWlsemG0x YN4s0IKht3B1qGNrG9gMGKZ16S4x71k= Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-405361bb94eso25087195e9.0 for ; Fri, 22 Sep 2023 13:19:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695413985; x=1696018785; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=koDz7uR4JuD5CtafYggyuJ5hDx6OJdYJKuUjsBOIOJw=; b=iiAAYzNGh8X9FfEo9y0Dh0N+nIfNdfn5JlAUWt2Tdd0f8hMynZsgjlf/kSjAHS/Csk QN2EQGj7FOJ+FC1QILUL1Ji1BUp+ivVJGrsQ9MytR0cYFlRjlpRQH4Bhll0vybwDTr0n vntSNwgy62U8BP05dOUkQJA4s/CsK78iVbwRm3p4Jjs/zIAB6v8qMl4RFUAecZMLFOIS ugOFxrwLCPzfh1yME+i1/hGkhQ/09OwxhQ5XUY1JvtyG+KeOBhQY0kq4ZDTpn8CQ4EPW z061WnQi/8CEjbX9yxhaFwIx/kVJ+mne4yLTzO9DXb8e/gDm7WQmBK44OcB+hkHfCOYx avcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695413985; x=1696018785; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=koDz7uR4JuD5CtafYggyuJ5hDx6OJdYJKuUjsBOIOJw=; b=caEPYRpEt05ql3Gtr3rb8LuRd4fxjGEYjGH7+v/QJDitVTH+QUqGt3gzdqZicG6HS0 C/fI8qU38tzUEPav2HBPXmZsKMk1ZYdD0GOTLvR83bswDZYEyKNgrZI8eJso1+MTlXHu ZxUryQU+OfqE1NTTfI3unx6+HfwlRbfWW3Zl+5W3eN3DDTwkwWmvRXDg7q0iDZBNVQRt Z3kz4uoI9msthrff3DtTKg0E2vv1Zr3iv9cxL6sLoaFyWHy5WjjxbGDccSwe6KN684mB 7+I6lVmWThHTIgkReZphLH2YBElbHWlgS9kBtChOuTE8yVR6ZIZrBum+QyHzf52FUT5S ZmDA== X-Gm-Message-State: AOJu0YyuspF95iM9GD6hAk0uCN72NVzueya/2YQ1+1T7zefRIuwcVtKr pPrHdM7ObjSQprh8l6roGM4= X-Google-Smtp-Source: AGHT+IHF2VxgMhTbLhU8jECNFsONsbRaa3casHYCM1ms7rtOSYqYmRW0rTVLX/PPVIoZjZiCUeQnfw== X-Received: by 2002:a7b:c3cc:0:b0:400:419c:bbde with SMTP id t12-20020a7bc3cc000000b00400419cbbdemr320765wmj.18.1695413985146; Fri, 22 Sep 2023 13:19:45 -0700 (PDT) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id r5-20020a05600c320500b003fc0505be19sm259460wmp.37.2023.09.22.13.19.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 13:19:44 -0700 (PDT) Date: Fri, 22 Sep 2023 21:19:43 +0100 From: Lorenzo Stoakes To: Peter Zijlstra Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, acme@kernel.org, urezki@gmail.com, hch@infradead.org Subject: Re: [RFC PATCH 1/4] perf: Convert perf_mmap_(alloc,free)_page to folios Message-ID: <0d8c508d-91c5-435e-9880-7eedebce2219@lucifer.local> References: <20230821202016.2910321-1-willy@infradead.org> <20230821202016.2910321-2-willy@infradead.org> <78cc53f6-3828-4802-afc5-abb71dc59627@lucifer.local> <20230913133105.GF22758@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230913133105.GF22758@noisy.programming.kicks-ass.net> X-Rspamd-Queue-Id: F2E89C0025 X-Rspam-User: X-Stat-Signature: ewzygurmm7t7japigty3siaqmyjmqwu3 X-Rspamd-Server: rspam01 X-HE-Tag: 1695413986-522194 X-HE-Meta: U2FsdGVkX1+fT2rM8rFky7JbBCOUMKTCoADzmUUHBnwAUL84bn9sWkGha4rQs8ycvGPeA84g+E9dcA0HBecBJjoysw+EPQcGEZ4xAqJovr+hQvvK84ryEmlXCwhAB4FR8VWRBWxrge4CZUKvBE5NNDw43GRwZrM3nicj9GSqOKcX6GgSjFI3JHYnzyrJt5zz/BLoIKnq99LzvpnMbsLec+w5QvasEiC1SzwsLDpk4LH2ZLSkE65RZFJO+/n4iLZDkIQFpN9VYdslrWme2uDIzftzIcDGfl0yLfjqKI469inW/zgSZyAxblpZx70wI59OUTo9xJoUzsaXjlWw5moOjZxdacn3Xbw9FC3KrlDd/9t0dWhjNKgH91cJyWNvziEpzehTnGTfeneRVxzt4fEUH/AYxf3j7/XLFv57bkiAf3bACQXZaHe3g0RFrUhQ/LsFvw2MoAT+RH8a26vk72zFz4GITBX+nDeF8M7arag6H0XqMvMhGry30hSP1UgrTltOCfHKl2d1Dw3qsIiD4VjPDD+yc2VnPZ2aLd7Js3JtJ5TH5Cdm9fGE8DJ2+U5pyjlB7UCmoRe+37MMrrshrytrycD3LjFqZaEOTFzVwZC8wzFNsHZMJ+85KLSUL+nfh4bwQNJvRtJStS89Ues4IsCfKpCh6RJxl/c/58sldLTcDBc5FE0UzuH8ERcx7tlfd/TKdUbnGffXtmBX/dQdCYOYr7augmWG7l6EoSDOpNCsqF2m+DiwGqaBvBG1dlq4pIoWnyMiAx+lIiKNK1BMIGxnuLqOJ9cyEMY0cVqAl6MI1wgOTIR5B5VttE761yJBLtnMnh+g/zv5PONMESWjjLAURqzMppTG2hRZdreDzAPV8OHk8uZ0l7uFxEGwfSIj603gJ+CmSUXdVgF9VMLlFm4lJLPWXGhh/LQCMIjawHZ1PZ8v5cVM8ijJZ5dx+y53rI9yWcuiomIFrQyD4HaYZct xIgVfQ4G 4EXVdcetpQ6TH0xf4S2xeZ7f5kcTMrufa0QgugmeIcCRzFuJV7+p2ae+Ni1KQH5bFigNOD1bbQrBPy+8nxnj5Ve+yagkfznf8cA8A2P6p0XJ2PTnAVTcqFF0jHj02KTIMv+AceglndxvRkIzGQQM61RVPmXkgKM66tPwlGu6z3iSStyfer8PE7qLPXm6+gCMmIi6x6nm4A5ym3Ysv0H1ec4VCNiDxYcJwbG1/GXwtYHSGpXrVYr0xMXgbUoloakjfID4Da4jjZcUq88a78GoN+/tFfJ/7sG/+FBpcDoo9r8z3SbOMtd0seN52hKWf/6rm6pqXn+YZuWFBR6rXXvv8mtIccQpnXQFYyIIUs6J6AIi0C+rtsf8Xsbb0nWCJxZY8INHQzeKdqf5SwlzOiCbDKpyOdD+YoIAQxi+6um+GKUGwZrq+ef0ITnfIWxzQts1s5Li7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 13, 2023 at 03:31:05PM +0200, Peter Zijlstra wrote: > On Sun, Aug 27, 2023 at 08:33:39AM +0100, Lorenzo Stoakes wrote: > > > > @@ -785,25 +785,23 @@ __perf_mmap_to_page(struct perf_buffer *rb, unsigned long pgoff) > > > return virt_to_page(rb->data_pages[pgoff - 1]); > > > } > > > > > > -static void *perf_mmap_alloc_page(int cpu) > > > +static void *perf_mmap_alloc_page(int node) > > > > Nitty point but since we're dealing with folios here maybe rename to > > perf_mmap_alloc_folio()? > > Since it's an explicit order-0 allocation, does that really make sense? > True, it does ultimately yield a single page and doesn't reference its metadata so it's not the end of the world to keep it as-is (it was very nitty after all!) > > > { > > > - struct page *page; > > > - int node; > > > + struct folio *folio; > > > > > > - node = (cpu == -1) ? cpu : cpu_to_node(cpu); > > > - page = alloc_pages_node(node, GFP_KERNEL | __GFP_ZERO, 0); > > > - if (!page) > > > + folio = __folio_alloc_node(GFP_KERNEL | __GFP_ZERO, 0, node); > > > + if (!folio) > > > return NULL; > > > > > > - return page_address(page); > > > + return folio_address(folio); > > > } >