On Thu, 2025-04-03 at 17:13 +0300, Mike Rapoport wrote:
>  
> > static inline bool first_valid_pfn(unsigned long *p_pfn)
> > {
> >  	unsigned long pfn = *p_pfn;
> >  	unsigned long nr = pfn_to_section_nr(pfn);
> >  	struct mem_section *ms;
> > 
> >  	rcu_read_lock_sched();
> > 
> >  	while (nr <= __highest_present_section_nr) {
> >  		ms = __pfn_to_section(pfn);
> 
> Maybe move the declaration here:
> 
>  	struct mem_section *ms = __pfn_to_section(pfn);

Ack.

https://git.infradead.org/users/dwmw2/linux.git/shortlog/refs/heads/for_each_valid_pfn