From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A4E6C25B78 for ; Tue, 4 Jun 2024 13:47:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E559C6B0096; Tue, 4 Jun 2024 09:47:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E052D6B0099; Tue, 4 Jun 2024 09:47:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA5696B009A; Tue, 4 Jun 2024 09:47:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ADF546B0096 for ; Tue, 4 Jun 2024 09:47:17 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 63CC71A06F6 for ; Tue, 4 Jun 2024 13:47:17 +0000 (UTC) X-FDA: 82193332914.01.234B3B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 303761C0005 for ; Tue, 4 Jun 2024 13:47:15 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="iwthIR7/"; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717508835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yMbmCAiowVSKw7W9moNE/x2fGNsBHZfDEwu/zot2o7c=; b=kPNHbPJ+KCBkzx3R7xlS7JjxLOkb/kJ6MNwwc8j8DzwzPG+Ak8HGq5cY+fUVFu3SQ/i2Ul LA0qRbAtXOn4EhvE9IxEu8clnmGZn6NlKrSj+MXcQ/XiMsXITmk9rvmbEUSMW3q74p6954 oSgoEVNhKCnA5830Alhi2d4HuFQDpR8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717508835; a=rsa-sha256; cv=none; b=waQYYas+zBASuvM7k/hb2OSqYgA5soJ9EP63REOdZ2ydLW0E4g/ePbVylWXBiaQzbPvmw0 SRjPDoPkwnsY5mRQBRN0UIlwCju9rU757VaV/oyhBZaW1VTNF6/o2W6izy2Nk3rd5/4Yxt F8tDsTCMOwmoOPyx+c01WhtPhC0CknQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="iwthIR7/"; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717508834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yMbmCAiowVSKw7W9moNE/x2fGNsBHZfDEwu/zot2o7c=; b=iwthIR7/TRufG0VY8RATmHLd94ItOOUMfZStAdfg8p7cotX8riwdjq1Sx1PcfRW/C5gF5r axmb2R40r+HJRMVsklGR/PG+G2bunirxEwzqiq4q6cX4DuEFzorO7dMmifRzLgxbXH7TN2 AEc9UNIpaPx/l6q5gdiQhqcHPhTr9eQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-gmVNZ9f6NfyqPkDZe_BsTQ-1; Tue, 04 Jun 2024 09:47:12 -0400 X-MC-Unique: gmVNZ9f6NfyqPkDZe_BsTQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4212a3dd9b6so26168835e9.3 for ; Tue, 04 Jun 2024 06:47:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717508831; x=1718113631; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yMbmCAiowVSKw7W9moNE/x2fGNsBHZfDEwu/zot2o7c=; b=CkauRV1B8k1C44Os+u5tYX5x0FY7mwfrPEhAEtjpIbCET7wqAiBOBk8nprXdqBbOSF YNBOnSsyxpCbXvi70ZR6sDasprLtuxBZAqJrfV79n4fF5cvAJoh//c0fIv7Oef9LOEPd EkA4dQcva4FnuC9M/yH1tsO0FdeN+Ep8hMmt+NV9+BYGgmSbUzmBA1J9M1TkEwk3Kx68 AKZio3mq/7pIapyi3ZKSR+Bh+bWYwi6OXj/Ql0yPwe5ey46bt626o3m3nW7YZSiOSZ0D V/kb/DII9+91RPdNLajYhdIZ+13tt1Srnywr7U9GkDqO+clubYcKMvBz2PgRlUHo/FeJ JH5w== X-Gm-Message-State: AOJu0Yy1ofOhrJrKpwr3dXqSV84/15d/ozTn7JOcOYELYMXWzkEAJNMF ZBhJH69fsSrbgDUwbkBmSiWN/XtWRiizPSHg3YLl/4NoFMJJRJIjgt+XE9Xx6lUQ3QlOLJGhwgW HwR7XsYsy7T+MoFs2hNyGxJG2eX9ds60onDHwjnV/j9ujkJygc3jcXXkJ X-Received: by 2002:a05:600c:3152:b0:421:794:9630 with SMTP id 5b1f17b1804b1-4212e0499d9mr88315335e9.9.1717508831028; Tue, 04 Jun 2024 06:47:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGpw168oErqt3u5yrQSWRtEhAJ44WH+7QdOvwB21PWxv3a6Z1jPfpU0r+q9XLflWsAy8ooTQ== X-Received: by 2002:a05:600c:3152:b0:421:794:9630 with SMTP id 5b1f17b1804b1-4212e0499d9mr88315135e9.9.1717508830619; Tue, 04 Jun 2024 06:47:10 -0700 (PDT) Received: from ?IPV6:2003:cb:c73a:3a00:a025:9b06:549e:c16b? (p200300cbc73a3a00a0259b06549ec16b.dip0.t-ipconnect.de. [2003:cb:c73a:3a00:a025:9b06:549e:c16b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42136e0d9fbsm113769835e9.28.2024.06.04.06.47.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 06:47:10 -0700 (PDT) Message-ID: <0d7a4405-9a2e-4bd1-ba89-a31486155233@redhat.com> Date: Tue, 4 Jun 2024 15:47:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/gup: don't check page lru flag before draining it To: yangge1116@126.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn References: <1717498121-20926-1-git-send-email-yangge1116@126.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1717498121-20926-1-git-send-email-yangge1116@126.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 303761C0005 X-Rspam-User: X-Stat-Signature: stxi1s8ijybo1azseafy8o8ebx3irsd1 X-HE-Tag: 1717508835-345575 X-HE-Meta: U2FsdGVkX1/jOjh9gFG34lfYgJRF4z5wm96eb3lP83zGK9D4Okze8YZsf1i9f6J9kwhaRgMUSEerFREK+0zQS9Nqt7bnZT4leHf6uF3JHOQUAZp4lis3qFG7OKJChFb0UtfAKewLj84mbhhuIgLYTjPDt9BopVGbhj109vJP55OYVx1NzZyM36b46vp+96U23wIdBNF2V3QC/SSm8hmAdUBnIk/dPZmQnpO+qU0vSFuHeH1iHZ4GVnFnzUiCjH25YhiLe/Taa2mOSDZAyiTaYdSas78GBWjZcbA9CR8H4QrmgXSdzXbD6Uhs7pJ0nQY+RyFCt8qoCcrktC+qEhIdjzYvC6r9tJ0t3KNjoF6sQJnDl5cE/wE3rHKQlEP1Dx+5nCR2QQaXhsVjpfMT0NWDAnqEB8E9+YOO5GF/thQ5oQSmGrnI+VIcd+AnmACHfHUK/f5crKuDf6iGOezb95MnUICoAeE+TRyyqd1GBJKpJwe0arualh7qoTMsaA8/lY3q4/Jvf8RCSE2wjbyAIg49Yd7N6ihQc7ucx0xB6anUw4TxbprqZjtOb+t+AO/Z8JeSBOHyPbtKomMHxff3hxo8C1p9plZK+e1dYc4+YDMDjSx96HFj4+3sy1jUEsWAYCTeMMKyd7ANppPDTHNfxqrIyeniRCB1gFQOBv14XU4wC9bMJzrsd74/vbJprNZrP5KgqARji+QM78JYIdoYypkHoo53HBlVHEUTNlfsLTqBTCImYyVjpeWUNFlFd3hgtX8+mTxMLWmprRrHw3hHApSIqB1EZQtTTbZz4noGUbs/bATK3DbRKKdOMatbj13FvcT5MaNPUN+6DPkl8jGYE/uRZhM8R/4GTvjsl4SNMOHd2bSJD40IO8/i8LJP1gqWU8+aGyzhgHvsKWk0B+tmO612s8ikhwHa8QpTg0ApZfKbhT4/DHc0iuDBsICvtWe8Ok58GevcuKPimbAvHQ60GUh kzlO1lxZ /9AidQIPYqQ5wYF8Q4Dk8GIBpqvG5TwNXwxwhZtuAdV7Q++84L7oRnZBkPTbmrLRniE4/10knO6xKspLHJ5V83Eetb/FpM/85jp0JqYnXrBhPQvMR0V7x6bbVHrJs7nZqp+DhzXN/louWLDuosaJ7fSUsY8e+T6vPhoOxCksdyZISJyYNDA6IDcNK5wHfs8ScMwue/JwD7NpZI3PHZS0QvaRCKPu3jvL365t79dS2Kccm32AcyEKvyL/tLQ6ZoWynyoukU0UjNzuGVDIH0GwDZBd/LTNWweFAiqX70N3ZkwTGZNar9Tsc1UVUvlSnf++Uzs97KC1LfMSnZaegg5LnytNFF3bGPHvfjUn545HyNREUm2au396ZTSswm5yt6fZGc9nPodn5JQi3/6mObWYGuBW560WOgdCVmAqf7s1agmY2XUtFxlxmw9ts+dcjEufPIx5E9N5AWOgMO+BDPlp3t4DoY8fRMK8Xn0ibU2cG4DSxXKg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.24 12:48, yangge1116@126.com wrote: > From: yangge > > If a page is added in pagevec, its ref count increases one, remove > the page from pagevec decreases one. Page migration requires the > page is not referenced by others except page mapping. Before > migrating a page, we should try to drain the page from pagevec in > case the page is in it, however, folio_test_lru() is not sufficient > to tell whether the page is in pagevec or not, if the page is in > pagevec, the migration will fail. > > Remove the condition and drain lru once to ensure the page is not > referenced by pagevec. What you are saying is that we might have a page on which folio_test_lru() succeeds, that was added to one of the cpu_fbatches, correct? Can you describe under which circumstances that happens? -- Cheers, David / dhildenb