From: Logan Gunthorpe <logang@deltatee.com>
To: David Howells <dhowells@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>,
John Hubbard <jhubbard@nvidia.com>,
Matthew Wilcox <willy@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Christoph Hellwig <hch@infradead.org>,
Jeff Layton <jlayton@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] iov_iter: Add a function to extract a page list from an iterator
Date: Tue, 6 Dec 2022 09:43:39 -0700 [thread overview]
Message-ID: <0d62615c-57d1-922b-5ebc-32faabf33327@deltatee.com> (raw)
In-Reply-To: <166997421646.9475.14837976344157464997.stgit@warthog.procyon.org.uk>
On 2022-12-02 02:43, David Howells wrote:
> Add a function, iov_iter_extract_pages(), to extract a list of pages from
> an iterator. The pages may be returned with a reference added or a pin
> added or neither, depending on the type of iterator and the direction of
> transfer.
> +static ssize_t iov_iter_extract_user_pages(struct iov_iter *i,
> + struct page ***pages, size_t maxsize,
> + unsigned int maxpages,
> + size_t *offset0,
> + unsigned int *cleanup_mode)
If this is going to be a general replacement for iov_iter_get_pages()
it's going to need to pass through gup_flags. My recent patchset added
versions with these and I think it should be in during the next merge
cycle. [1]
Thanks,
Logan
[1] https://lore.kernel.org/all/20221021174116.7200-4-logang@deltatee.com/
next prev parent reply other threads:[~2022-12-06 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 9:43 [PATCH v3 0/4] iov_iter: Add extraction helpers David Howells
2022-12-02 9:43 ` [PATCH v3 1/4] mm: Move FOLL_* defs to mm_types.h David Howells
2022-12-02 9:43 ` [PATCH v3 2/4] iov_iter: Add a function to extract a page list from an iterator David Howells
2022-12-06 16:43 ` Logan Gunthorpe [this message]
2022-12-06 18:35 ` David Howells
2022-12-06 18:40 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d62615c-57d1-922b-5ebc-32faabf33327@deltatee.com \
--to=logang@deltatee.com \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jhubbard@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox