From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D00B7C47077 for ; Tue, 16 Jan 2024 16:52:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CB426B0089; Tue, 16 Jan 2024 11:52:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 355B16B008A; Tue, 16 Jan 2024 11:52:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21D126B008C; Tue, 16 Jan 2024 11:52:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 067C16B0089 for ; Tue, 16 Jan 2024 11:52:50 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CB965140398 for ; Tue, 16 Jan 2024 16:52:49 +0000 (UTC) X-FDA: 81685768458.08.E0CB005 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by imf13.hostedemail.com (Postfix) with ESMTP id E832320022 for ; Tue, 16 Jan 2024 16:52:45 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705423967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H1qKo0YD/yKydqWV36YqpCvWCMaWhygLdc6dUFN6lRI=; b=wTiLgWHUmmapeNAKKdJiA6ekPL/9LAb68rM4bKv1z5TMhWVagc4zwEyCNVu1VUfVw3ytA7 xH6ZuL0eekinCfwX8DDuvgCnJ7L2ZHKdH9tZwERrybosaOyx3Wd8fP8Re1ja18rZJRQ4nq 6Ux45mr1IhsHX5ZB9ckj/WA1XAxF72I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705423967; a=rsa-sha256; cv=none; b=TarYKy19VO3q4B3w3Qu8j/mA5sx/nOg5ltsLuk1S/pl5XjAMrqnbcHRnl8VvlzdWtv9MxA xcgXUZStndKn/T4FJCjRf3PYu6i4nkIgUmufUOM5Se8OzDdlObxovLFsW9ZbIeImXekIZE DmTLU4OCoLZO+oBsT/Pm3B3TsZJOex0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-78-CIr4UeMUOAeu9U8zNHxWyA-1; Tue, 16 Jan 2024 16:52:43 +0000 X-MC-Unique: CIr4UeMUOAeu9U8zNHxWyA-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 16 Jan 2024 16:52:25 +0000 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Tue, 16 Jan 2024 16:52:25 +0000 From: David Laight To: 'Muhammad Usama Anjum' , Andrew Morton , Shuah Khan CC: "kernel@collabora.com" , "linux-mm@kvack.org" , "linux-kselftest@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] selftests/mm: switch to bash from sh Thread-Topic: [PATCH] selftests/mm: switch to bash from sh Thread-Index: AQHaSFsmDX3I4Kn9G0+MfyGy1cAOzbDcpaTg Date: Tue, 16 Jan 2024 16:52:25 +0000 Message-ID: <0d5811eafd00496d98e88afe847fb8be@AcuMS.aculab.com> References: <20240116090455.3407378-1-usama.anjum@collabora.com> In-Reply-To: <20240116090455.3407378-1-usama.anjum@collabora.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E832320022 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ww9dj3x9jz1i4qpjyxwoi8wscthkbdi4 X-HE-Tag: 1705423965-409864 X-HE-Meta: U2FsdGVkX1+03Hr/qeAo1QIdhsCUwtCzNRIoxu1VBRyl5QEN1BygpBoLp+8VvmdRi5S/JXE/+UxhTXXYpl6w+u1JWDHbM5XuC3rFrEPO3AxeevJOI63MLv/zpLIkRaqPAs2z+J7siwBuR6uOXFQOVDUG5jKqjB4LfITQAZ3eKU/ROS8BZJsx2VK+NZ0GnqQZa4BiLYhZ3bHWwUAIID8Hq6WNavV+6e4G3jWMSP8qaTPaLwOCmbsoMog7wX317Ig1PSZEXJtLv3XzSh1xKNPPJGjazMl8R0JyGwODI9bUERquKSIHLzYahWWqwSFq1XEuRjA8TXEwaQcMVoJ7O7pUWLnmjhRIothvvgO3taJNjGaThV4BI26d5uXUlU1mUDPKsdEDJ1KCLv1H4455f5/WCXCdIlgPeaV91J8+S94/leyk2uktdg5v7215KwT0Ck+prOPSammeDWP2gkOKHse7N1aiVKKGjuTHjMNcS6yU03YIIGD9UQJ9em6+1YVNklm7gfWpYg/b+bwElLBZ6me8ImhDyZvOfXK74XTcyBHjfLZJYSGa8gM+MEFrmr2Ol/73ndXJqN1UFScx20gxG7rNLPEglwdN/Zu6PxYPovnduj4f4IjkW9+mx6kDK2Qqo6skyx9OGZnx7NZJt+MtB2mc4/yZrVotlgcXlw5axUnr0hw5feXyG5FFiHQcAWAMnSpApJGCX02lznm74I4j/SNZ4H/zsG0rVpcpVRJsQY5ZTghAE71oSxBTSFBPLzqRuDS5vSazIqBX6XyQCBLX7h5Y9ZZ7e6UNrGyzbHfcB822tL8VHl8MNUnFlC1o+4umnklCC1YlQHxjC12h7WlyTM5w1FuvyuqOryGbGzjbCXbcylDaurYoIK9TXdXENXcW2+rHujqbbNz2BEFKW9K8rbLDox47NJHi0/KfhC5Tp+lpalfO99MiDUwNu4FZRu/+eUbJmLSYthUqIeBv3VcZi/k QgEMhoXh kAQXvo+fjT/JD3/rAKeg3+Aj61WWPmrCfpjsBSJllGislW74bdPrzK+TxPJdG7t4jw5A7RebHjNG9CL6zqKeUzhTPu3MHKUW1Apg57ZdGt1cwfP5vXqnnXpjrQDv2coeiOUkakKOlEuzrlA5Kzl2ECLHQKwheTSjB5Krw2ALlX5ASvkGAm4f4ktARSrCYQXnzTmSl3a8l4g5F91MfDkF80jZf7x15Uk7LqedksDQQCZmdnnw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.020932, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Muhammad Usama Anjum > Sent: 16 January 2024 09:05 >=20 > Running charge_reserved_hugetlb.sh generates errors if sh is set to > dash: >=20 > /charge_reserved_hugetlb.sh: 9: [[: not found > /charge_reserved_hugetlb.sh: 19: [[: not found > /charge_reserved_hugetlb.sh: 27: [[: not found > /charge_reserved_hugetlb.sh: 37: [[: not found > /charge_reserved_hugetlb.sh: 45: Syntax error: "(" unexpected >=20 > Switch to using /bin/bash instead of /bin/sh. Make the switch for > write_hugetlb_memory.sh as well which is called from > charge_reserved_hugetlb.sh. Why not just fix the script? Looks like most of the [[ ... ]] could be [ ... ] although some might need to be [ -n "$cgroup2" ]. The delete the 'function' keyword another bash-ism. It's not as though you are trying to run on a system when /bin/sh is a traditional (aka non-posix) bourne shell. =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)