From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4655E82CB7 for ; Thu, 28 Sep 2023 01:22:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01EEB8D00A4; Wed, 27 Sep 2023 21:22:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F109E8D0002; Wed, 27 Sep 2023 21:22:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFF398D00A4; Wed, 27 Sep 2023 21:22:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CF1008D0002 for ; Wed, 27 Sep 2023 21:22:37 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9883B1CA3B6 for ; Thu, 28 Sep 2023 01:22:37 +0000 (UTC) X-FDA: 81284256354.17.BDA61DC Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf22.hostedemail.com (Postfix) with ESMTP id DF4C4C001D for ; Thu, 28 Sep 2023 01:22:32 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695864155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cK00YGAo4rFbZqfuvnKWKMZPal/mWTfUHCZ/GfZg4So=; b=U4fPyuNF3dJtsqii9oW4ogn1HERVok7FpLGlintZjmdwqQQAKsfHmO8FpeRnhHKSuAy5nV fWNZDuPS1q0pHw15FunJHv53MpYUKfDgIS3DKLtIHeUHg0S/35ZWQE4LwUKpWYaKr10+2i d2AZdUKJYOAJ1XEwDFCKYyFgsJm8qTk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=liushixin2@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695864155; a=rsa-sha256; cv=none; b=8EheK/Xcl2Q73+Y5Vgx80tbFEJOJgIK4EN1bJ/oQBbvpRtLLjKFvbLRc8srJ682mUAxuxm /aYWmuGb6/aRlJ62XSN0Wl67b7ycIZWYnNTDvte92JCb+xozBsejDriMIX2h+BE2tImkql df3HzLDnc42b1//dmEFepgUzCc959RE= Received: from dggpemm500009.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RwwcQ1vsHzVlFv; Thu, 28 Sep 2023 09:19:18 +0800 (CST) Received: from [10.174.179.24] (10.174.179.24) by dggpemm500009.china.huawei.com (7.185.36.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 28 Sep 2023 09:22:27 +0800 Subject: Re: [PATCH 2/3] mm/kmemleak: fix partially freeing unknown object warning To: Catalin Marinas References: <20230927035923.1425340-1-liushixin2@huawei.com> <20230927035923.1425340-3-liushixin2@huawei.com> CC: Patrick Wang , Andrew Morton , , From: Liu Shixin Message-ID: <0d54b2b9-07f9-965f-b2b7-50139f39b459@huawei.com> Date: Thu, 28 Sep 2023 09:22:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500009.china.huawei.com (7.185.36.225) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: DF4C4C001D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 68hsjynnmyqk6xisd515f6wt1draeicz X-HE-Tag: 1695864152-406720 X-HE-Meta: U2FsdGVkX19ntQ3IUO/xQQKsSGob0Hzm2uvvjYSDZXI+K0TikUxzAIMIk4C7XXIlHUsgxWlXkyiyJjNrzA9B0M1YgbQut2wu15F3Eu1gUdqK17Lvutn0CFQQLJIlNCHYn8RgVSDlH4WLobzhp2x2t5Q6U7Cs2gH0s85PJHWBO98zzLVdRvRqE3hS++6SGzYkijHcBJyCI4JfnYP/EaR+tZ+cvA9eu77F2dmH3Fq6s21uS9/k7a1GtIqH2w2LoU8m8YHepPM5/9i6dhHybBmbo9BABULcYMmEhiahlyhRqeds8A16VsROj2mq8nbUENwRvlmZL/pUfRclLJSXqwzMASHWaB++FQdRxJB61qSkm5z7gPKYEuc6rtQl+jFdM+bbhz0EMZ4Q3yGUvW2HfnQkVvogeu5+VySng0e5N5maK/wl+/HtLU7e9G/DOI7E31tw+uR4+2RZddCFiSu7UCjhJBqAqSoUvDdesLlLIjz7c8C1HuE2EjA0IPWcEn2XeicpIYOAr2oehiRZz/y1YPnMVnCnsvt4fBk2jB3dAHRsLzuSFxNhU8JVO376fCrQjNKjI08/alTEdrKHzxEjwtLaAalXJ6BHXniFJCmPRxcmC+Rl3bmDooEv9ynglNa7gqGTMuOT0EZ6MTjcDfS3ipwsrZ1KLxOuumqQ0rOKXHOq63MhHvL6CNtqUHfIHesvJvkZo+leckXW199hQzWbuLL86253XwTb++P7XQXx+7JgGwLMWg/TymG21oZ+IHWYomi+ugbCVTC8viS3J8CxiOY1GJkx8acndK1iCoIk73ihF5Cbn7iEOks6lWhz8u9GNHRcqAjTaoT3+IQpTvy5KlR/SqV5CtG1qBMEwK3aNZvQlMcPuLjKTfAQnCOWY7Ok/lGb1r3gIa3aV1ukIv30VIhc75qlueUzXcY0Z6n3KVWoFCwlNW+gCpNuNF6vfAOUf02MEAK+k8FW9XSCV33l7zc 2zQLkWQi 8d70A3BiLDQIeEtynIsPTQLrpazhP8JUHhue1TGCRg/SyhQoj34ujlc+LylF0uu38OMPvWaroaI+1MR4I0cRdQrCVunvUk1MQuHbxNe+GctAphiGHxBRpRpQRRjhHoiIA/btHOYV0VXYU5Okw8FPQ6RCozddfOY9PaaG5aDddtiqYLvvl1tQzOYU2LLGMg8zhkc1xY+v/Izi2NpU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/9/28 1:06, Catalin Marinas wrote: > On Wed, Sep 27, 2023 at 11:59:22AM +0800, Liu Shixin wrote: >> diff --git a/mm/kmemleak.c b/mm/kmemleak.c >> index 54c2c90d3abc..5a2bbd85df57 100644 >> --- a/mm/kmemleak.c >> +++ b/mm/kmemleak.c >> @@ -208,6 +208,8 @@ static struct rb_root object_tree_root = RB_ROOT; >> static struct rb_root object_phys_tree_root = RB_ROOT; >> /* protecting the access to object_list, object_tree_root (or object_phys_tree_root) */ >> static DEFINE_RAW_SPINLOCK(kmemleak_lock); >> +/* Serial delete_object_part() to ensure all objects is deleted correctly */ >> +static DEFINE_RAW_SPINLOCK(delete_object_part_mutex); > Don't call this mutex, it implies sleeping. Sorry, I used to define it as a mutex lock and forgot to change it. > >> >> /* allocation caches for kmemleak internal data */ >> static struct kmem_cache *object_cache; >> @@ -784,13 +786,16 @@ static void delete_object_part(unsigned long ptr, size_t size, bool is_phys) >> { >> struct kmemleak_object *object; >> unsigned long start, end; >> + unsigned long flags; >> >> + raw_spin_lock_irqsave(&delete_object_part_mutex, flags); >> object = find_and_remove_object(ptr, 1, is_phys); >> if (!object) { >> #ifdef DEBUG >> kmemleak_warn("Partially freeing unknown object at 0x%08lx (size %zu)\n", >> ptr, size); >> #endif >> + raw_spin_unlock_irqrestore(&delete_object_part_mutex, flags); > I prefer a goto out and a single place for unlocking. > > However, we already take the kmemleak_lock in find_and_remove_object(). > So better to open-code that function here and avoid introducing a new > lock. __create_object() may need a new bool argument, no_lock or > something. Or just split it into separate functions for allocating the > kmemleak structure and adding it to the corresponding trees/lists under > a lock. >