From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEA85E77184 for ; Fri, 20 Dec 2024 03:19:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 303FC6B007B; Thu, 19 Dec 2024 22:19:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B4F26B0083; Thu, 19 Dec 2024 22:19:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 155876B0085; Thu, 19 Dec 2024 22:19:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EA9A86B007B for ; Thu, 19 Dec 2024 22:19:25 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 93DDF1405FC for ; Fri, 20 Dec 2024 03:19:25 +0000 (UTC) X-FDA: 82913881512.02.0922A06 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf04.hostedemail.com (Postfix) with ESMTP id 7BC114000A for ; Fri, 20 Dec 2024 03:18:47 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="Ag/Fx5Ft"; spf=pass (imf04.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734664738; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=51Bci1H5mL9OOnwiHpY7i+lv4oTBv7dl4EI7SLg4wXo=; b=leaTJUtU2hCloJits0fOncs37MlZRCBfPK1+QCw8verBMaRaI7Ka1PVCppaj609mIg4iHU HCXG+SJjAYJCIaPTE0ethopzu6JyDYps9AeOMAhdNd27kO1XPNlV7HnR2dAY3piTTxzfOy DpCfe7FrADxgQjTXHfr/NOb+LBHMudw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="Ag/Fx5Ft"; spf=pass (imf04.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734664738; a=rsa-sha256; cv=none; b=YfdRk1ngI8Ehi6C0HvwOUclxxGtwKUtMvHh7cXW08PVJshCLCDuCrJhguchGT1qFV6nX1V LsNsYSjLdZbm9TQIw2FUsEIGHtMfJ0+OtqNej9CWD0Y0heWYUk1YeqGrOEnniVHoFaY33q 7ua+jAfpJYozU3hP+Tl/Enu+8kBHH8Y= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-216281bc30fso16223115ad.0 for ; Thu, 19 Dec 2024 19:19:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1734664761; x=1735269561; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=51Bci1H5mL9OOnwiHpY7i+lv4oTBv7dl4EI7SLg4wXo=; b=Ag/Fx5FtEAq8LzMj8W+WX+qqUsj/MYOQKOaR+V4GyZEb4hwnBGGOdmW+9Bb1Dmz0/d joSbJHw+7FgscNvtU9+R6CBDrrauVI7F4cRJw+WfYi/P8dD6DtqG0DfYRn6NROYk2Rtm KurgDHnoedb7vRitcAwRcRLf6RLTKCmNHLVRkjEYfcUVXu+Q45yBKHGLViypjxFx/Y6c +JJaOzFPkpVjQpVCe+spokOmDNCnynqFPAkpJBVuz2fArieIlSCZAMkoLG4movh9O37d 0i/U4a3KoJgQFkXq1bnfcM1pyAAUbZf/lmZ4fmwqlrB+Hzs/Zfyq9qbqxvIiuXQQXWyB jw6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734664761; x=1735269561; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=51Bci1H5mL9OOnwiHpY7i+lv4oTBv7dl4EI7SLg4wXo=; b=hMUYU7aJNYcFLFeuYYYEPZ9XSq6RAFkIUz0NWNyn0djDgoFN5n0lHTaKb6CD5ODqGZ 8nZ8RURrt/nAKzMdFZt1gaZYpImHDMbWmVHY01UtVvRzgL70mNu8eKLP85AzgcGLB7pI cUmH22m6MeB1dgf5at080pexyt2ia0xUqmyU4QHvhC3/7GuXJSogFi8vX4U3Iqof/0eL 96jP+rgMsSlArJHl/pqK+ZIHZwct6SxDp9GYu1ZKN5l6dp9dE25E8mxxtPfqpg5zFFhk 8ERxaiSZgVpBwPidoWT3JE9+GOQFfvDQjtKQB0glyV8qrqYGmCAqhKLWCoj3Exzxn+dC 7ljw== X-Forwarded-Encrypted: i=1; AJvYcCX9pM58skrXF3hBSP42Xvqsbug1HLtUW/dLnkmpxEfrRlPeAz+OEv5OlrVNzd/816yJzZTflWYTcA==@kvack.org X-Gm-Message-State: AOJu0YwQDXSg8Jv9v0zM562V3VD1khyngFhP9nGtwcY0L8dD7wT91Iz+ 7QeQTHp2PQ9idxoFNZnPpt9IeEBQdw56+q2sH7s5i/XLJ6y1ldGBJ6VP0Q8Pglk= X-Gm-Gg: ASbGnctgydtnkeMLJdvFDTibQODBujlDe9NkCZwWt9sdlcsUdqKg+EPLdI/Z/7EZzBE tByAlvW5mgmnMMsgYH5xiGbV4OSyLwS/KjYQcUAPAyLmkKnOUy6JzD6sVt/dCVOUmmezKmD7kVR CcueIB36efcEiUxzXEyRrX7eyxg1+MkoquuTs8Der48c0MucbeenkBreoldpEM23tgDvCfDjVpJ 7yM/dRvCwVaG92Xr8xtzIIp9IPTJTSZdzPcJJOAAlQL2xOgv7syBFc6XKmzkVBzcj9EcoDrkZRd G8ZAuw== X-Google-Smtp-Source: AGHT+IE/Lwl6AERlnJfBgHbvf0mEOu0EDQNE/8CDgO2tsd4ItkTJiY/nI3OxlMpfKGheClOtH0QPfA== X-Received: by 2002:a17:903:24e:b0:216:1cfa:2bda with SMTP id d9443c01a7336-219e6f25fbamr16680525ad.43.1734664761307; Thu, 19 Dec 2024 19:19:21 -0800 (PST) Received: from [10.4.194.102] ([139.177.225.238]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc96eae7sm19615015ad.85.2024.12.19.19.19.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 19:19:20 -0800 (PST) Message-ID: <0d22a66a-8c35-40f2-be1c-0a4a94885d9a@bytedance.com> Date: Fri, 20 Dec 2024 11:19:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/15] mm: pgtable: introduce generic p4d_alloc_one() and p4d_free() Content-Language: en-US To: Alexander Gordeev Cc: peterz@infradead.org, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7BC114000A X-Rspamd-Server: rspam12 X-Stat-Signature: f95uioout9a7j8tuxibrzkoi1syay11j X-Rspam-User: X-HE-Tag: 1734664727-439864 X-HE-Meta: U2FsdGVkX19Rl4YYIyZXx/RD6nj11KsUz6CVjwc4hiFjJ7g03jl35yDP6xrXLYV7AJ13aRJOTI0mi4badDkPsn+Wp1rgsADtzmSyEA60JPy4LGD2u3K+wZw2iwP2JOaCCNiUoCdnKBmDVwFm0Lxh04xeCM0hUmdRqNtAqhup6HG3NvROW57ymRTwAwYTd/0Atcs+J5xPGeK4e0q/UufSX3U/IZY6VMsSPMWRxtqWLRrsWd0N74/I6108HPFyWb3UiN5Jk3NDSr7uqd3qU/s3qFzbd7ZQnE8tWh8j+fk/eHnN8B/1LXyQPT1W3NQ9WkRejuuLm2ZyTuXIvFPUtkXf0YJ8bgE28ovildQYXKtlTW+g/fxxq7+pauFCtS6K5vZg/eoYmKMu3yCdfzO+zBlzB6g7kQDw4QkCrkPKlQthxVOGwZo2gq67k7P6RGyT0zUbPUUBoyqIZelPUkufuOFJi045EFi78kBIFROqeZViDI3ITHBPagFTvPkV+83r3kjTHSlwO2GGww04MiYI/xfPPP2EuS4kEE6Zp3bTZMhTWDOy7PQB+BKgz84w6suliphbdoSqJyzPzCrVbDrUpibqVv1vbsB4ouLgOJTsKChv7236NrwGN36IoXZNpvAs4TUXoR5eFXIf2ZGc0m9ESIJ3NBommT6Znq8uUbNaFrR1nPBZWqreq9nxPoT1t+XywT9Qh78nvNETsIEVankMnYMfYF3LoeZ7xK3J5hfkgThaym/8JRBSBZa6p7J1lzwqtl4phUqtFkUz3BWPXrQkhiPOLDuVVaKGa1S9aEiBoBj192HtiWnKsSPzsx6od2C8lX8BTocHBGYAMrp1gpd9iLiF907xDVpFh5umBZlx/UDbzNNw72JRNNeJhE9rV2StQCOGHEdHVGdLKYtVlM9CvHOUr6u7Jkj0itFJCxvXHNb/MB2S3UOPVec5RYD/LGPGKbD6WLssjpMMVmKgJuqgrT2 VeZN9aoU 4A9pDKrzPBfHFLMN8CUSkk/1sbOtEI6rThJ+s2kxAIQGzRvIBph7uaoBHBrfY3zu0dEZwNRRms+vkJuUsGgbsFcdh2r1dPD5GFkfcCl9RbKGPEnv8AMswEWUtloHvT7kxSMlAfA3Kkeag3CS+F0BKC7Qp5CNbgsUzNLYYRmGErYZINPx7qSN2+N+v3hXuqpxUV3AF/HGCyaJHQhNjTAsTAIHKZDUQoMWSwU7hZ+UQSl51wEjDwB5GIcQmB0Rjxw58vkqPPjT33u+he4efeF9p7pF5eZrDa8YmuEGC2K3bLA7ExBiVUIxa/W14O7UHC6j1F4MlB0Em0mcGIF8E14XwoOReZscG2WcnhDsGRAnDdhRbIjJBBkBS013BLWHJeF1QHvbPVK7oDaeC3DfWsH14PC+zO8Xx45v2U7BhCDZUWAhhYlGmSR9fdNH3ALlJv1BPvqKbmXMhncAZpBc= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.495259, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Alexander, On 2024/12/20 00:32, Alexander Gordeev wrote: > On Wed, Dec 18, 2024 at 09:04:38PM +0800, Qi Zheng wrote: >> For these architectures, provide a generic implementation in >> asm-generic/pgalloc.h and convert them to use it. And like other levels >> of page tables, add statistics for P4D level page table. > > FWIW, introducing the generic implementation and adding ctor|dtors > look as separate changes to me. OK, will separate it in v3. > > ... >> static inline void p4d_free(struct mm_struct *mm, p4d_t *p4d) >> { >> - if (!pgtable_l5_enabled()) >> - return; >> - BUG_ON((unsigned long)p4d & (PAGE_SIZE-1)); > > Or maybe? > > BUG_ON(!IS_ALIGNED((unsigned long)p4d, PAGE_SIZE)); Do you mean to keep BUG_ON() and change it to the above form? I would prefer to just drop BUG_ON() as is done with the other page tables. Thanks, Qi > >> - free_page((unsigned long)p4d); >> + if (pgtable_l5_enabled()) >> + __p4d_free(mm, p4d); >> }