From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0946BC4345F for ; Mon, 6 May 2024 08:06:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08A016B0082; Mon, 6 May 2024 04:06:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 039B76B0085; Mon, 6 May 2024 04:06:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF5FF6B0087; Mon, 6 May 2024 04:06:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C20D86B0082 for ; Mon, 6 May 2024 04:06:13 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 399F2407F4 for ; Mon, 6 May 2024 08:06:13 +0000 (UTC) X-FDA: 82087238226.18.F5410B0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id D1E1680002 for ; Mon, 6 May 2024 08:06:10 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YEO1wVlX; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714982771; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=socFUx6NYRlC6FX+b/4YakVZLjNJbNXEITHP/SnO7pY=; b=abzKlYg8WoiX8dbDnRMnLMupEJPXkPWaNeZ+Tvin0gzjsxznrCM9AgTmmWYkyehtZ+qphb MTJMeOVQsYlZwBxmSjFecACoBp1XsQ7wggcP7X6Fi/RvPh2k/p25lJGPk2mO/rR1/5fz28 5p1alaItBQcn28xpe5H48cVJK2wmIT0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714982771; a=rsa-sha256; cv=none; b=Av8/s00rV+Icy5uAiHwfX5M2QMQeE61QiHjNt/xfLOrcXdmP2nNeiuQJVtEdxrHsbWMqXC 7+UxvLCkik9HFPr/lqWy1CenAyeXYyFfX5BKBNSFZ+D1w4hklrUgDPoA7bdZ3Ru78uTogi GR16o2yxDzx0B2lK17wJ+esrv1hvBk0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YEO1wVlX; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714982770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=socFUx6NYRlC6FX+b/4YakVZLjNJbNXEITHP/SnO7pY=; b=YEO1wVlXlGj2WmCL/jX1+2ilXsbd23bdhkHQOVP95cyEHmqaSkJibw0rZINF62JJdc73tx iMiP/qo9KUQ05VUsbO8b0fo/gG5BmfKK6vISZ7zskrnV/O8emGakSxS3/nPpqPRbOnIo9k bvSaPXNrh2K0S8DaquhVWB4C5cU4cAQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-312-QL1Cw9E8N7Km9ySnvnTTWA-1; Mon, 06 May 2024 04:06:06 -0400 X-MC-Unique: QL1Cw9E8N7Km9ySnvnTTWA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-34db1830d7cso728693f8f.1 for ; Mon, 06 May 2024 01:06:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714982765; x=1715587565; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=socFUx6NYRlC6FX+b/4YakVZLjNJbNXEITHP/SnO7pY=; b=GhDxvfGjcu58l+KfQeEaIwV/Y2mXs0wngFjILgWcMgBgYsBnEc50XhBoQPDrIF3SH2 FisEBr6i5mfZVzjiEBuEMmOmItP+7LbkbVa4iINlyOVhjpGnMIpuEeZkVaDo5gDYZsgx KdoE1cb32E2c8Tv1j3cKC3IWT2YvJzN6GbSM1FYXgawBuRTAOj2nWql9ggAuztk9n6q0 IKY3P5//ejq4hvABjjrouUhq6FOAm0l1UeJbIeeyuHDU8Wn0Fsm64aOInhwhUSEbX8qw cT11wfk58WPgXr/uEy8pWYav/H08IZIrBRKLzQoTlMcotCoOIht+n8yisWWDn+Qa0s55 AzwA== X-Forwarded-Encrypted: i=1; AJvYcCWFLt7oe9wMKg/r5on1LOQ56bXYryJZsIt+RusvqEj8CF0lAVLPPVB3ITMfHV7g+0Ng5S6lV8a/Q2REVRFpLccNTMg= X-Gm-Message-State: AOJu0YxrWRxhkg0jd1+b5x6LW+6z0O0Zjhzmeaium1BC56RooR9k6Z1G CFXW/KWL7JZeSM09g4yvpNsKdPbdA3Qm6Jg7m1WTZ7ds5UDna1bXxD8PrfQ612Shjl3/cOiOLQM JCemKlIg1dqJxQVH2WMqLG4GXz0OQwtH4x2RszWCqhwJGbm1V X-Received: by 2002:a05:6000:1806:b0:34d:7f59:30b8 with SMTP id m6-20020a056000180600b0034d7f5930b8mr7951513wrh.12.1714982764735; Mon, 06 May 2024 01:06:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF+RmIC3tAKIr/hFSe4EocrWncLVX8yrb23Urumb87WSfhYxji8ZOYT7EwQie1VELRGuugF7g== X-Received: by 2002:a05:6000:1806:b0:34d:7f59:30b8 with SMTP id m6-20020a056000180600b0034d7f5930b8mr7951481wrh.12.1714982764201; Mon, 06 May 2024 01:06:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:bf00:182c:d606:87cf:6fea? (p200300cbc74bbf00182cd60687cf6fea.dip0.t-ipconnect.de. [2003:cb:c74b:bf00:182c:d606:87cf:6fea]) by smtp.gmail.com with ESMTPSA id s14-20020adfe00e000000b0034e553f6174sm8490671wrh.98.2024.05.06.01.06.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 May 2024 01:06:03 -0700 (PDT) Message-ID: <0d20d8af-e480-4eb8-8606-1e486b13fd7e@redhat.com> Date: Mon, 6 May 2024 10:06:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/6] mm: introduce pte_move_swp_offset() helper which can move offset bidirectionally To: Barry Song <21cnbao@gmail.com>, Ryan Roberts Cc: akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, hanchuanhua@oppo.com, hannes@cmpxchg.org, hughd@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, ziy@nvidia.com References: <20240503005023.174597-1-21cnbao@gmail.com> <20240503005023.174597-4-21cnbao@gmail.com> <7548e30c-d56a-4a57-ab87-86c9c8e523b1@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: dp91j9qg5sksakmkxka8gjffhpisnkk7 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D1E1680002 X-HE-Tag: 1714982770-377571 X-HE-Meta: U2FsdGVkX1/KOAn/yIUwYyHgwEnOXGLP1bZkqV36I3io3H8zI994dE920eOWIAhGBrAb7RSnJVk7bCwgiDFhV5nUnYN2JKFK6X5qiP5Au3ET9vqLw43eUgJ/f7IKI3Lp0lN04DrQOjXCuWGqkXTc/TVGpxtSL5n4NJDjeSRrTH7FbdfQ67IURr/IRDE7QE/Ks6CeEZReoibum9owty154Rq8i6/tzXBvyzd8VUmkexmMDtNRjAVwnNnZo28NPnBVMlhp6zlRL4SrNURM63EYtI2Twk6ayacpd1ywboWV4pi+ZtgYlVE5rpGeFg8Pmi4/9ZCvTEu6Odq6tA8U5hN5Dt+c7aDxSzTlbsw/UcICWq1nrgV19ap6B0YW7KfzwB2YW48ts+3WOENjljpxTr2XqDx/uyu57z240ztwpfrYbS9GVa2jaX+KdWyZztkCtFOmQWgggWBp9F+eRtcNEeTb2uwsXRoA/D+3/0Hp09vjiBk+pkpRZ9szJODpam3tli6Xm5lpEITY7M/LEYdUl2gPpa10OJ59HZYbflcowi/Y8EW4v/AWRJyBZdCmSRiyK5zcdhPrPvY359B/Wu07PxIW1P6bp3SmPv1uPA3QMnTFSmCliVzcOY1DrgLyOAF5iFUJ8BAHSmGaCfkcrFdPw1sWPnZJOdgl8mdjiIDvT6pkN7dyvCkvk9/oV5X7Aendc7qDt6b+MI+Wk8jywgGc4+pim9Flkzj+erbdKXvYJuHY6DGk5DJxwW7MqnzVJW+JmIh9LEbqZd9Xfs6OmR/+jGsauZduwm8BgomxYFbcieGprTe7Kb/BfoPuW2ENOqQO4o2tIyUxxkLSrmW8L9wgTdjuPJew3pD79mVFhm/R1u9t3s5wT/EzG2raqfxj53wOng213wF974HRVBKufUNgjAVbLWZ808eJ2rdMNI52ASnhfmRfJ2xy2BaW0HXG+zphqKTsMlAribj0x09BKMwxtXl 1Ied6rn2 92v98GKijEGln47lHVK3frqSzjmsoRrjvsBEuAgNiGn453+OCN2Z5MidwW032pnmyzL6Zl9c4vnyZ+3bFIIku4/j9E/3uGRGn8GSzDWN50WIdvMgL/Rr7smdiAcoumPzVUDAw7dSwFSqT+iQjBFmxbpt3ULKhc6Ef2YeC7Otr3bKTYNn2UHRTsw2B46T80Bai2+ACz4MVLnZ8XqcsA6SLHVC6vQ93f3AZ5KuEW+FxsXmNsFdIuz23epqoymwb3JmeXD50vVQAjKmXN1ircXPfsfQJfklQbZPi1n+L/49Ib+MvMhz42H7P3svnV/1BW1pT+KqJe3kwSut06dhIcYMFRYPISPV1XseIyTcNdn/4D1ty9rQxGwCMX70r2pUeDFNJnzodal49MJIwzKQO/IbY1toivf0LzaDSZxT6frBrWnsoXx8Mexhz7tAkuJ78Ep4L1gdTqP76va5Iy+hgEsL3klCNQ8D05evidJHrG31wHKhqiW38T6PnENXlCzMJZeqZASqBkMrxY3qvhFKbd3J4rH/3cD/AoZfAC/AtDIT3BJNSP2VMbWPcgoP2TNf9pZ63CFLo+yGg0SL+DmyqrvITHZrSjNqxxA5VQfEoGkWTcll2BR6PON9jHFWISG9xMi3wMIARCVc4g4RXV5L0gkhUK5fhtL5FJLAUn+gBjcniAtQ6S8oS28jYB3dIxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.05.24 01:40, Barry Song wrote: > On Fri, May 3, 2024 at 5:41 PM Ryan Roberts wrote: >> >> On 03/05/2024 01:50, Barry Song wrote: >>> From: Barry Song >>> >>> There could arise a necessity to obtain the first pte_t from a swap >>> pte_t located in the middle. For instance, this may occur within the >>> context of do_swap_page(), where a page fault can potentially occur in >>> any PTE of a large folio. To address this, the following patch introduces >>> pte_move_swp_offset(), a function capable of bidirectional movement by >>> a specified delta argument. Consequently, pte_increment_swp_offset() >> >> You mean pte_next_swp_offset()? > > yes. > >> >>> will directly invoke it with delta = 1. >>> >>> Suggested-by: "Huang, Ying" >>> Signed-off-by: Barry Song >>> --- >>> mm/internal.h | 25 +++++++++++++++++++++---- >>> 1 file changed, 21 insertions(+), 4 deletions(-) >>> >>> diff --git a/mm/internal.h b/mm/internal.h >>> index c5552d35d995..cfe4aed66a5c 100644 >>> --- a/mm/internal.h >>> +++ b/mm/internal.h >>> @@ -211,18 +211,21 @@ static inline int folio_pte_batch(struct folio *folio, unsigned long addr, >>> } >>> >>> /** >>> - * pte_next_swp_offset - Increment the swap entry offset field of a swap pte. >>> + * pte_move_swp_offset - Move the swap entry offset field of a swap pte >>> + * forward or backward by delta >>> * @pte: The initial pte state; is_swap_pte(pte) must be true and >>> * non_swap_entry() must be false. >>> + * @delta: The direction and the offset we are moving; forward if delta >>> + * is positive; backward if delta is negative >>> * >>> - * Increments the swap offset, while maintaining all other fields, including >>> + * Moves the swap offset, while maintaining all other fields, including >>> * swap type, and any swp pte bits. The resulting pte is returned. >>> */ >>> -static inline pte_t pte_next_swp_offset(pte_t pte) >>> +static inline pte_t pte_move_swp_offset(pte_t pte, long delta) >> >> We have equivalent functions for pfn: >> >> pte_next_pfn() >> pte_advance_pfn() >> >> Although the latter takes an unsigned long and only moves forward currently. I >> wonder if it makes sense to have their naming and semantics match? i.e. change >> pte_advance_pfn() to pte_move_pfn() and let it move backwards too. >> >> I guess we don't have a need for that and it adds more churn. > > we might have a need in the below case. > A forks B, then A and B share large folios. B unmap/exit, then large > folios of process > A become single-mapped. > Right now, while writing A's folios, we are CoWing A's large folios > into many small > folios. I believe we can reuse the entire large folios instead of doing nr_pages > CoW and page faults. > In this case, we might want to get the first PTE from vmf->pte. Once we have COW reuse for large folios in place (I think you know that I am working on that), it might make sense to "COW-reuse around", meaning we look if some neighboring PTEs map the same large folio and map them writable as well. But if it's really worth it, increasing page fault latency, is to be decided separately. > > Another case, might be > A forks B, and we write either A or B, we might CoW an entire large > folios instead > CoWing nr_pages small folios. > > case 1 seems more useful, I might have a go after some days. then we might > see pte_move_pfn(). pte_move_pfn() does sound odd to me. It might not be required to implement the optimization described above. (it's easier to simply read another PTE, check if it maps the same large folio, and to batch from there) -- Cheers, David / dhildenb