From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78A0AC02181 for ; Mon, 20 Jan 2025 10:39:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 062FD6B0089; Mon, 20 Jan 2025 05:39:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2E006B008A; Mon, 20 Jan 2025 05:39:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D80436B008C; Mon, 20 Jan 2025 05:39:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BA7CC6B0089 for ; Mon, 20 Jan 2025 05:39:57 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 376FE44E13 for ; Mon, 20 Jan 2025 10:39:57 +0000 (UTC) X-FDA: 83027484834.07.06BDD98 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id D2CC0C000C for ; Mon, 20 Jan 2025 10:39:54 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="iwnLxw7/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737369594; a=rsa-sha256; cv=none; b=bxZd2EzfMkaHV71JLhPfx5VDFbXFLyfvOylLO0yUv8KxYLDPdMKpRcc+6myIj/4X9jTG0Z +TGIugK/5o9PfFKhn3fL6E5QMpbiHBRhOG1XQ3x6YWkM7q2KBYQK3lWPaUs5Y/taZSWDKO eczEQBNOqnpaYU8GQ6ZkhjPv3M4ol+A= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="iwnLxw7/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737369594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iVh+knyz+U7zGonLytLhiM5WUMXVQGSSBcIb212ZOIg=; b=G0ZNdB5tBaWuDVhf53Zrj/gWz9YplPc2opHJxFOqmSSBNAZmoWUGKfVYWdRZOJ0dK5wOdW Rkhpx4XJ00FSSzPDRYdH6uh8IAEsXnJ81zzCiU4X4OpgD4+CgX/hfSlki3VZKdSkKPsfpJ iSvN78H5mCPvGnAHTSNmlBaJyp8wcqY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737369594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=iVh+knyz+U7zGonLytLhiM5WUMXVQGSSBcIb212ZOIg=; b=iwnLxw7/j1IIIFcRNXtBEqrGrLoZBznh/mJnOznoTnNV1oH3F/sf/C2NuyOQm94SyXJtlR kESx6uVGchiQU8fHof0V9qXDUAxmCMMns2bo3Wem/Ee4ZqAJqoO+JMV3f8G+O8IEtS9Nc4 ejDEGQu/9chEgFr3ADfVR+Vb3nhpQPc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-170-WZ5EVO8CPkmRdOMjiDV5Ag-1; Mon, 20 Jan 2025 05:39:51 -0500 X-MC-Unique: WZ5EVO8CPkmRdOMjiDV5Ag-1 X-Mimecast-MFC-AGG-ID: WZ5EVO8CPkmRdOMjiDV5Ag Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4361efc9dc6so22910635e9.3 for ; Mon, 20 Jan 2025 02:39:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737369590; x=1737974390; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=iVh+knyz+U7zGonLytLhiM5WUMXVQGSSBcIb212ZOIg=; b=Bv6n2GrS92DruvWKwhj9ijjZH48WWCzm5Ixt4rK8vATOGt7dt9VhbgFsMI5L8We7yc vhSTUJsMUw8alc5rtKYFVPAU7Zp5aRMDmMsMrVrH6gAU+B1AjZ1P/0LXA7Rj2dKlXwpt 8UnbzP7jY1VBZn90YIP+oQO2Z9GbJJfYMANvgTso3v6xduQjm+m5Biek0vOZgk1Jxx5Q XI2BOI5XK8w8Fr3ls7bRf5IWC7oon6BZFCovtMs+ATNnAtsoOABla7iCLOnfIR9xyqFV 6drDNp56KkJsdNxC7fP/uph8r84PpEqLJAoVXvu2PYcZTYzYfTer/J+XmkLNOrBqmeyc ccUA== X-Forwarded-Encrypted: i=1; AJvYcCXTkLNNrSHQQj+xq6B7hAlpC2M1OIoqx1QL8Nr24MXDtGe1Cf0XNNRBBNNdv9PoKmHduWYHWnI4OQ==@kvack.org X-Gm-Message-State: AOJu0YwKda0y4Wwg4R7306CwVh0UXUiYLd0UdfRjWezK6rsyd6q2UuTn RKNYOwFD0xtymBztaeaALILXtucCat5OPoz08jEVCkTS9NLIsYcH/Wp8fqbYr/Bmtt232bebZh2 tiLHL+OU6VOS0aldQEdhb1ieLjznSDqH01JukfOFiYFS9ZO9a X-Gm-Gg: ASbGnct3XbtrmIZXeKiBbB+eaH3nCJ1YKHEMyZBg33j+LpUnxHj2UgbBaTLbqMNmWrX 6ClbIjMfETCHy5h+f3XXRvR0m40fVZFAbMBi5z1WRrFC57FAufR+UTONnncEIO3OqDqtxvP9wm/ S0ZEpjoB6YtORzn0vaOZBlGFU4MhkY7yiOUPxdiSGQYIn9DAbr+mzSXZLplOg5m2HtrIC/FC8zl Y2byMZZdt+Odb32k1fM46epvydZpGAo0jqHTv+hDLr9UAJ1cMkSRkpSdMlSQb73uKxTNkGCT5uo ad3EXs0fuD6ZN0Ks2ZDHjWZcFSyfhXaa3AbEW0sDTe9wpjnzroCc/KusmqQQrly51ST3sXxOIIB Te4MQU3kxuO+9M5UdOMQ+ZA== X-Received: by 2002:a05:600c:4f42:b0:434:fa55:eb56 with SMTP id 5b1f17b1804b1-438913cf805mr119456745e9.7.1737369589692; Mon, 20 Jan 2025 02:39:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IFjDEu9q3t5QZIhEEcCFiBFguZRQBQa7g32fkXQmCY50RrfIr6rZAMcGR+eZUS521wck1x10g== X-Received: by 2002:a05:600c:4f42:b0:434:fa55:eb56 with SMTP id 5b1f17b1804b1-438913cf805mr119456415e9.7.1737369589327; Mon, 20 Jan 2025 02:39:49 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43890367b48sm133942685e9.0.2025.01.20.02.39.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 02:39:48 -0800 (PST) Message-ID: <0d09c028-d5ce-450e-ba04-b402e45aefea@redhat.com> Date: Mon, 20 Jan 2025 11:39:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v5 01/15] mm: Consolidate freeing of typed folios on final folio_put() To: Elliot Berman , Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, yu.c.zhang@linux.intel.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com References: <20250117163001.2326672-1-tabba@google.com> <20250117163001.2326672-2-tabba@google.com> <20250117135917364-0800.eberman@hu-eberman-lv.qualcomm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250117135917364-0800.eberman@hu-eberman-lv.qualcomm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TXXbxIxLJdSOyPzraTnSf8jqhfQMIM1w_S-qHP6kTo0_1737369590 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D2CC0C000C X-Stat-Signature: ddb55u4p6othktiodboxa6zgbsd3xwpt X-Rspam-User: X-HE-Tag: 1737369594-72931 X-HE-Meta: U2FsdGVkX1+HEEJbfgUB1k4Xr66vqpkUcyUR4V32LEDwMxZsWn1RNXtWtRtUI5d/WF7i6Og8rNKtT8228qv9yu9rLMzZXAzQQbMGPlwtLf2J4k7zgIZGJxFFy24oonndsxY9XApeKPE6elBUHjEQXfAEuFwi35X2r0Y+6+Vu57RownWpOJrBSPcEaIOKCa87XgHTTTyE+kyElYeHZsYglVFMHAVeUTAhG2slXoFqD+ZwQDf2Va3YvRyePmG5+Rg/fL01MZ4KqceM3PfLP43eMxG0IhY3hB1ioylT15v8RkBkynCSZQGI1LBxzYskAm/Klnh8wZ0+a+8xowrB1bzIVZl+xWFlzwt1cBHKyS+jHxWA8n9ouyNRkXSM3IGoj38M3Ivx6ZMux/lLM+DMt6GVM91kVrbJDuCaIEyFH26zP8EFrWwfXORdrJBHPwT8IQXNtuWbPxGKPHbW5hgZOxd4WU/q7/gXKKlNaEm5PtQp4nSk/tbQKMGIJ7fQvzxQa+pp5zv9TewG4y/BGeZDmE0+WkE6uMPkRYFh6M5k8HSZ+Ojl3vjgsIaEVC8h0I1rcDTqfhKcbR7HY1TkGWpcfa4nmhgE/ZOJhiGiqugKU6jszBenWCF8s0oDLFQ5HwkPEhA0gv0TZ6Ut4jfCODVPQJozRYn0QO+2conMCj/HPbMlJSuetJIHh2aUN5UzxoL8tIQgJMvJPmgzwBuX9Ejvb3eyEvUXtDFy1GfbhQcscpG8RQT3ObxVRgtnkd9hjt+wfnLs26Bxuaxu2xoepRUjDZWhIJZ9FttN1bxgQxtZ43JgUmTwJ+sI3wgWtwNOGOp/rOJrSmDfsgA0HoQibr/sveaF5EAVBZ7d+GzPYxocye/aXc25mi0Ct4OO32LsYiN6Bs2i8Ej6occihf7w+LCaRbE0oNkRVPXX28J6xbN2Bln2wlvKr1gAoU6c4GYz8kwwJUDFiBoxHd9mvkvD5d/BeRJ uc7CeyaR r7tX4sGhNskZ8RAtDd8ZThU5YUBpwnL9rxujsNd+JKRTgBsAIy98dDlU1GydGfMQ+TS59aS//bJK0zfHXGV6CWXCx6sDbIhgMTUctDc04vw3VyVY+8RkOcJtSHg3p+OoRKlVXQYmekMlZrKkb/QcJZk/Var/ZwH770X8PmzdMU2lcDlNUo6VH9JcZVJTuOL1kkQ+ZaOSWQ617orSSakRKBiu7SLwnOFLh/vafZ3a81opaScBYWYSIrcrK1Br3+3SSZdKg/dYBdhRvnELGff+8uDrgCBqTnTrcDzsBaxlPNjTI6qrxdFi8p+Cv3kzDWA4RVplEWEXzLG6TLZUB/qALo/eQtjKRVfDti7wQLtdTmDXyA47sDpus3Ocm07GIkk9sxKeMwsTBsdWQMN9yeAHv8iL/VdOwmVhkNLy3yydkF1gOitnU78HPZ55vD8xHANjcBSYnpGK86jdIvo29pPXr68KqRilvuAyMBdDw5u0BgyhbSW84hSGHACHwiE8ptgoOif4yDyQ+ZURrtSMKEh+NN0cEmtKBQ40+2IsdZQZ46+G5/vR8ihGXbyBSqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.01.25 23:05, Elliot Berman wrote: > On Fri, Jan 17, 2025 at 04:29:47PM +0000, Fuad Tabba wrote: >> Some folio types, such as hugetlb, handle freeing their own >> folios. Moreover, guest_memfd will require being notified once a >> folio's reference count reaches 0 to facilitate shared to private >> folio conversion, without the folio actually being freed at that >> point. >> >> As a first step towards that, this patch consolidates freeing >> folios that have a type. The first user is hugetlb folios. Later >> in this patch series, guest_memfd will become the second user of >> this. >> >> Suggested-by: David Hildenbrand >> Signed-off-by: Fuad Tabba >> --- >> include/linux/page-flags.h | 15 +++++++++++++++ >> mm/swap.c | 24 +++++++++++++++++++----- >> 2 files changed, 34 insertions(+), 5 deletions(-) >> >> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h >> index 691506bdf2c5..6615f2f59144 100644 >> --- a/include/linux/page-flags.h >> +++ b/include/linux/page-flags.h >> @@ -962,6 +962,21 @@ static inline bool page_has_type(const struct page *page) >> return page_mapcount_is_type(data_race(page->page_type)); >> } >> >> +static inline int page_get_type(const struct page *page) >> +{ >> + return page->page_type >> 24; >> +} >> + >> +static inline bool folio_has_type(const struct folio *folio) >> +{ >> + return page_has_type(&folio->page); >> +} >> + >> +static inline int folio_get_type(const struct folio *folio) >> +{ >> + return page_get_type(&folio->page); >> +} >> + >> #define FOLIO_TYPE_OPS(lname, fname) \ >> static __always_inline bool folio_test_##fname(const struct folio *folio) \ >> { \ >> diff --git a/mm/swap.c b/mm/swap.c >> index 10decd9dffa1..6f01b56bce13 100644 >> --- a/mm/swap.c >> +++ b/mm/swap.c >> @@ -94,6 +94,20 @@ static void page_cache_release(struct folio *folio) >> unlock_page_lruvec_irqrestore(lruvec, flags); >> } >> >> +static void free_typed_folio(struct folio *folio) >> +{ >> + switch (folio_get_type(folio)) { > > I think you need: > > +#if IS_ENABLED(CONFIG_HUGETLBFS) >> + case PGTY_hugetlb: >> + free_huge_folio(folio); >> + return; > +#endif > > I think this worked before because folio_test_hugetlb was defined by: > FOLIO_TEST_FLAG_FALSE(hugetlb) > and evidently compiler optimizes out the free_huge_folio(folio) before > linking. Likely, we should be using case PGTY_hugetlb: if(IF_ENABLED(CONFIG_HUGETLBFS)) free_huge_folio(folio); return: if possible (I assume so). -- Cheers, David / dhildenb