From: Dave Hansen <dave.hansen@intel.com>
To: Lee Jones <lee@kernel.org>, Peter Zijlstra <peterz@infradead.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: x86: pgtable / kaslr initialisation (OOB) help
Date: Wed, 14 Jun 2023 07:45:24 -0700 [thread overview]
Message-ID: <0cefb67a-6fae-daa2-c871-ae35b96aac08@intel.com> (raw)
In-Reply-To: <20230614143732.GW3635807@google.com>
On 6/14/23 07:37, Lee Jones wrote:
> Still unsure how we (the kernel) can/should write to an area of memory
> that does not belong to it. Should we allocate enough memory
> (2*PAGE_SIZE? rather than 8-Bytes) for trampoline_pgd_entry to consume
> in a more sane way?
No.
I think this:
set_pgd(&trampoline_pgd_entry,
__pgd(_KERNPG_TABLE | __pa(p4d_page_tramp)));
is bogus-ish. set_pgd() wants to operate on a pgd_t inside a pgd
*PAGE*. But it's just being pointed at a single _entry_. The address
of 'trampoline_pgd_entry' in your case also just (unfortunately)
happens to pass the:
__pti_set_user_pgtbl -> pgdp_maps_userspace()
test. I _think_ we want these to just be something like:
trampoline_pgd_entry = __pgd(_KERNPG_TABLE |
__pa(p4d_page_tramp);
That'll keep us away from all of the set_pgd()-induced nastiness.
next prev parent reply other threads:[~2023-06-14 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 13:23 Lee Jones
2023-06-14 14:16 ` Peter Zijlstra
2023-06-14 14:37 ` Lee Jones
2023-06-14 14:45 ` Dave Hansen [this message]
2023-06-14 15:06 ` Lee Jones
2023-06-14 15:10 ` Lee Jones
2023-06-14 15:26 ` Lee Jones
2023-06-14 16:01 ` Dave Hansen
2023-06-14 16:09 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cefb67a-6fae-daa2-c871-ae35b96aac08@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox