From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EEBAC54E90 for ; Fri, 23 May 2025 03:43:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2A456B0088; Thu, 22 May 2025 23:43:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B013C6B0099; Thu, 22 May 2025 23:43:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A19736B00A8; Thu, 22 May 2025 23:43:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 847C26B0088 for ; Thu, 22 May 2025 23:43:39 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2CE861D45B8 for ; Fri, 23 May 2025 03:43:39 +0000 (UTC) X-FDA: 83472778158.11.6EB7312 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf05.hostedemail.com (Postfix) with ESMTP id 62A17100002 for ; Fri, 23 May 2025 03:43:36 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=dgE7mYf1; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf05.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747971817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J05dvsnqUxHvTInzLD4bICl0NDkAyj3stBB+zRj5LSA=; b=FbI279dTcJBG4Xr1y+OoZNyOBm0LKGAtazGBE4PfocInFazW9E5PTrTUy1uTZFHq3BuLn6 LgiDgCLGBoJ30xJK2F4oIASb0WUeY1TlskuTX94+Tvd+owRHSlZ8342m5fcrWzx0ZjrvDg x0CceSYA5ZQgpTlpiQqXnQoch+HqUOw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747971817; a=rsa-sha256; cv=none; b=u6IlSMeTeZlKJLcFKIodzGvHAi8Y+rMrPn5R6oLjw96FzB1YVzO0uRgadpvi3QUXOq/g+W U9AD9rcVyuaqFGyXgB+RJGpcyldqCDD5q8anK5y/1KxdSr74prEPgrugeJBL0b/oah/Ax+ Y2dXi2bGbtPCucnmnJVeAARroMJmDqc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=dgE7mYf1; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf05.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-ae727e87c26so5210994a12.0 for ; Thu, 22 May 2025 20:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1747971815; x=1748576615; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=J05dvsnqUxHvTInzLD4bICl0NDkAyj3stBB+zRj5LSA=; b=dgE7mYf1OJuLZYiCx4QT/Uo2BTi0E/O5mN9s10PUfqjoR2X0ZodsN5r8MaLJjdOtqK Ogcj4PKOY1Qs+498xKYn49NZ/tLrIn1BWhQsghej8aFREw6Teb5Up2hY3HniHxtFh+gO lJ0f56+Vel5SD1QluWYDbQ8wum/gdDMUAeJChWwQ1B23WnrApkpCmM4qRT1VXgRvo+iD Mt7HYGKqMivHh0wg2hg8ORek9CeKvJYlENP5IywcrfsGSbyQqVriKGwT8DB8ndX/85po RKD/3J8QEkQDnUu6/e5Zj5sP5ZQichcd60Q0wjFEFcAzqMg3ykwuz5gAP6r7P6TPFTVy 2hbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747971815; x=1748576615; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=J05dvsnqUxHvTInzLD4bICl0NDkAyj3stBB+zRj5LSA=; b=Kx58B9enEfYAD9AeFTwtZiieSkxmrADyQbO5NNXcjU/k+Gi31toOVgHGjkp1oAZCcL 5j/94FYEC+wXFtMpwAuQKQ/TxRB3seKy+ZkmwAZcuTu0gH/cVp5JjD1z6Q5tyaanWequ 5ncEo7G3grxJTVjWHe5asZz3v2EVdf1WmaqRuz5QrlmAlNq3Bhy7InLNLQ/U3SdccF70 g9LPiNsEDzxaI41T2Xy1Ujji74fwrPRZ4iPk58aqlWy+yQ5YV/f6Odr24cnR1Y07DQyj wC1rYY96YBXKQSaIoDxeoOxKeJ6uUYvkq3/AEZ1d+OYS3Cfv5Mfk51qq7ColB6GYXEJS V8KQ== X-Forwarded-Encrypted: i=1; AJvYcCWzhFEl030Wev6hwJd7D+g5BYEdwfcNzsC+gQHd0QJekdKZ6M3PR25WkJcE/A1kRbQ9LHgP1mL8GA==@kvack.org X-Gm-Message-State: AOJu0Yywc8WzJOMj9vIf78XdSejN6PjuxK5NYc3DQYiHWriTw5owWkna /ZcQLXJGKBRiuNX0g1vdaPTrR2O7sfwfqZBVSJeM7Avq/nAG18uMsURGT6OyAX3JYqk= X-Gm-Gg: ASbGncsv0bFC9Vi3Z82YeyXONMRdmrRUntTJ4uC929suwmC6EPa/XwxZotzJrqSLsNr atVkqKkWdxz0vZbcQC3EP2r8JAZfesjn1BT0+2T8H7K7I7U5h7YfYM8ZwTn5KoDGstupWb7TZUa 0FrIo/J/sDlasWZgc9vebONHC6WU20Htr6o2lsqn7lcrGR/5knsQ2F5q4b4U8IqL0AFFLLB1X4g nR2tzLlj2sAcxx9vDxOnjKvm4ygunsBD+1ZDF/yS+N43S4ZPkzcEE2Cu9ZAi/ktwlQVJ6H0f6bn vWXLWENmsuEzFlyjdJ2sbt81xP4+cYT72bqhXHDu+8hNiOuJQWwOfquxR3aOP3jC8fIZr1kamIk iqpP+OJxtFw== X-Google-Smtp-Source: AGHT+IFJUa2ZA4G+IYco+Be+FUJVLivd3f5/OkH9AHpXW8S/SRBQ8SwylmKbpKD7GepKWMTvQ7YN5g== X-Received: by 2002:a17:902:c951:b0:220:c911:3f60 with SMTP id d9443c01a7336-231d454eb37mr342440245ad.47.1747971815006; Thu, 22 May 2025 20:43:35 -0700 (PDT) Received: from [10.68.122.90] ([63.216.146.178]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-231d4ac948asm115132435ad.22.2025.05.22.20.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 May 2025 20:43:34 -0700 (PDT) Message-ID: <0cdf967f-9606-4d12-9ea3-140f9bffe516@bytedance.com> Date: Fri, 23 May 2025 11:43:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mmu_notifiers: remove leftover stub macros To: Jann Horn Cc: Andrew Morton , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jason Gunthorpe References: <20250523-mmu-notifier-cleanup-unused-v1-1-cc1f47ebec33@google.com> From: Qi Zheng In-Reply-To: <20250523-mmu-notifier-cleanup-unused-v1-1-cc1f47ebec33@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 62A17100002 X-Stat-Signature: n157c1ngsdz6sx4bynm4cfzscxkew5rj X-Rspam-User: X-HE-Tag: 1747971816-393347 X-HE-Meta: U2FsdGVkX19lOfZtWtpXcpo9AsDZIpzCgb/OseRaadGdiPOsWwtafW6+xUIRIoIO7Y5+3SRA0fa/mSdW4PmktR8PstS6rxrISnlNInGFSFBhlXt7C17dgiGA0RVR0ry08CqWCZMFxjqZVYeD9V2zKiGbMpzlHnpE+UlA1cEl/vZkWHDccqEM3NT/uurrIkTuaH8wdp+aX+dL+NzUqM5Q1qIcbdyKe5gz2QtxSYBflA4OnVmc93gDQtUOkMg0h9u41UqN38Zadwp2pR7hbZY7kcBmDESV8E+VrmEMJibYxwJIVqnNuzeBEv10M34oi3tuNgm3dTUnWA56383Jzic97l/9w/JMSSARe45sgLJkCI5qdslQUtzcozLcYmhRJKK1NeuXVg1n3i2r3PxJwf43OqZ9zHSvf3/aVWBQJe4zo+75rIFvdLJs9YJZb7BuMZQzKEpFIenmFHOstWXGBh2IFKfydvdo0xgCacpPf35Tdy7tA5Lmc0QYgDKwiLNOXQIBG4w+FOeSciV/7+hzq6gR+7SWLHL7d5Vbdj/FWKGG+nFAnQndSHNSXRPQsCnA2PRYsDHSFhIOxyGHc0ND2Oc3ktIynluaVjjkJUa7MdFIGRRx3O7wGIGyJQN8+DhRVTy4z5s7uUWFUdaIZSjA/5KOkxzWxbdc9jUYQnKTnx+r0q4GvnegHZ59o0Wfcea4ox2yI6wtVtSlJETulbNZAwpkfIIxytE+7lTcYYpTJbb1IO8t6q+f882y8vL4sJxKy3j9XUO9fQkWL4Je/BA5b4g2ymoAa6tfaHbZr0Y5jQGbLY62/MGlhqKST18FROyPBvaP/oTse3HKGozaEyP9G7FZBLwpogEownibgoh02uN2Zc0i83DI9SkjjQmf4sYCCQJanmMG3TSdtXpWzueApl+i5BZ6kw/m2GQPOZpN96f9MZOUGZq/x4ISnOe1Zljfwjlt6zUZWs/bTgdQ+05LOhb q2GVXvhf CqmyIMzJUGuM6Fl63vzd5wByEI2jppJ8rGFMg8cAlbWYr9Y+HYUcxQQYPZTVWBNOxfhLMZeILCsHUyydE0S0bq16RLEIDHsWQr6vKXbh4Ig2RDAhMdVWuQA8rXre19gOfs9qKuFztb1innYEoCKZyzcj+AT6yMltTDvzPlsAJ3tklB8rMeNouGse/e3KF77257laiyMh7VyZRhc8QxV0m13z/BnWyV2+jDwcTFF9K1CqyZnrGWZsICN7JuxzDkv91gjIS6sgVymK9tgik9njQcO9O1pEymCMgBwXHZYHC9IaIxOVHC3xe33vJ+/qhRkwzs4Mo6ldUyiHVA3KaYOBqlK1riQhOvg1Px1CcMlr8yV/aVBR4joudO+18vOtMqxBhqGWOy1rSzV48wgQLsMcs5yYcu/mCcqChW+2IlwZ12oGA3Vg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/23/25 6:30 AM, Jann Horn wrote: > Commit ec8832d007cb ("mmu_notifiers: don't invalidate secondary TLBs as > part of mmu_notifier_invalidate_range_end()") removed the main definitions > of {ptep,pmdp_huge,pudp_huge}_clear_flush_notify; just their > !CONFIG_MMU_NOTIFIER stubs are left behind, remove them. > > Signed-off-by: Jann Horn > --- > include/linux/mmu_notifier.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h > index bc2402a45741..d1094c2d5fb6 100644 > --- a/include/linux/mmu_notifier.h > +++ b/include/linux/mmu_notifier.h > @@ -654,9 +654,6 @@ static inline void mmu_notifier_subscriptions_destroy(struct mm_struct *mm) > #define pmdp_clear_flush_young_notify pmdp_clear_flush_young > #define ptep_clear_young_notify ptep_test_and_clear_young > #define pmdp_clear_young_notify pmdp_test_and_clear_young > -#define ptep_clear_flush_notify ptep_clear_flush > -#define pmdp_huge_clear_flush_notify pmdp_huge_clear_flush > -#define pudp_huge_clear_flush_notify pudp_huge_clear_flush Reviewed-by: Qi Zheng Thanks! > > static inline void mmu_notifier_synchronize(void) > { > > --- > base-commit: e85dea591fbf900330c796579314bfb7cc399d31 > change-id: 20250523-mmu-notifier-cleanup-unused-238762302a66 >