From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52B1BCD1284 for ; Thu, 4 Apr 2024 14:01:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD8596B0093; Thu, 4 Apr 2024 10:01:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D88896B0095; Thu, 4 Apr 2024 10:01:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C29E36B0098; Thu, 4 Apr 2024 10:01:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A14116B0093 for ; Thu, 4 Apr 2024 10:01:43 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 901ED410A8 for ; Thu, 4 Apr 2024 14:01:35 +0000 (UTC) X-FDA: 81972012150.14.283BF6F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf21.hostedemail.com (Postfix) with ESMTP id 0DCD71C006F for ; Thu, 4 Apr 2024 14:01:19 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QLRSbCL8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FvIUNKYu; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QLRSbCL8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FvIUNKYu; dmarc=none; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712239280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CJEO95T5eOAEaEClQ5YGYGSrxqK8HX7WCJ8QTLjd03g=; b=5ROM7r03m8sckSAS29FWu8l7/VQmybFJStOEZW8WuSqzHdPHIOcNw7gTfV5Yqb4wtzk2RD JB8QWnqprxeCMEFbaVcaxD/cLvcgznIdsyFW1ywylGaJ/j5WtmTj4KTb+kJb3sgSPThYoe pJkr3grS0tTWmRUKmPjFR/Gll73ul6w= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QLRSbCL8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FvIUNKYu; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=QLRSbCL8; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=FvIUNKYu; dmarc=none; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712239280; a=rsa-sha256; cv=none; b=5GpxA/kXCDkR+dM3N5jqTkegiebOqgZqtrWgxWPgaZRITFij8XSjHLuF4+RjwrMheAligu QV6w6d/Tt3aW8viyMUdiuVU+NluVrSSs818kAvQ2qkOtsjruAHo6G0sYcGSKRmL/3XNE7f 82gK+W9Pagq0T9byRpndaMMn+odENnc= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B00CE5F787; Thu, 4 Apr 2024 14:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712239278; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CJEO95T5eOAEaEClQ5YGYGSrxqK8HX7WCJ8QTLjd03g=; b=QLRSbCL8nMogPk3Fs4XrLUkeJexg4Dr8UEDnFG7dow1kuSQgI1qPAjnbZSXMuw2wzktbC/ bDw7xJfAniCk5YSd5DiWvAn3dPtlibe7+h7H0ALAQMEGcUtDmPN4MPQjaA0a3p7pfNersH +45jFveJIs8p+3OXiuuDrxiQ207iDoo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712239278; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CJEO95T5eOAEaEClQ5YGYGSrxqK8HX7WCJ8QTLjd03g=; b=FvIUNKYusS0KxWFeO94ePJQnUmhCeQTigCEmJ3ioDT/k+u8ygenr2eMe9eBeWcvznN2m2X fiz933Df2pGoDhDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1712239278; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CJEO95T5eOAEaEClQ5YGYGSrxqK8HX7WCJ8QTLjd03g=; b=QLRSbCL8nMogPk3Fs4XrLUkeJexg4Dr8UEDnFG7dow1kuSQgI1qPAjnbZSXMuw2wzktbC/ bDw7xJfAniCk5YSd5DiWvAn3dPtlibe7+h7H0ALAQMEGcUtDmPN4MPQjaA0a3p7pfNersH +45jFveJIs8p+3OXiuuDrxiQ207iDoo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1712239278; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CJEO95T5eOAEaEClQ5YGYGSrxqK8HX7WCJ8QTLjd03g=; b=FvIUNKYusS0KxWFeO94ePJQnUmhCeQTigCEmJ3ioDT/k+u8ygenr2eMe9eBeWcvznN2m2X fiz933Df2pGoDhDQ== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id A283813298; Thu, 4 Apr 2024 14:01:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id sqdiJ66yDmaifgAAn2gu4w (envelope-from ); Thu, 04 Apr 2024 14:01:18 +0000 Message-ID: <0cbd9644-5900-4f02-adf8-d3f1182d399b@suse.cz> Date: Thu, 4 Apr 2024 16:01:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: page_alloc: use the correct THP order for THP PCP Content-Language: en-US To: Baolin Wang , akpm@linux-foundation.org Cc: mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <76457ec5-d789-449b-b8ca-dcb6ceb12445@suse.cz> <30bef3d6-3381-491e-a00a-bd1fb7e8d8f8@linux.alibaba.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <30bef3d6-3381-491e-a00a-bd1fb7e8d8f8@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: u8w1h8ifnsgtzrhy73bhxs6zdpugm9d6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0DCD71C006F X-HE-Tag: 1712239279-433633 X-HE-Meta: U2FsdGVkX1/eQFfcCTg8lOduH/4J4Kf8c+0vyj5pzZBFzjUeuNPxkKWH4fcOVG9s2qeVH0rSj/Uk6DOtv9ZyOfb5r0wIkc6gQOoKwfLD5REkCZIBVHoPNm95e2sHVhCotqyka0Mf2qklXg9mhqlkhsaR9rfZV1HCjmY+rwCf/SybpJXWsTzPFmuGQwdPdZuSR8Xl7rH00JDJ/klS5BQOkDAkjevdr49DuBw4+skKFGqshm0IuJsF1UqzDm0OKrd7xIogxyFwnhOnyXjZoAmAx2BF/WC3wLq4xaqY793QrHGVyWnbLTMNhrsuNQN7ePG3oORkA4uA6aX5/wICD3zvJaRrWL2IYh8yNFlKom8EyTh2DyTcixu3eMdPwVpAs1LK9YtK0FNFc44voTPT86U1uuDCV43QnmOgX4t80uXC1f4eUyL1X29aUY+1n+FaQBq90dzggnNbss56dPFjaYML4NZMRgBdN/TcUExyqQKvTg8jEm2XJmpHxmp409ViXinMIi5tojMH1FwlT/pqim2s1XxQTpvkiTeY/ZsRg83moNmf4U0Pu9tjvGQqRkl7pc83jPRUT2NYbOSCz9WOWpO5se36zfNc9xd8t9p+598bZG8C8ueRW8Ziwi1a4HU/vgsus8HRaqKNYNfDIxXvPe01obAa6MzR6mo3sdqd6JMl7Vnu6VEMxEps1Xkicj0pk4PqXO1NydvOUNZHu0XtYo1VaXmwmsiwm1QMfgNp2lBXL4XWA5AJCy2iB4d7Ux/jXlEn1tO+Sobp37Y7p2JMK7MCDx1iACzne70YY9AFXcWx50syDOPU4AILIdfhh6d0idZKo81QgaKy0STDgptUz9pZvor7+CRwGRmL0FdAuO3r6+LK3uAg59IWYxtmWtT1No0BGmziJ2hehHzloRfJ72wZYJotZDw/mU8JICjyBDf+fmQ/MrmG/XfnoTlklG+HHY6pmDTjk2yMqZio2iPCLiH MIHq/oIw praMu6hWtbyWrvqJuhdzLvRnLg1Navd0wjSceKHsExDeFvQFGg9nnIYp+u5YJqzi3pT6y+tDx+yoHfU4oy5OazQj1mNqNtnDojYbMoXJC4fAWrwTFlKjAAR4Wa4eXpG1D0lqShFFqPQx/eNdfxUtmQx7g7jhE1HbtpJkgkorRWi4lOneypJDpLnhToaeArD4+iiGcFMjvHoV3T54BmF6xuIwNNhuBXrYKHl5k/hPBvfKbhS9gwzVcbKk06U9rsjH7SUHz6S1bkWTgLQwKyYZrZMojosqXM6kQnIl3WuL+FcmkT1kVHOv6rugh85ky2ZJe8P9kgCnH7tf+KzU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/4/24 2:19 PM, Baolin Wang wrote: > > > On 2024/4/4 18:03, Vlastimil Babka wrote: >> On 4/3/24 3:47 PM, Baolin Wang wrote: >>> Commit 44042b449872 ("mm/page_alloc: allow high-order pages to be stored >>> on the per-cpu lists") extends the PCP allocator to store THP pages, and >>> it determines whether to cache THP pags in PCP by comparing with pageblock_order. >>> But the pageblock_order is not always equal to THP order, it might also >>> be MAX_PAGE_ORDER, which could prevent PCP from caching THP pages. >>> >>> Therefore, using HPAGE_PMD_ORDER instead to determine the need for caching >>> THP for PCP can fix this issue >>> >>> Fixes: 44042b449872 ("mm/page_alloc: allow high-order pages to be stored on the per-cpu lists") >>> Signed-off-by: Baolin Wang >> >> IIUC this happens with CONFIG_HUGETLB_PAGE disabled because HUGETLBFS is >> disabled? But THPs are still enabled? I think there might be more of THP > > Right, and seems the Powerpc arch will set pageblock_order via > set_pageblock_order() when the huge page sizes are variable (not sure if > this is always equal to THP order). > > Moreover, it still does not make sense to use pageblock_order to > indicate a THP page, especially when we already have HPAGE_PMD_ORDER to > represent THP. > >> working suboptimally in that case with pageblock_order being larger >> (MAX_PAGE_ORDER). >> >> In other words, should be rather make pageblock_order itself defined as >> >> min_t(unsigned int, HPAGE_PMD_ORDER, MAX_PAGE_ORDER) >> >> in case with !CONFIG_HUGETLB_PAGE but THP enabled. > > Yes, this makes sense to me (I wonder why this wasn't done before?). I > can create a seperate patch to do this, what do you think? Thanks. It probably wasn't anticipated that hugetlbfs would be disabled and THP enabled. If you can create such patch, great!