From: "Gupta, Pankaj" <pankaj.gupta@amd.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
dan.j.williams@intel.com, thomas.lendacky@amd.com
Subject: Re: [PATCH] mm/memremap.c: map FS_DAX device memory as decrypted
Date: Thu, 3 Nov 2022 08:55:40 +0100 [thread overview]
Message-ID: <0cbbe205-4573-2dce-14bf-f07c117ac7af@amd.com> (raw)
In-Reply-To: <20221102130536.96c487d341544b7482eed038@linux-foundation.org>
Hi Andrew,
>> virtio_pmem use devm_memremap_pages() to map the device memory.
>> By default this memory is mapped as encrypted with SEV. Guest
>> reboot changes the current encryption key and guest no longer
>> properly decrypts the FSDAX device meta data.
>>
>> Mark the corresponding device memory region for FSDAX devices
>> (mapped with memremap_pages) as decrypted to retain the persistent
>> memory property.
>>
>> ...
>>
>> --- a/mm/memremap.c
>> +++ b/mm/memremap.c
>> @@ -335,6 +335,7 @@ void *memremap_pages(struct dev_pagemap *pgmap, int nid)
>> WARN(1, "File system DAX not supported\n");
>> return ERR_PTR(-EINVAL);
>> }
>> + params.pgprot = pgprot_decrypted(params.pgprot);
>> break;
>> case MEMORY_DEVICE_GENERIC:
>> break;
>
> Should this be backported into earlier kernels?
Yes, kernel >= 5.10 for clean back-port as it contains the below commit.
>
> Is b7b3c01b19159 a suitable Fixes: target?
Not very sure. But seems like the right commit for fixes tag as the
target code is moved in this commit with multiple range support addition.
Should I send a v2 with fixes & stable kernel fixes tag?
Thanks,
Pankaj
next prev parent reply other threads:[~2022-11-03 7:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 16:07 Pankaj Gupta
2022-11-02 19:03 ` Gupta, Pankaj
2022-11-02 20:05 ` Andrew Morton
2022-11-03 7:55 ` Gupta, Pankaj [this message]
2022-11-04 23:32 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cbbe205-4573-2dce-14bf-f07c117ac7af@amd.com \
--to=pankaj.gupta@amd.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox