From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7F59C982CF for ; Fri, 16 Jan 2026 15:14:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 599D76B00A5; Fri, 16 Jan 2026 10:14:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5717A6B00A6; Fri, 16 Jan 2026 10:14:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 445486B00A7; Fri, 16 Jan 2026 10:14:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2E6DA6B00A5 for ; Fri, 16 Jan 2026 10:14:05 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 02BDCB60B1 for ; Fri, 16 Jan 2026 15:14:04 +0000 (UTC) X-FDA: 84338172450.14.9A85DDE Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf06.hostedemail.com (Postfix) with ESMTP id 571F5180004 for ; Fri, 16 Jan 2026 15:14:02 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sOQIWvxj; spf=pass (imf06.hostedemail.com: domain of jlayton@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1768576442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XoBRHt16IJ3n5doYM6de0GyIKu5/7IipaX4IaeHvHjw=; b=ysZOa8v1Ywh5Bq0iinzb3Ys7EYpwT6WkqnIyslaf8LwCMHxHP/gMETzn/3gDOnU6msvvZ1 clJBwobEqxbXQGtBKBc0mm9FlwamS+8GAerfhjIDUbn4Vg7QqumsDDejRzard2Chw33udF xw1pADJHnwefx+f/M5ix6SJZvxYZcPM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sOQIWvxj; spf=pass (imf06.hostedemail.com: domain of jlayton@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1768576442; a=rsa-sha256; cv=none; b=CjPl0D2+H+k5emsqEhE51YwtGgQPC9UZ1zTsOJ4kf04ktFk3AX5TCnoRBpc3H3Db1qL+09 YuwGhJL5zZhity+b7NQUr3kVuXiH8vJtR1QLM9qzNTnDRlc8HztQymczWEAipF2OsM5rw3 Te+R5yd9XiBB0xKigew8+N2YrWPZMq8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 5A89F60150; Fri, 16 Jan 2026 15:14:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83716C116C6; Fri, 16 Jan 2026 15:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768576441; bh=tpTMvFa8WoYlxudKpX8gL9LyC0nYKPD87OgBqTCF7oo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=sOQIWvxjf0X9zTvo0MmiqKYnTp+VBuPh77NyyR+yp5oT+0zUR5rdA3BVyP4ki9RIP 19DMhEVaTdYW2BmN5vSBmlzFAefvTdRUypqyC1egnFSeEfmhbgdTa9n1Hkq7gezA3g 9/lmcXHh0NTrBy6CHRHSZh+7fo/g25F8IyeVGyEJ7Fku2hDbmPX17KntFgZI2Rqjg6 v1Lg2MSxy9d4Q3s3cmJd69FTkh8YcxZWqBU51gjheg0LEUOmR8Og9VIOlE5YZt7u7x Ngtrq6Dy3tNyRlI8hYjdERDhJv0B8nd7wRVN4T4pwG3HCF4Sj/LJ/RymfJ/xVm1Qzz RQtOpfQqnuLcg== Message-ID: <0cb769af0673ea1c28df7fa9a1cefe3ec23bc367.camel@kernel.org> Subject: Re: [PATCH 29/29] nfsd: only allow filesystems that set EXPORT_OP_STABLE_HANDLES From: Jeff Layton To: Amir Goldstein Cc: Christian Brauner , Alexander Viro , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Hugh Dickins , Baolin Wang , Andrew Morton , Theodore Ts'o , Andreas Dilger , Jan Kara , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Carlos Maiolino , Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko , Chris Mason , David Sterba , Luis de Bethencourt , Salah Triki , Phillip Lougher , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Miklos Szeredi , Mike Marshall , Martin Brandenburg , Mark Fasheh , Joel Becker , Joseph Qi , Konstantin Komarov , Ryusuke Konishi , Trond Myklebust , Anna Schumaker , Dave Kleikamp , David Woodhouse , Richard Weinberger , Jan Kara , Andreas Gruenbacher , OGAWA Hirofumi , Jaegeuk Kim , Christoph Hellwig , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-unionfs@vger.kernel.org, devel@lists.orangefs.org, ocfs2-devel@lists.linux.dev, ntfs3@lists.linux.dev, linux-nilfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-mtd@lists.infradead.org, gfs2@lists.linux.dev, linux-f2fs-devel@lists.sourceforge.net Date: Fri, 16 Jan 2026 10:13:52 -0500 In-Reply-To: References: <20260115-exportfs-nfsd-v1-0-8e80160e3c0c@kernel.org> <20260115-exportfs-nfsd-v1-29-8e80160e3c0c@kernel.org> <8e4c3df4828351c677186bf018061f2b1fd1b48e.camel@kernel.org> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) MIME-Version: 1.0 X-Rspamd-Queue-Id: 571F5180004 X-Stat-Signature: e8xe1czd5ojbgiiffpdefzsa7p5o6rmn X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1768576442-34107 X-HE-Meta: U2FsdGVkX1+T/FTITO0kbxRgGEu1s/Y+lspLj8RP/6mvCTc1UN85fB+ehlRVOwMKAIv91UhG/TDUqJ8FVF03o8jQBysdlVCPF2IgvJiNE8pPzy5pr4H2TeXarZeCp9YdD2T1qg1H8++lqHe1DZ5Bf8dMc4p5TRBvP1VX/kZLR4HO6NXlQ4pPyJl1x/8uFWFlAAtIxa5twtn6DBcfdcnOLFLnIeUk3njbWkUUFWEf6+VHebbd/sttcRN7374sT6OFAkVom40jI+/1e3wlYgR23QlrXzVbw8ujeqV3Y1ixICLPOrYRQPBdazcjrbTRxOF5//8wDYppGMUgicWOuV+47Il9BiE7rYyFLAqr0uHqcQO1T525HMg/Yhn56qLwSW7L4zPYcbvg7SkpsCn3awJ/LhdETlW2SxfUYK2OhoDG4uIuWArWU3G3ygrE3iWXiOkHJOate7i7EZGLBslg4s4WJf9yE8+nVZlW5q+EM5u9/IX4RNOtBTikD9UOoFH2bz1vEr5JhBbogWpOI14qyynMnJHE++c6GICl4z15eFG0uFSEv0/VgaYEPttMHeCtpirk8e8tlZV6WF8kQPCeYFuKFaiNWHVvqif6NVgLlK+ldnvAeMJkBNvgYBBfZ8ZO+JI2OBZMcwkUsgup1Zj9OOiW8IDsoCcyjtlx1vyRY2zjwPqckpcgfVJZi+nwN1biosqlKNCPbDp9/2RQ+wCBz6U7sN2QnQ0uTitOC1mCNPJUDQ+EW1iQWQgS/9dcLgxBSt19c5uWZreBy8WLbtlEmkF8cQWMNM7iG58gUv4khu6UFfP5UpFmvw6hSq9VCuqwE8WcFbPfpXZvQFAZArjXjjuDFuxCCauLhGlorWH0Bka7llSNovcNG7/6XL6MwSo9IjXLquE70llUoP/HY3ElgegIHu2QmnMANpXrPgefGubqzAXlNSzfG8TaBddNuHrA8mdfyXC9Rgp/iDZNZBcG9IQ opGQrhqc 9DvF9q6P4S4IC0vi7O9V+A3c+2mmCy3KWWJp1CmRZXBBI32SorN5gObhCn2cnjHLihpusM2T8TJk2P4VfutdAleXTugjiM1QgJRE4NDs9qw21KRkuyrh2LFQnlDGM5ISw6AKsae/GPwRPr0qZ4F9ejEuxfksk4XOmx0a4f1RjoT7W8scDnJATAmCQtDzpclYN0Qw0IgirPPDkALpVoFZtq3Fm7HAqRjf4b/rQDHNjTZPiD+GZoOZyyWBrluGy/bKUTCTlVe+wpJapixG0fTxGZ0KdkTItpPDNPMpIHKGP/0/m/VV39bSYkRVhhYvMPosVCSnXd0/IamiUcyqXchkwCruSBUP0HRk4tSCYN4OgbQdL10tX5xX6Ls8EH3pdIOA2+QVruWKAOGNXgGQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2026-01-16 at 15:46 +0100, Amir Goldstein wrote: > On Fri, Jan 16, 2026 at 1:36=E2=80=AFPM Jeff Layton = wrote: > >=20 > > On Thu, 2026-01-15 at 20:23 +0100, Amir Goldstein wrote: > > > On Thu, Jan 15, 2026 at 6:51=E2=80=AFPM Jeff Layton wrote: > > > >=20 > > > > Some filesystems have grown export operations in order to provide > > > > filehandles for local usage. Some of these filesystems are unsuitab= le > > > > for use with nfsd, since their filehandles are not persistent acros= s > > > > reboots. > > > >=20 > > > > In __fh_verify, check whether EXPORT_OP_STABLE_HANDLES is set > > > > and return nfserr_stale if it isn't. > > > >=20 > > > > Signed-off-by: Jeff Layton > > > > --- > > > > fs/nfsd/nfsfh.c | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > >=20 > > > > diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c > > > > index ed85dd43da18e6d4c4667ff14dc035f2eacff1d6..da9d5fb2e6613c27071= 95da2e8678b3fcb3d444d 100644 > > > > --- a/fs/nfsd/nfsfh.c > > > > +++ b/fs/nfsd/nfsfh.c > > > > @@ -334,6 +334,10 @@ __fh_verify(struct svc_rqst *rqstp, > > > > dentry =3D fhp->fh_dentry; > > > > exp =3D fhp->fh_export; > > > >=20 > > > > + error =3D nfserr_stale; > > > > + if (!(dentry->d_sb->s_export_op->flags & EXPORT_OP_STABLE_H= ANDLES)) > > > > + goto out; > > > > + > > > > trace_nfsd_fh_verify(rqstp, fhp, type, access); > > > >=20 > > >=20 > > > IDGI. Don't you want to deny the export of those fs in check_export(= )? > > > By the same logic that check_export() checks for can_decode_fh() > > > not for can_encode_fh(). > > >=20 > >=20 > > It certainly won't hurt to add a check for this to check_export(), and > > I've gone ahead and done so. To be clear, doing that won't prevent the > > filesystem from being exported, but you will get a warning like this > > when you try: > >=20 > > exportfs: /sys/fs/cgroup does not support NFS export > >=20 > > That export will still show up in mountd though, so this is just a > > warning. Trying to mount it though will fail. > >=20 >=20 > Oh, I did not know. What an odd user experience. > Anyway, better than no warning at all. >=20 Indeed. The catch is that this won't catch all scenarios where that fs could be exported. If you do something like this in /etc/exports: / *(rw,crossmnt,insecure,no_root_squash) ...you won't see a warning. Granted, doing the above is _dumb_ but it illustrates that it's not possible to completely vet the export table. Even if you could, it could change out from under you. We do have some ideas about updating the export management, but nothing concrete yet. Even then, we'll need to maintain backward compatibility, so I doubt we can change the user experience in a fundamental way at this point. --=20 Jeff Layton