From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35627C001DC for ; Wed, 26 Jul 2023 09:21:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF7856B0071; Wed, 26 Jul 2023 05:21:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA8806B0074; Wed, 26 Jul 2023 05:21:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4A3C8D0001; Wed, 26 Jul 2023 05:21:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 91D446B0071 for ; Wed, 26 Jul 2023 05:21:07 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5EF671601D6 for ; Wed, 26 Jul 2023 09:21:07 +0000 (UTC) X-FDA: 81053218974.19.24C4C5F Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) by imf15.hostedemail.com (Postfix) with ESMTP id 5E4ACA0004 for ; Wed, 26 Jul 2023 09:21:05 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=kMv6YWq3; spf=pass (imf15.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690363265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7Vnbbe8QuBX5IRYOyrvoqHk8WWyxAnIOQvNq7rt3Y5Y=; b=v7h8ltlEIjDyvicBtVi+yBy6ItPj4JYdvoXCwS30mZ/PJwIjHFem4Nfp33p14QItUelSTf tV8u5qltOfezdyD7FMwLKba3zKj2NERjJMarwjNNjCmGzeZttiwFWWhB4v9KPDFX3Fnbuw RjyNIEAv1sRnHzo4N/GYowUdDHfz+/E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690363265; a=rsa-sha256; cv=none; b=ajOVBXJm4bcaKHFd0JX4oUqb+cqHB2nfaHIZ704pHB+npldZqOiHcOQX61GDqF+uIT/exY FTEy5MR7gaFp4yBRMX7I9LqWnEqN+zx0hyXm3F3yG4j7zsKsC//9NxoGNqZXb7EeyjX245 5fBHdroNQDgAYdxbs5R2FguKyX8aZdc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=kMv6YWq3; spf=pass (imf15.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.166.47 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-77dcff76e35so80534039f.1 for ; Wed, 26 Jul 2023 02:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690363264; x=1690968064; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7Vnbbe8QuBX5IRYOyrvoqHk8WWyxAnIOQvNq7rt3Y5Y=; b=kMv6YWq3e1+EWrbASVGI+G088ii73Fem/3I6VWvBzdurPzbdbS5fA2RHQQMLz4AOt4 QngIWAV+s2uZUHK0vckMw0bfgtFV0R5eMbZlIk8/4w/wEVCJ5y5HwXF0DUiZjpzQho8t GXjQcaARWKdDQm6TOuzP1j52qtjLaAhVczvWaaLuobF1qPY5atrskgUIXJQL3lYTey8z 3gvyQ55zN42zfh91LApyOvBpv3V6BxPnFobMIvKLNhs41DtS3MI2Zhwie6ylRR2RxuF8 50dWB5Tz79PFVi03oGgeTfo0ercw9F6h7q/ECB9SYkDgRGeW/OcVP5UyZnJ2fh3Kr582 LeCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690363264; x=1690968064; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7Vnbbe8QuBX5IRYOyrvoqHk8WWyxAnIOQvNq7rt3Y5Y=; b=SIewk9du8OzW/rBZpSHFu+gDNcHAnFm7LB3MAn0W1yUqrbEmQkU4x69lIWWufWWkHq oGYhicALsII7Wp6CzPUTTvkancongCMrWYRLwx1kjOd9n1ivkgTNPLGFjzg1SYhBNedL 3qX+88Pi0a4Y+cvgRSsZ/E+Z1Qhgi6pRVhoEcEc1xvZeB5nXsghU8n3YnY9zrLVBBTB5 F2IxNWF9QiWRZnmIOCUHD0IDxgGrAdoCFltWbAAI0vBE2xGNRLBoKkgb70imOqQJrDE7 msCbaWBJn606oTAJK46LbWAabvZmUFvwGujd5O+UeOBdk9IIa2Y3aynWxU3GI+Zz8BxI EikA== X-Gm-Message-State: ABy/qLaLK+0XlbjuhyidetzgmvTtoqNZouZxFAtZUIg4FYT+8K4xci6u HvRCZolorpy7CbJ96C5PGtcETw== X-Google-Smtp-Source: APBJJlFD+0JL20cmcfz8xSZcxHSPSuKA9am5rBHzXLXGZAWVolxxOeef+bBAtrNC9deWoQ1MX3gUWg== X-Received: by 2002:a6b:3b44:0:b0:787:1926:54ed with SMTP id i65-20020a6b3b44000000b00787192654edmr1450699ioa.1.1690363264233; Wed, 26 Jul 2023 02:21:04 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id j1-20020a63b601000000b005638a70110bsm9005279pgf.65.2023.07.26.02.20.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 02:21:03 -0700 (PDT) Message-ID: <0caf10e8-e54b-3c1b-7df5-d95adc757ba7@bytedance.com> Date: Wed, 26 Jul 2023 17:20:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 03/47] mm: shrinker: add infrastructure for dynamically allocating shrinker Content-Language: en-US To: Dave Chinner Cc: akpm@linux-foundation.org, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-4-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5E4ACA0004 X-Rspam-User: X-Stat-Signature: 3xpamgoji8y8hye7k3y7tc3pyo6fph35 X-Rspamd-Server: rspam03 X-HE-Tag: 1690363265-629821 X-HE-Meta: U2FsdGVkX18IRsOyQIhBTT66FLueuRnGRWIA27FIyu3gtOjIKAS7nGWtnCcUbLWALyvSWuLruEtoj+ZlyrjG/80617JvRK2Lqd5K/JQnCjEggTAFfJeSMD+6v2iJLKMZO6ClCONOALRhwJ/Oi+E+Gwsa281wlN2vY+9vzIhou0kh+4M1S3UM/tCk2maW13YC16QEUEJ4t0f4aAa7LyPptVY6PULPMtBzIkN7wHEwaAho1a6sA1Pngclldr5qlmo/qf2DO8BrmY5Wfe97dCl2YmqKwWny8LrlxhgjZqR25/cKm7vS33hos+g/Cgn1zirZ+4Oxp1IzkUHQMoE/AJVZxknKcfLD8C+jSE/7AkwLesdBJXWPCzKBllRuTEDDX9a3IrWm9Wj/ztFNKVd2axMm7jBoIC1+6efIflK6N8KQIk6XfHNJ6+QnhCjyEg/Ve22AC6H9T6pZViI0knBwpYeMzPQSZ2QZtBHnGB7wE3m/kLeJ1fZBKydySrIKHixeiTdFFXVhlWi3Rjuf2TB7xLELyXEtlV8nXmqPZA7GiEdFPGKAjEEEeFV5ttKAE7kXlL5x2z3G24qLhImuuY6Ojf/cx17SIY0ehmL0ccprQz/7NNP9xHl6RxGi2CsvkpXWa+kFy47whs4Ok68uiEWAa4uDn9omnWKeX3ht2WzM8WdzxO/yvgWbcX0WzmKAaBiDG0abFKUK6k4Wg4cihZHOIjDK46EFYeCJhPuLjDi7LyUuLypQifxrdARMoLFuDfXemL+dUECTu8gsgRHI31V1Lw5EqiybYsBJY2exWkeyYS4h3SSnOTofFUaO00p7X4se60vd/5LhhAR/WtfPK+QJWUHMeOzbno415OvjX4Aido2xuUt9IAz/GQliE3IKTA2usCb5N+oRi75kOcryplnqSgPK2t18YsvgRjIVj9L0q7wZqaXF4jOaQv4o+B4A5Qu8/XrZxNrMhGiznndAndrCAu4 FekdQmW6 YLc2Wuf4JbFqKPugjxjBGwqo+0X5ge0X9EdICyoPT+xYUdth6kExxXxsKJyw4An3w+zHUg8iFxXAjKdocMUbRZWB9NZYl6Ys+52iynvAF72wdet3FERnDmV7Qn/x3c5pCG7FqGuvJNoyEFiIRWh3K0g0bJN4a/HOOFTYP5aQzXKjS5SohCitgrIcsKHCBuc42+AEly3506NpUskhkZWIHO+rpe/5F45pFR8IytCceEswqFwp6XlWP5DXbEylZGc9c4lZr/pw5/EqqD4g7hSj9uo5W+5+5jRasWA06mzxTbSLlQ6OH3TF9+41eCl0McdEw/Xyc3Wxg+r40t7t3G5fZU2Bh01eEsfA3QShlDIn/znKoOlrC6iPtWcZqSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Dave, On 2023/7/26 15:26, Dave Chinner wrote: > On Mon, Jul 24, 2023 at 05:43:10PM +0800, Qi Zheng wrote: >> Currently, the shrinker instances can be divided into the following three >> types: >> >> a) global shrinker instance statically defined in the kernel, such as >> workingset_shadow_shrinker. >> >> b) global shrinker instance statically defined in the kernel modules, such >> as mmu_shrinker in x86. >> >> c) shrinker instance embedded in other structures. >> >> For case a, the memory of shrinker instance is never freed. For case b, >> the memory of shrinker instance will be freed after synchronize_rcu() when >> the module is unloaded. For case c, the memory of shrinker instance will >> be freed along with the structure it is embedded in. >> >> In preparation for implementing lockless slab shrink, we need to >> dynamically allocate those shrinker instances in case c, then the memory >> can be dynamically freed alone by calling kfree_rcu(). >> >> So this commit adds the following new APIs for dynamically allocating >> shrinker, and add a private_data field to struct shrinker to record and >> get the original embedded structure. >> >> 1. shrinker_alloc() >> >> Used to allocate shrinker instance itself and related memory, it will >> return a pointer to the shrinker instance on success and NULL on failure. >> >> 2. shrinker_free_non_registered() >> >> Used to destroy the non-registered shrinker instance. > > This is a bit nasty > >> >> 3. shrinker_register() >> >> Used to register the shrinker instance, which is same as the current >> register_shrinker_prepared(). >> >> 4. shrinker_unregister() > > rename this "shrinker_free()" and key the two different freeing > cases on the SHRINKER_REGISTERED bit rather than mostly duplicating > the two. OK, will do in the next version. > > void shrinker_free(struct shrinker *shrinker) > { > struct dentry *debugfs_entry = NULL; > int debugfs_id; > > if (!shrinker) > return; > > down_write(&shrinker_rwsem); > if (shrinker->flags & SHRINKER_REGISTERED) { > list_del(&shrinker->list); > debugfs_entry = shrinker_debugfs_detach(shrinker, &debugfs_id); > } else if (IS_ENABLED(CONFIG_SHRINKER_DEBUG)) { > kfree_const(shrinker->name); > } > > if (shrinker->flags & SHRINKER_MEMCG_AWARE) > unregister_memcg_shrinker(shrinker); > up_write(&shrinker_rwsem); > > if (debugfs_entry) > shrinker_debugfs_remove(debugfs_entry, debugfs_id); > > kfree(shrinker->nr_deferred); > kfree(shrinker); > } > EXPORT_SYMBOL_GPL(shrinker_free); Ah, I will change all new APIs to use EXPORT_SYMBOL_GPL(). Thanks, Qi >