From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE678C28B28 for ; Wed, 12 Mar 2025 12:41:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E4AB280002; Wed, 12 Mar 2025 08:41:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 29453280001; Wed, 12 Mar 2025 08:41:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15BAD280002; Wed, 12 Mar 2025 08:41:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EE827280001 for ; Wed, 12 Mar 2025 08:41:23 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 44D0DB878F for ; Wed, 12 Mar 2025 12:41:25 +0000 (UTC) X-FDA: 83212859730.12.AA2059C Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf04.hostedemail.com (Postfix) with ESMTP id 0BDAA4000E for ; Wed, 12 Mar 2025 12:41:21 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=FdwTcpJY; spf=pass (imf04.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741783283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=byoy4lGPHlk+/7jnyQFo8ZlkUybA3oGJHC4262MlS70=; b=1Q2shduq/5U32gLDzZsgLaAwD26IyjgnYWgrC1FN47p2WfDw19PofmqRahxsUTEG0SiCXK nDMl6Bz3G8HBNYDe1bGug3F/KR3PUheO9F8M+saEzMCb8m9lITtDv5tyUJoq6N7+W6Qap/ ZmOQF5jfpo/jRcXaUkNpe1q+RdMmFGE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=FdwTcpJY; spf=pass (imf04.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741783283; a=rsa-sha256; cv=none; b=eMoBA7/tMDlQo/X8uBMDsfGqA/we9V4MxqRyBLEDBTQj7s3g5uuBrr9zawouLkRNsdlp6E NVJhc2zMOQXPjMxwV7+OOemCpvHINQteMuBWDtZlKN9KyvyZ+osBZeGDX+eDN2J+BgCo8K av0ppNN7hpo2pXEDWlphqGQdow++RjI= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1741783277; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=byoy4lGPHlk+/7jnyQFo8ZlkUybA3oGJHC4262MlS70=; b=FdwTcpJYhVn/r/jbnQnRTNV4nz0fAtUeZul4k64VOzwRPorBOC0/BbFoEF9KsQ66vvdTSmn5CGMNyfIvMY5406KakNxjY5cppZxioh+EJHHl5FfWEL+PiiKQaPKRy0DCisEk9hhUH8T9HpdBOABkY5eQLcbA2eqi9lo9xXV1uXU= Received: from 30.74.129.75(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0WRCvGy4_1741783275 cluster:ay36) by smtp.aliyun-inc.com; Wed, 12 Mar 2025 20:41:15 +0800 Message-ID: <0ca82e20-1424-4564-972f-4f7ffb73ccaf@linux.alibaba.com> Date: Wed, 12 Mar 2025 20:41:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: alloc_pages_bulk: remove assumption of populating only NULL elements To: Yunsheng Lin , NeilBrown Cc: Yunsheng Lin , Dave Chinner , Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Carlos Maiolino , "Darrick J. Wong" , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Olga Kornievskaia , Dai Ngo , Tom Talpey , Luiz Capitulino , Mel Gorman , kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-nfs@vger.kernel.org References: <> <316d62c1-0e56-4b11-aacf-86235fba808d@linux.alibaba.com> <174173371062.33508.12685894810362310394@noble.neil.brown.name> <14ef70cc-beba-4abb-b206-e9fb29381023@linux.alibaba.com> From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0BDAA4000E X-Stat-Signature: tbtyzhirk7c3g8a44tbkstpxacx53hta X-HE-Tag: 1741783281-217642 X-HE-Meta: U2FsdGVkX1857WQ4Qzfx4wUHPEh0gUfVhKBfFOXlRQC7NMssVAU2CAcGId24UF54E3wI4wPlasdw0VoTwwW3bqTbgSlX/V0XrxWH4WNkOJXCuhyu0qQN507aRY0qOKmLL9VqW5SPvzG24iDFGEjPfj03JbMvZWpPAIkpBAYo24uK3HQWD2alAOLk2n5gUwH5cNz118991Net0SSshWOZzKobLSidHZG9uBuAYP+KEc0D9stVmMGAC80XpbDeiStrSjux7HkEZ5YmsDZnvAL7pYsVQmJC7intsgmcd8bsnygnISwVaNHxnR8n/Pd1topxktgE6LIXMLq81kIXGNtDwxY2s4j1DtZ+qtMU37BR+iY4jyczuwg4Ft/bvgB3E7UxYSAzGCHBrEp9gVt6AlABJPIZ17x7ABmrwPrH3RXR4d9OauUAi1pHGB00ewquCYWuwkIFKQcv1GRxneoM7bJVZyrbli8oJBj2ztSkfYJ7JKgfgxWJW15FAIZq/3H72ODpCW5IkvBarqQ4L6h0rGtkREQhCZegLnrWGcmtukWPi9VVlucBOOLgRjUnJzGvgDCordxJF4uNRiVnKsh0hGbbx5lbsK/udbOMMkzeBmrAmpU9Y5uB48bd9vZPgQTWo2LoPkdGpm+TmTg97DyUjbfXVuUn0LmUrO9ehjQLXkdOP6WgA/8hthq8upgYGhvJMLyESJGDjcEosZH93NxmlXZ2S6/REhj4KxmpUSRsbjyTDvz81UlsW8QDa3HWkkb+WNgj8ZuGRn0N7onkqQfn5XFBfHWMBxi12tYiCSKchZeosi5nHTW8z5nNs26mC60TwwzDE5l7TkgLeHr+YI54YH37bPNRiYKZQxuQnWAHypuJu28cUpQahqJhyKwrXTxMx0eoXFpH//KmSbK1dcHLr6anemLwGoyn5l6rLOBQDwgHuTZR8tQjqT0hjGl5+U8gagTaetTgzzZL6VeXG4m1eOC K8MOZm/u Fe/0ituUjkUrm4GOyP5CUkKQyfSqYMDwZMkcRHCgL20iTZfDBW08r97bhJy6UZP4EQTs+5sWCHPyRekrHistuuxi4TaP+Mc/v3fI95ETqQb2fRMyGh7vZsfu1WROVWq7diw9c6tckOid/giWu1TQZ0j9RYhV4Q+lAYnvRupDlVDw9kwgim3YEstRACOOzXB1z3dOExmj3A5cGQzRZ2ydq7RFNDVYeCbfv+/0RBav3DmXyKscVfBrPcsF//Lw8nHwHqvLARtfXI9J4tEt96+TLCiKuZBg/KRHbB/VyyZ/MlMeEvbdZLviVYp7ZA3KuzslY8G/k X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/3/12 20:05, Yunsheng Lin wrote: > On 2025/3/12 9:45, Gao Xiang wrote: >> >> >> On 2025/3/12 06:55, NeilBrown wrote: >>> On Mon, 10 Mar 2025, Gao Xiang wrote: >>>> >>>>    - Your new api covers narrow cases compared to the existing >>>>      api, although all in-tree callers may be converted >>>>      properly, but it increases mental burden of all users. >>>>      And maybe complicate future potential users again which >>>>      really have to "check NULL elements in the middle of page >>>>      bulk allocating" again. >>> >>> I think that the current API adds a mental burden for most users.  For >>> most users, their code would be much cleaner if the interface accepted >>> an uninitialised array with length, and were told how many pages had >>> been stored in that array.> A (very) few users benefit from the complexity.  So having two >>> interfaces, one simple and one full-featured, makes sense. > > Thanks for the above clear summarization. > >> >> Ok, I think for this part, diferrent people has different >> perference on API since there is no absolutely right and >> wrong in the API design area. >> >> But I have no interest to follow this for now. > > Just to be clearer, as erofs seems to be able to be changed to > use a simple interface, do you prefer to keep using the full-featured > interface or change to use the simple interface? Please keep using the old interface because I don't have any bandwidth on this considering no real benefit. Thanks, Gao Xiang