From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50639C0219B for ; Mon, 10 Feb 2025 18:41:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA1F7280002; Mon, 10 Feb 2025 13:41:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B2CE5280001; Mon, 10 Feb 2025 13:41:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A4B0280002; Mon, 10 Feb 2025 13:41:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 78B97280001 for ; Mon, 10 Feb 2025 13:41:07 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2FAC2140430 for ; Mon, 10 Feb 2025 18:41:07 +0000 (UTC) X-FDA: 83104902174.07.27D5F77 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id C38004000F for ; Mon, 10 Feb 2025 18:41:04 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FBoGSICw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739212864; a=rsa-sha256; cv=none; b=uNoLVmr5lCjmXYjvfDNf9KYMFru1nK6dQm+JLudGWHFMOrjC+0fFCGHS/p0xesNMBknSyc Ii0wSgSecpM4aC8v9555YPJU8R2wSTxUqvU81+IyGUwC+gp2KlG/TcAHltQ2pXr/Q3vPvF Hz4BbqhXpJoxWQ/aFAAQ1T+FgCiwB2c= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FBoGSICw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739212864; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g1KV9WSg/lyUU/31KD2wiBY4CVQnFn2Ocr7fjoXlBPA=; b=KDfrhWM7Oq/ZHgrChSKqayCsghV7VU77rpYGYyq6pdsvFUzZ0CKJW08ReuzoEq9TDV2O2I q6UqiKbuntifoJaelF+iBoW/m5b8bMbEC1ywxTDMtcTmUD4Ewc4gvKjpSooofDj0/F1KQF aN1yYHXFNCgzqHpS1MRtCCDnjlH1RWY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739212864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=g1KV9WSg/lyUU/31KD2wiBY4CVQnFn2Ocr7fjoXlBPA=; b=FBoGSICwOjao2ksavZ6DsVQBDxV6t2WTOrGHN/9wKOZ4EEvGgVkt0m1J7n/8e0Qin/3d8E u0srzkXkY+ZakH5q9jQLCVG3+cYuZOlcf3lCjsIe9fWBluz2KL2CCWTFYjavlcgpH5dqs/ pEl3KIb3bB9dEEiD2s+zPokAId+M0VA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-vyLR_l6OOy-tRHG3OaCl8g-1; Mon, 10 Feb 2025 13:41:00 -0500 X-MC-Unique: vyLR_l6OOy-tRHG3OaCl8g-1 X-Mimecast-MFC-AGG-ID: vyLR_l6OOy-tRHG3OaCl8g Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38de0201875so589637f8f.0 for ; Mon, 10 Feb 2025 10:41:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739212860; x=1739817660; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=g1KV9WSg/lyUU/31KD2wiBY4CVQnFn2Ocr7fjoXlBPA=; b=PCut0MTj154P0lREB+cTzOCCh2sXh4lGRsU48e5sjz8MFmhKGc6fFDp/wwFpiwyNdy S2bNQWVOPTKT+Zz1N2ZEUsVrpbA3FX+bSfZ89jbEckw1Ar+tcyiuo+Fp2/luuU949sYo KtdhTUHKeHwUp8s1KTR5jiSpt7hViQbjlBHU4vHU3tcOefegKqvRTFSKw95v20XJjcUx qh66I7kzaHCMgf68IlQf12BrnnWiJnM6jDwzJCoXoolTAm2+NwVzvJj50AJbtaPblnlT 1BLV6Mlyejnwvy+WPIW7q3NNJvnOSYhLsdJ7SlWD5X9PT9JT1Zmab9hsWEyONcoymfKy fqCA== X-Forwarded-Encrypted: i=1; AJvYcCUu4Fr9sjj1pPY8Hq6BIuGpmAqFPQ3EeOYYSRXfo7y6B5RDq7aVfbKovwYER4SUkWcmHnbk+mZd9A==@kvack.org X-Gm-Message-State: AOJu0YwY7URaAFQXeyBOZQ+pOL7A0C51gnipITeSg3AAXGL5JBqHEX0k AS7aYU473NIgdpcDWUxfKShkOVfB9TPGTzA/oxF76aT5QZsDkgxLRKWGBA5eCXV5rdlb61kNIG5 OMVCPh/qO43bCbvqnMrEeH2af5hpPCny7/iHlfLg0bodToKoF X-Gm-Gg: ASbGncuNgur5+lF2bUFBv6234pjgW/Bbb3kr2RtKks7uPlxwdvyN2miXFs6K/A5XY5J stjN4G7Y4las8yDx9QFo4vvP/+BbcKQQwwqL/XAkshtXNa1HauoDBayYbJMAyHH5QWeBmBlnKI0 saiH+5Y44DtjkNPZ7Js7WtP8Kw88V8P9fjl5eLtcYju+TfG4ELcBk/Wsfx5EtjahNMZvR0dVmj0 4FmslxsYUZAD25IHNM0pM7ZvP7djOnfWXu7kqykw6zgo7oP3a0u5R4i5DqA/tcv5+ApNyHY/j/m Of9QmJoDhxTXAnOQHz46u3iHpZYRFmUyPk9W8eMjCponHBWhxov9x/uEqohL6TnNnyjd7QadshP zM9SCDaoNM0MT3wyZveiyJPAfU3vt/tpt X-Received: by 2002:a05:6000:4023:b0:38d:e420:3984 with SMTP id ffacd0b85a97d-38de4203c6fmr720427f8f.39.1739212859630; Mon, 10 Feb 2025 10:40:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHGdyRFSrPW6CDaatY3A9b5Pbjiq+vqKKBwRSMaTLmNlwLMqalsMGCRptdeQalX+PBAO6tSww== X-Received: by 2002:a05:6000:4023:b0:38d:e420:3984 with SMTP id ffacd0b85a97d-38de4203c6fmr720406f8f.39.1739212859214; Mon, 10 Feb 2025 10:40:59 -0800 (PST) Received: from ?IPV6:2003:cb:c734:b800:12c4:65cd:348a:aee6? (p200300cbc734b80012c465cd348aaee6.dip0.t-ipconnect.de. [2003:cb:c734:b800:12c4:65cd:348a:aee6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-439471bf782sm28276465e9.39.2025.02.10.10.40.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2025 10:40:58 -0800 (PST) Message-ID: <0c8640f5-2a80-45ff-a922-476a5fd5f82d@redhat.com> Date: Mon, 10 Feb 2025 19:40:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 13/20] mm/memory: Add vmf_insert_page_mkwrite() To: Alistair Popple , akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: Alison Schofield , lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fl_AqV6tIo3mtg4iuS7tnPUj3m5dox4hyTUpiqTDdY0_1739212860 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C38004000F X-Stat-Signature: qef1ddtw8rbftg97dfs7f9qajy6qm7f9 X-Rspam-User: X-HE-Tag: 1739212864-265441 X-HE-Meta: U2FsdGVkX19BSNNelJLNuW8Mae9SCn25u3IOCutpCAOAtnpY0Q6wt7qb2Uf+ibc1k1qSohUnKCa/HXY7CW00PKpfBFcktKSFwMHtMJglvvz1kipgd5wzT17sFjK+0zUjEIstY1idIinBKHbGSeF1IDYZeRG4crwnyOkv/qY/rxbz5LZuOT1pkRIpQOXf6GLdeFVi7fiX8h0/V5PTjMT+GYWK5EPandg0BRu78U/pwTsWS2ALvHswAO6ZikPK/71KakkkHIegOZ7+Pp0m+jh6mJfKYoy6PfTnzilFrsD48pckq/URTZYylm5FCZ4yk+2pdeRDbIS6ZKFylDz0N6OO7hI+UFkR8B6LJw9uzfirwkWyR1HWJ3HJIHeXszwSSCsEKlyNvmgDStnWXlsjVu/bgQgQ79/NpZx4V5Xqfjn5su/vI5ohhzBcj8LqWTjT6ij4wJlf2Cldua1+FSuhrbHZYqBRNRZ/81WtyMBylqmq3BuSXVbMAkxKfOkoUSl1WvCgC1Ms91PmhXWwiDWkDiS8KL62YkFZaGEi+Af+pcZM/fpTVoKdiQ83KSmAK8RBt68P5Ho++6xO1lNxXsBEqDcgH/Ciux2dm5q/h2umHuN6JEhgOZnB4bIYz579ApnXRwkU0TnjNDJrDTc/gFh6OjVzA64Trj4V9NwUpaiglbY1PME4wXQTunPwNVA3WNqeVcrBUr+v41c+mfrYMvrUq0C56pa6tNBsO4E3zS2nlyUNy13opxYDW/7Tua93iekHDutBRCvmoi2pAetrSdNAl2/J8xRzEgFcjrMP8PV/PaKNm4VICly8qdxvZSVJ6Hdg2dhiE90/L/M6Km8i16PoAojGlvQBkvfV0+HJLX8XujtZZel8K8e/C/j6K9CjcBZLpmUkD7lgYdNtB3SMpoGFll/et6P0FdF45EiF11I6szFW5Po5HUq6N18QXw0awCCA8ZoaWge0r6jULhwAgBkeRho vfV7tMWX ibQUpwnurK3UP4J9oKWWl9FLLwQGvD5yIjUObExdRV6jLiSWtc2xoEhKk3l1ro2tsylkWLt1tz0c7ZHrWzgA3VOnA48+s51Hu8degMl4vexo+xpmFZXQ43Wnmqi7P9QDeTYbWaMQZhcZrfCZeTWCpHl0//H+10Q+6Jc86CKxG0WB3+xnVBErKWcz9EvGVaIw+zuiY2MvVkXrrhoVNDKNk8P3NkM8BR+sHxJanmhwHa7V6qDQnDtyNGFslyOHy7d52VdhLIDl+OhksxGUiFbUu4k5mhlrh3+X+qJIRy1msDsJ/lCwqdDgT9DbiQq/v+pTwcIgoaImzo4tWRroOq+IeMCyGbf5KWYCWBrwIm21ESLf6PEiSxaaHAzOzi2Dc/W2akKb9X0l1VBfgogMRFf1pGLEpM2S17EOXQndXV/+YEPTulLodqKblsgpIPbrRVOsBq2R/D/qJ6zW+8J6BOGITWY/2ZjVDf6QD3rUwhkM79lwEMLbkmAnIgXNctBXYhjhaOBJBD6eMIFasXxFqDCehDcv745Bdexj9uXJGBu9xZDzQB/a/EPDdLvtZ2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.02.25 23:48, Alistair Popple wrote: > Currently to map a DAX page the DAX driver calls vmf_insert_pfn. This > creates a special devmap PTE entry for the pfn but does not take a > reference on the underlying struct page for the mapping. This is > because DAX page refcounts are treated specially, as indicated by the > presence of a devmap entry. > > To allow DAX page refcounts to be managed the same as normal page > refcounts introduce vmf_insert_page_mkwrite(). This will take a > reference on the underlying page much the same as vmf_insert_page, > except it also permits upgrading an existing mapping to be writable if > requested/possible. > > Signed-off-by: Alistair Popple > > --- > > Changes for v7: > - Fix vmf_insert_page_mkwrite by removing pfn gunk as suggested by > David. > > Updates from v2: > > - Rename function to make not DAX specific > > - Split the insert_page_into_pte_locked() change into a separate > patch. > > Updates from v1: > > - Re-arrange code in insert_page_into_pte_locked() based on comments > from Jan Kara. > > - Call mkdrity/mkyoung for the mkwrite case, also suggested by Jan. > --- > include/linux/mm.h | 2 ++ > mm/memory.c | 21 +++++++++++++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 7b1068d..6567ece 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3544,6 +3544,8 @@ int vm_map_pages(struct vm_area_struct *vma, struct page **pages, > unsigned long num); > int vm_map_pages_zero(struct vm_area_struct *vma, struct page **pages, > unsigned long num); > +vm_fault_t vmf_insert_page_mkwrite(struct vm_fault *vmf, struct page *page, > + bool write); > vm_fault_t vmf_insert_pfn(struct vm_area_struct *vma, unsigned long addr, > unsigned long pfn); > vm_fault_t vmf_insert_pfn_prot(struct vm_area_struct *vma, unsigned long addr, > diff --git a/mm/memory.c b/mm/memory.c > index 41befd9..b88b488 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -2622,6 +2622,27 @@ static vm_fault_t __vm_insert_mixed(struct vm_area_struct *vma, > return VM_FAULT_NOPAGE; > } > > +vm_fault_t vmf_insert_page_mkwrite(struct vm_fault *vmf, struct page *page, > + bool write) > +{ > + struct vm_area_struct *vma = vmf->vma; > + pgprot_t pgprot = vma->vm_page_prot; Probably could have avoided that temp without harming readability Acked-by: David Hildenbrand -- Cheers, David / dhildenb